| Message ID | 20190214182651.GA17161@arm.com |
|---|---|
| State | New |
| Headers | show |
| Series | [Committed,Arm] Fix test directive | expand |
On Thu, 14 Feb 2019 at 19:27, Tamar Christina <Tamar.Christina@arm.com> wrote: > > Hi All, > > This patch fixes a failing testcase due to a use of dg-options instead of > dg-additional-options. > Makes sense. It doesn't fail in any of the configurations I test though, in what case do you see it failing? > Committed under the GCC obvious > > Bootstrapped Regtested on arm-none-eabi and no issues. > > Ok for trunk? > > Thanks, > Tamar > > gcc/testsuite/ChangeLog: > > 2019-02-14 Tamar Christina <tamar.christina@arm.com> > > * gcc.target/arm/pr88850.c: change options to additional option. > > --
Hi Christoph, > > On Thu, 14 Feb 2019 at 19:27, Tamar Christina <Tamar.Christina@arm.com> > wrote: > > > > Hi All, > > > > This patch fixes a failing testcase due to a use of dg-options instead > > of dg-additional-options. > > > Makes sense. > It doesn't fail in any of the configurations I test though, in what case do you > see it failing? > It's failing on a system with a very old dejagnu version because dg-options isn't working as documented there and the options were being overridden. Regards, Tamar > > Committed under the GCC obvious > > > > Bootstrapped Regtested on arm-none-eabi and no issues. > > > > Ok for trunk? > > > > Thanks, > > Tamar > > > > gcc/testsuite/ChangeLog: > > > > 2019-02-14 Tamar Christina <tamar.christina@arm.com> > > > > * gcc.target/arm/pr88850.c: change options to additional option. > > > > --
diff --git a/gcc/testsuite/gcc.target/arm/pr88850.c b/gcc/testsuite/gcc.target/arm/pr88850.c index 66d0e9e620aef4f092a33ead79521901b5d89636..6edd6bcee54dbc843b539ff67399ee7a30a707e4 100644 --- a/gcc/testsuite/gcc.target/arm/pr88850.c +++ b/gcc/testsuite/gcc.target/arm/pr88850.c @@ -1,6 +1,6 @@ /* PR target/88850 */ /* { dg-do compile } */ -/* { dg-options "-O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon -fdump-rtl-final" } */ +/* { dg-additional-options "-O2 -march=armv7-a -mfloat-abi=softfp -mfpu=neon -fdump-rtl-final" } */ /* { dg-require-effective-target arm_neon_ok } */ typedef __builtin_neon_qi int8x8_t __attribute__ ((__vector_size__ (8)));