Patchwork [U-Boot] usb: r8a66597: Fix argument mistake of inl

login
register
mail settings
Submitter Nobuhiro Iwamatsu
Date July 11, 2011, 2:03 a.m.
Message ID <1310349827-23245-1-git-send-email-iwamatsu@nigauri.org>
Download mbox | patch
Permalink /patch/104148/
State Accepted
Commit 0b09f54a26169246e982357774b06276843047b3
Headers show

Comments

Nobuhiro Iwamatsu - July 11, 2011, 2:03 a.m.
Fail in build, because argument of inl used in r8a66597_read_fifo is wrong.

r8a66597.h:441:35: error: macro "inl" passed 2 arguments, but takes just 1
In file included from r8a66597-hcd.c:25:
r8a66597.h: In function ‘r8a66597_read_fifo’:
r8a66597.h:441: error: ‘inl’ undeclared (first use in this function)
r8a66597.h:441: error: (Each undeclared identifier is reported only once
r8a66597.h:441: error: for each function it appears in.)

Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>
---
 drivers/usb/host/r8a66597.h |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)
Remy Bohmer - Aug. 8, 2011, 7:41 p.m.
Hi,

2011/7/11 Nobuhiro Iwamatsu <iwamatsu@nigauri.org>:
> Fail in build, because argument of inl used in r8a66597_read_fifo is wrong.
>
> r8a66597.h:441:35: error: macro "inl" passed 2 arguments, but takes just 1
> In file included from r8a66597-hcd.c:25:
> r8a66597.h: In function ‘r8a66597_read_fifo’:
> r8a66597.h:441: error: ‘inl’ undeclared (first use in this function)
> r8a66597.h:441: error: (Each undeclared identifier is reported only once
> r8a66597.h:441: error: for each function it appears in.)
>
> Signed-off-by: Nobuhiro Iwamatsu <iwamatsu@nigauri.org>

Applied to u-boot-usb. Thanks.

Kind regards,

Remy

Patch

diff --git a/drivers/usb/host/r8a66597.h b/drivers/usb/host/r8a66597.h
index 9af6446..ca1b671 100644
--- a/drivers/usb/host/r8a66597.h
+++ b/drivers/usb/host/r8a66597.h
@@ -438,7 +438,7 @@  static inline void r8a66597_read_fifo(struct r8a66597 *r8a66597,
 
 	count = len / 4;
 	for (i = 0; i < count; i++)
-		inl(p[i], r8a66597->reg + offset);
+		p[i] = inl(r8a66597->reg + offset);
 
 	if (len & 0x00000003) {
 		unsigned long tmp = inl(fifoaddr);