[1/2] smbinfo: Update the usage text with the new infolevels
diff mbox series

Message ID 20190213054737.31425-2-lsahlber@redhat.com
State New
Headers show
Series
  • More smbinfo
Related show

Commit Message

Ronnie Sahlberg Feb. 13, 2019, 5:47 a.m. UTC
Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
---
 smbinfo.c | 18 ++++++++++++++++++
 1 file changed, 18 insertions(+)

Comments

Steve French Feb. 13, 2019, 6:35 a.m. UTC | #1
I prefer to only document the most useful ones to make it more
readable (allinfo is something users would use - the others are
developer only and included in the allinfo) to make it easier to read
- or add a verbose help if we really want to list all of them.

For example - see attached.

There may be other ways to make it more readable though

On Tue, Feb 12, 2019 at 11:47 PM Ronnie Sahlberg <lsahlber@redhat.com> wrote:
>
> Signed-off-by: Ronnie Sahlberg <lsahlber@redhat.com>
> ---
>  smbinfo.c | 18 ++++++++++++++++++
>  1 file changed, 18 insertions(+)
>
> diff --git a/smbinfo.c b/smbinfo.c
> index de9ebf6..c2cea9e 100644
> --- a/smbinfo.c
> +++ b/smbinfo.c
> @@ -57,6 +57,24 @@ usage(char *name)
>  {
>          fprintf(stderr, "Usage: %s <command> <file>\n"
>                  "Commands are\n"
> +               "  fileaccessinfo:\n"
> +                "      Prints FileAccessInfo for a cifs file.\n"
> +               "  filealigninfo:\n"
> +                "      Prints FileAlignInfo for a cifs file.\n"
> +               "  fileallinfo:\n"
> +                "      Prints FileAllInfo for a cifs file.\n"
> +               "  filebasicinfo:\n"
> +                "      Prints FileBasicInfo for a cifs file.\n"
> +               "  fileeainfo:\n"
> +                "      Prints FileEAInfo for a cifs file.\n"
> +               "  fileinternalinfo:\n"
> +                "      Prints FileInternalInfo for a cifs file.\n"
> +               "  filemodeinfo:\n"
> +                "      Prints FileModeInfo for a cifs file.\n"
> +               "  filepositioninfo:\n"
> +                "      Prints FilePositionInfo for a cifs file.\n"
> +               "  filestandardinfo:\n"
> +                "      Prints FileStandardInfo for a cifs file.\n"
>                  "  secdesc:\n"
>                  "      Prints the security descriptor for a cifs file.\n"
>                  "  quota:\n"
> --
> 2.15.1
>

Patch
diff mbox series

diff --git a/smbinfo.c b/smbinfo.c
index de9ebf6..c2cea9e 100644
--- a/smbinfo.c
+++ b/smbinfo.c
@@ -57,6 +57,24 @@  usage(char *name)
 {
         fprintf(stderr, "Usage: %s <command> <file>\n"
                 "Commands are\n"
+		"  fileaccessinfo:\n"
+                "      Prints FileAccessInfo for a cifs file.\n"
+		"  filealigninfo:\n"
+                "      Prints FileAlignInfo for a cifs file.\n"
+		"  fileallinfo:\n"
+                "      Prints FileAllInfo for a cifs file.\n"
+		"  filebasicinfo:\n"
+                "      Prints FileBasicInfo for a cifs file.\n"
+		"  fileeainfo:\n"
+                "      Prints FileEAInfo for a cifs file.\n"
+		"  fileinternalinfo:\n"
+                "      Prints FileInternalInfo for a cifs file.\n"
+		"  filemodeinfo:\n"
+                "      Prints FileModeInfo for a cifs file.\n"
+		"  filepositioninfo:\n"
+                "      Prints FilePositionInfo for a cifs file.\n"
+		"  filestandardinfo:\n"
+                "      Prints FileStandardInfo for a cifs file.\n"
                 "  secdesc:\n"
                 "      Prints the security descriptor for a cifs file.\n"
                 "  quota:\n"