Patchwork [U-Boot,V2,ARM] eb_cpux9k2: add USB host support to board

login
register
mail settings
Submitter Jens Scharsig
Date July 10, 2011, 7:21 p.m.
Message ID <4E19FB9F.3030505@scharsoft.de>
Download mbox | patch
Permalink /patch/104091/
State Accepted
Delegated to: Reinhard Meyer
Headers show

Comments

Jens Scharsig - July 10, 2011, 7:21 p.m.
Am 10.07.2011 14:37, schrieb Albert ARIBAUD:
> Hi Jens,
>
> Le 10/07/2011 11:14, Jens Scharsig a écrit :
>> * add USB host support to eb_cpux9k2 board
>>
>> Signed-off-by: Jens Scharsig<js_at_ng@scharsoft.de>
>> ---
>> include/configs/eb_cpux9k2.h | 14 ++++++++++++++
>> 1 files changed, 14 insertions(+), 0 deletions(-)
>
> This fails to apply properly on current u-boot/master or
> u-boot-arm/master or u-boot-atmel/master. Which repository/branch is it
> supposed to be applied to?

The patch is correct but anything between me an you/list modifies the mails.
There are additional spaces in my file.

Until I found why the mta's adds. I have attache the patch as file.

Best regards

Jens Scharsig
Reinhard Meyer - July 11, 2011, 11:10 a.m.
Dear Jens Scharsig,
> Am 10.07.2011 14:37, schrieb Albert ARIBAUD:
> > Hi Jens,
> >
> > Le 10/07/2011 11:14, Jens Scharsig a écrit :
> >> * add USB host support to eb_cpux9k2 board
> >>
> >> Signed-off-by: Jens Scharsig<js_at_ng@scharsoft.de>
> >> ---
> >> include/configs/eb_cpux9k2.h | 14 ++++++++++++++
> >> 1 files changed, 14 insertions(+), 0 deletions(-)
> >
> > This fails to apply properly on current u-boot/master or
> > u-boot-arm/master or u-boot-atmel/master. Which repository/branch is it
> > supposed to be applied to?
> 
> The patch is correct but anything between me an you/list modifies the mails.
> There are additional spaces in my file.
> 
> Until I found why the mta's adds. I have attache the patch as file.

Let me guess... using Thunderbird or alikes? They have issues with
spaces.
Please simply and just use git send-email instead!

The patch you sent as an attachment does indeed apply, but I remember
its against the rules to use it; however patchworks does correctly
handle it and I could get it with "pwclient get 104091"; so IMHO it
should be fine to use it - Wolfgang?

Best Regards,
Reinhard
Wolfgang Denk - July 11, 2011, 2:12 p.m.
Dear "u-boot@emk-elektronik.de",

In message <1310382637.7288.7.camel@ubuntu> you wrote:
>
> The patch you sent as an attachment does indeed apply, but I remember
> its against the rules to use it; however patchworks does correctly

Indeed patches shpuld be sent inline which makes reviewing and
commenting much easier.

> handle it and I could get it with "pwclient get 104091"; so IMHO it
> should be fine to use it - Wolfgang?

If it's OK with you, just go on and apply it.

Best regards,

Wolfgang Denk
Jens Scharsig - July 11, 2011, 4:21 p.m.
Am 2011-07-11 13:10, schrieb u-boot@emk-elektronik.de:
> Dear Jens Scharsig,
<snip>
>> The patch is correct but anything between me an you/list modifies the mails.
>> There are additional spaces in my file.
>>
>> Until I found why the mta's adds. I have attache the patch as file.
> 
> Let me guess... using Thunderbird or alikes? They have issues with
> spaces.

You are right. Since thunderbird was updated to 3.1.xx mails bad.
> Please simply and just use git send-email instead!

Thanks for suggestion,

Jens
Reinhard Meyer - July 26, 2011, 11:46 a.m.
Dear Jens Scharsig, Wolfgang Denk,
> Dear "u-boot@emk-elektronik.de",
> 
> In message <1310382637.7288.7.camel@ubuntu> you wrote:
> >
> > The patch you sent as an attachment does indeed apply, but I remember
> > its against the rules to use it; however patchworks does correctly
> 
> Indeed patches shpuld be sent inline which makes reviewing and
> commenting much easier.
> 
> > handle it and I could get it with "pwclient get 104091"; so IMHO it
> > should be fine to use it - Wolfgang?
> 
> If it's OK with you, just go on and apply it.
Applied to u-boot-atmel/next
Thanks, Reinhard

Patch

From c8a45565b06cceb831ec4478e9d54edbf6505869 Mon Sep 17 00:00:00 2001
From: Jens Scharsig <js_at_ng@scharsoft.de>
Date: Sun, 10 Jul 2011 20:28:27 +0200
Subject: [PATCH] * add USB host support to eb_cpux9k2 board
Cc: esw@bus-elektronik.de

Signed-off-by: Jens Scharsig <js_at_ng@scharsoft.de>
---
 include/configs/eb_cpux9k2.h |   14 ++++++++++++++
 1 files changed, 14 insertions(+), 0 deletions(-)

diff --git a/include/configs/eb_cpux9k2.h b/include/configs/eb_cpux9k2.h
index c4b1e65..b1fcec7 100644
--- a/include/configs/eb_cpux9k2.h
+++ b/include/configs/eb_cpux9k2.h
@@ -137,6 +137,8 @@ 
 #define CONFIG_CMD_PING
 #define CONFIG_I2C_CMD_NO_FLAT
 #define CONFIG_I2C_CMD_TREE
+#define CONFIG_CMD_USB
+#define CONFIG_CMD_FAT
 
 #define CONFIG_SYS_LONGHELP
 
@@ -167,6 +169,18 @@ 
 /*
  * Hardware drivers
  */
+#define CONFIG_USB_ATMEL
+#define CONFIG_USB_OHCI_NEW
+#define CONFIG_AT91C_PQFP_UHPBUG
+#define CONFIG_USB_STORAGE
+#define CONFIG_DOS_PARTITION
+#define CONFIG_ISO_PARTITION
+#define CONFIG_EFI_PARTITION
+
+#define CONFIG_SYS_USB_OHCI_MAX_ROOT_PORTS	1
+#define CONFIG_SYS_USB_OHCI_CPU_INIT
+#define CONFIG_SYS_USB_OHCI_REGS_BASE		0x00300000
+#define CONFIG_SYS_USB_OHCI_SLOT_NAME		"at91rm9200"
 
 /*
  * UART/CONSOLE
-- 
1.7.3.4