| Message ID | 20190212113808.3040-1-jagan@amarulasolutions.com |
|---|---|
| State | Not Applicable, archived |
| Headers | show |
| Series | [v2] dt-bindings: hwmon: Add missing documentation for lm75 | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Tue, Feb 12, 2019 at 5:08 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > > Add missing dt-binding documentation for lm75 hwmon sensor. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v2: > - Add all compatible nodes available in lm75. > > .../devicetree/bindings/hwmon/lm75.txt | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt Any comments on this? It is blocking some dts changes to get merge into Mainline.
On 2/20/19 9:22 AM, Jagan Teki wrote: > On Tue, Feb 12, 2019 at 5:08 PM Jagan Teki <jagan@amarulasolutions.com> wrote: >> >> Add missing dt-binding documentation for lm75 hwmon sensor. >> >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> >> --- >> Changes for v2: >> - Add all compatible nodes available in lm75. >> >> .../devicetree/bindings/hwmon/lm75.txt | 37 +++++++++++++++++++ >> 1 file changed, 37 insertions(+) >> create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt > > Any comments on this? It is blocking some dts changes to get merge > into Mainline. > Waiting for Rob's Ack. Guenter
Rob, On Thu, Feb 21, 2019 at 7:32 PM Guenter Roeck <linux@roeck-us.net> wrote: > > On 2/20/19 9:22 AM, Jagan Teki wrote: > > On Tue, Feb 12, 2019 at 5:08 PM Jagan Teki <jagan@amarulasolutions.com> wrote: > >> > >> Add missing dt-binding documentation for lm75 hwmon sensor. > >> > >> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > >> --- > >> Changes for v2: > >> - Add all compatible nodes available in lm75. > >> > >> .../devicetree/bindings/hwmon/lm75.txt | 37 +++++++++++++++++++ > >> 1 file changed, 37 insertions(+) > >> create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt > > > > Any comments on this? It is blocking some dts changes to get merge > > into Mainline. > > > > Waiting for Rob's Ack. Any comments?
On Tue, Feb 12, 2019 at 05:08:08PM +0530, Jagan Teki wrote: > Add missing dt-binding documentation for lm75 hwmon sensor. > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > Changes for v2: > - Add all compatible nodes available in lm75. > > .../devicetree/bindings/hwmon/lm75.txt | 37 +++++++++++++++++++ > 1 file changed, 37 insertions(+) > create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt > > diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt > new file mode 100644 > index 000000000000..12d8cf7cf592 > --- /dev/null > +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt > @@ -0,0 +1,37 @@ > +*LM75 hwmon sensor. > + > +Required properties: > +- compatible: manufacturer and chip name, one of > + "adi,adt75", > + "dallas,ds1775", > + "dallas,ds75", > + "dallas,ds7505", > + "gmt,g751", > + "national,lm75", > + "national,lm75a", > + "national,lm75b", > + "maxim,max6625", > + "maxim,max6626", > + "maxim,max31725", > + "maxim,max31726", > + "maxim,mcp980x", > + "st,stds75", > + "st,stlm75", > + "microchip,tcn75", > + "ti,tmp100", > + "ti,tmp101", > + "ti,tmp105", > + "ti,tmp112", > + "ti,tmp175", > + "ti,tmp275", > + "ti,tmp75", > + "ti,tmp75c", Some of these are in trivial-devices.yaml already. So you either need to remove them from there. Or you can move all these to trivial-devices and benefit from having a schema. I prefer the latter, but either way is fine. You can remove them from trivial-devices.yaml in a separate patch, so: Acked-by: Rob Herring <robh@kernel.org> Rob P.S. Third option is convert this doc to DT schema. Don't tell anyone, but you'll be a the top of my review queue.
On Thu, Feb 28, 2019 at 8:45 PM Rob Herring <robh@kernel.org> wrote: > > On Tue, Feb 12, 2019 at 05:08:08PM +0530, Jagan Teki wrote: > > Add missing dt-binding documentation for lm75 hwmon sensor. > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > Changes for v2: > > - Add all compatible nodes available in lm75. > > > > .../devicetree/bindings/hwmon/lm75.txt | 37 +++++++++++++++++++ > > 1 file changed, 37 insertions(+) > > create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt > > > > diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt > > new file mode 100644 > > index 000000000000..12d8cf7cf592 > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt > > @@ -0,0 +1,37 @@ > > +*LM75 hwmon sensor. > > + > > +Required properties: > > +- compatible: manufacturer and chip name, one of > > + "adi,adt75", > > + "dallas,ds1775", > > + "dallas,ds75", > > + "dallas,ds7505", > > + "gmt,g751", > > + "national,lm75", > > + "national,lm75a", > > + "national,lm75b", > > + "maxim,max6625", > > + "maxim,max6626", > > + "maxim,max31725", > > + "maxim,max31726", > > + "maxim,mcp980x", > > + "st,stds75", > > + "st,stlm75", > > + "microchip,tcn75", > > + "ti,tmp100", > > + "ti,tmp101", > > + "ti,tmp105", > > + "ti,tmp112", > > + "ti,tmp175", > > + "ti,tmp275", > > + "ti,tmp75", > > + "ti,tmp75c", > > Some of these are in trivial-devices.yaml already. So you either need to > remove them from there. Or you can move all these to trivial-devices and > benefit from having a schema. I prefer the latter, but either way is > fine. You can remove them from trivial-devices.yaml in a separate patch, > so: Thanks, Rob. I will remove trivial devices from here wrt trivial-devices.yaml in separate patch. Guenter, could you please pick this.
On Thu, Feb 28, 2019 at 11:00:44PM +0530, Jagan Teki wrote: > On Thu, Feb 28, 2019 at 8:45 PM Rob Herring <robh@kernel.org> wrote: > > > > On Tue, Feb 12, 2019 at 05:08:08PM +0530, Jagan Teki wrote: > > > Add missing dt-binding documentation for lm75 hwmon sensor. > > > > > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> [ ... ] > > Guenter, could you please pick this. Applied to hwmon-next (and pushed). Guenter
diff --git a/Documentation/devicetree/bindings/hwmon/lm75.txt b/Documentation/devicetree/bindings/hwmon/lm75.txt new file mode 100644 index 000000000000..12d8cf7cf592 --- /dev/null +++ b/Documentation/devicetree/bindings/hwmon/lm75.txt @@ -0,0 +1,37 @@ +*LM75 hwmon sensor. + +Required properties: +- compatible: manufacturer and chip name, one of + "adi,adt75", + "dallas,ds1775", + "dallas,ds75", + "dallas,ds7505", + "gmt,g751", + "national,lm75", + "national,lm75a", + "national,lm75b", + "maxim,max6625", + "maxim,max6626", + "maxim,max31725", + "maxim,max31726", + "maxim,mcp980x", + "st,stds75", + "st,stlm75", + "microchip,tcn75", + "ti,tmp100", + "ti,tmp101", + "ti,tmp105", + "ti,tmp112", + "ti,tmp175", + "ti,tmp275", + "ti,tmp75", + "ti,tmp75c", + +- reg: I2C bus address of the device + +Example: + +sensor@48 { + compatible = "st,stlm75"; + reg = <0x48>; +};
Add missing dt-binding documentation for lm75 hwmon sensor. Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- Changes for v2: - Add all compatible nodes available in lm75. .../devicetree/bindings/hwmon/lm75.txt | 37 +++++++++++++++++++ 1 file changed, 37 insertions(+) create mode 100644 Documentation/devicetree/bindings/hwmon/lm75.txt