From patchwork Tue Feb 12 04:57:16 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 1040374 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="ADreUs8a"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43z9Zh0z7jz9s4Z for ; Tue, 12 Feb 2019 16:05:16 +1100 (AEDT) Received: from localhost ([127.0.0.1]:33176 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtQFu-0007fv-3e for incoming@patchwork.ozlabs.org; Tue, 12 Feb 2019 00:05:14 -0500 Received: from eggs.gnu.org ([209.51.188.92]:49648) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtQ8y-0002fG-7w for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:58:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtQ8m-0001qO-He for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:57:56 -0500 Received: from mail-pg1-x52c.google.com ([2607:f8b0:4864:20::52c]:35262) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtQ8m-0001jw-0s for qemu-devel@nongnu.org; Mon, 11 Feb 2019 23:57:52 -0500 Received: by mail-pg1-x52c.google.com with SMTP id s198so676411pgs.2 for ; Mon, 11 Feb 2019 20:57:48 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=SIbuKGylEpqtx4B78a3bMTBI3jNfuru9iF5mRgPNCxY=; b=ADreUs8a43a5UTFd+nCnbEVvRp5yVX7AJ6JTxnO4S2Gd/y3XAKpRriw3fp4+uKq6PX ksiZOfhsGiq9+dqV15i7CsuF1mKVnOcLGgOOZBZcPwotmmptB0/uSitqRpI49QymuCO1 kqyA/8mzxvMXaOMLJJe/jf728HrHLwMOhBbDTCC38S56aM/q3bx7UiWhm0i7j9bgZCvt BaBmBir1gqncOT8Au6aB9C3s2E725nfUoFhqcFoB0yCc5ApiXpX8NsyiNLWyfGg3ANWs OamviJaxCxeNGihQ8Jyf2eFaivFK8NLy7aokzMp4764tfYm2+7ubjgEmiM7REm31LIR5 y+5A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=SIbuKGylEpqtx4B78a3bMTBI3jNfuru9iF5mRgPNCxY=; b=nYv2Y0Uev03FrlE4hPU5mHDQGSQbryxXHJqCzTzq8Pv+kOvNN18SprxFrveKqWfyFt VwqfZdBvKegRso82681kVwOC5AAv8ider1wxi8ObM8LVRCOLrdIO2x5Z+QI/SAv/8AZO oAYFk38OI7p2FgKeEawOx0k+3/SW6AfMElKiXRWYAUKMnr4QnPtrHaUrwSB9mA5PTAwn qE+gqDOBd+xT0FYpH53pLHhR9to2ZGupBqLrY7SIxmC6Q8G4AV06tztaUicJug8EWEZQ toE2Qd5wYmu5UO+xGZFLjmyBjG7NeTaQtBmBXBgGHmtethuWSzFHeVpH2wCSFGpTN8i8 bF8g== X-Gm-Message-State: AHQUAuaqfnS1bsxUbrwbC5/OJcowxtPgzeC3o5RAAWPJDkN8JeIvq6AJ H0aXCUaWFDl4v9OCd2cjqbjEE/7hGUI= X-Google-Smtp-Source: AHgI3IY7mPImJKffmDhMKnaJY+7K8QrlAiDcZqD55ft/kJfQjYklggIZzS+yT2DW9pc0t5rtXOBs8w== X-Received: by 2002:a63:3206:: with SMTP id y6mr1891812pgy.338.1549947467105; Mon, 11 Feb 2019 20:57:47 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id a90sm22088923pfj.109.2019.02.11.20.57.46 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 20:57:46 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 11 Feb 2019 20:57:16 -0800 Message-Id: <20190212045721.28041-20-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190212045721.28041-1-richard.henderson@linaro.org> References: <20190212045721.28041-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::52c Subject: [Qemu-devel] [PULL 19/24] target/hppa: Merge translate_one into hppa_tr_translate_insn X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Now that the implementation is entirely within the generated decode function, eliminate the wrapper. Tested-by: Helge Deller Tested-by: Sven Schnelle Signed-off-by: Richard Henderson --- target/hppa/translate.c | 11 +++-------- 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/target/hppa/translate.c b/target/hppa/translate.c index ecec5c42d1..6836fb6245 100644 --- a/target/hppa/translate.c +++ b/target/hppa/translate.c @@ -3982,13 +3982,6 @@ static bool trans_fmpyfadd_d(DisasContext *ctx, arg_fmpyfadd_d *a) return nullify_end(ctx); } -static void translate_one(DisasContext *ctx, uint32_t insn) -{ - if (!decode(ctx, insn)) { - gen_illegal(ctx); - } -} - static void hppa_tr_init_disas_context(DisasContextBase *dcbase, CPUState *cs) { DisasContext *ctx = container_of(dcbase, DisasContext, base); @@ -4094,7 +4087,9 @@ static void hppa_tr_translate_insn(DisasContextBase *dcbase, CPUState *cs) ret = DISAS_NEXT; } else { ctx->insn = insn; - translate_one(ctx, insn); + if (!decode(ctx, insn)) { + gen_illegal(ctx); + } ret = ctx->base.is_jmp; assert(ctx->null_lab == NULL); }