From patchwork Mon Feb 11 23:52:43 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Richard Henderson X-Patchwork-Id: 1040265 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=nongnu.org (client-ip=209.51.188.17; helo=lists.gnu.org; envelope-from=qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=linaro.org Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=linaro.org header.i=@linaro.org header.b="NJr08u+t"; dkim-atps=neutral Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43z2wH5stmz9s7h for ; Tue, 12 Feb 2019 11:05:03 +1100 (AEDT) Received: from localhost ([127.0.0.1]:58305 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtLZN-0005YL-Ig for incoming@patchwork.ozlabs.org; Mon, 11 Feb 2019 19:05:01 -0500 Received: from eggs.gnu.org ([209.51.188.92]:38521) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1gtLOf-0005or-9X for qemu-devel@nongnu.org; Mon, 11 Feb 2019 18:53:58 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1gtLOe-0004xQ-6A for qemu-devel@nongnu.org; Mon, 11 Feb 2019 18:53:57 -0500 Received: from mail-pl1-x631.google.com ([2607:f8b0:4864:20::631]:33569) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1gtLOb-0004SF-5T for qemu-devel@nongnu.org; Mon, 11 Feb 2019 18:53:54 -0500 Received: by mail-pl1-x631.google.com with SMTP id y10so347039plp.0 for ; Mon, 11 Feb 2019 15:53:19 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references; bh=DNVFOwsoNzgnKbR7Mnu9AKsd+9PuR6uwgzj4ngGGq+U=; b=NJr08u+toyNHXxsde+rUj/T7JyiZ9z5OYzle+qHhclO/uQiMJ9gBKI5cDgjQppwbab Zj0kH2BZE6H8ALg9AwxOpd67XK9HgCFlar5ZCAi9HKFJtggmHQ6WrbsBjPWo1r5xROwC O+t2Hjhe+CgYT9U5Jdplj20lRzUj6eQ+Z7gzYA/GB2PstfbO4fW4vRnwqwc5nqPO6TAj cXV7JjF5iG91I+l8920yrk9tzJFDc9hn5IkDP8/HXfK0q5TxkuPKJTeE4OnPMYnm99B8 pf3CjaFua+8VBTVlDhQ3L70Us+1MaSHmReizKyufJTDeZEpyWvL5E0cP8jbNwveRHbtC JLwA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references; bh=DNVFOwsoNzgnKbR7Mnu9AKsd+9PuR6uwgzj4ngGGq+U=; b=V1RscCzl2UysXyPTEsevsOseJIqCo+zJmIhNtcwzRby3OzVj2oTsnPgSpC5ukcO7QK Db9tBRRa+uTz50n42Hhv2vXMJdp3NLjLWQ3EWM5FHZNr/wDWO3DtdQNTZDvwDVZBLZok azEGymFCSvP5Cq1oXdWaS5LMvgLQNlmixl3A+fJ3sFhJ1cvZTsQ7dvFk76V+Dy62e6fs dUV30LV4fzrJGy1eDvT1OAqiw3/O79Opii5D26Wk3pIEea9cetL2D8ia19usVbcR0j2d ZXaYCvAmKxVIt5SvUVeeNMrZnaAxeqsv05o0VPUKSinMEoDcwF5AqCjtHHKkvbI3grop 88iA== X-Gm-Message-State: AHQUAuZ9l67utDeHbPwsuB6rmIXAPVKXsZyJVuZMvu4yah3IqyLuJ5qQ /M5BNBXae6Pr2ufQshmLxBNwDPA6TI0= X-Google-Smtp-Source: AHgI3IZzYJquD6w6ZiC/P3t1u2es73okL3Zzdzs6FUbrwp+BZonAdl+YRccdl7Y6c+rRun6y6RwMCg== X-Received: by 2002:a17:902:8d8d:: with SMTP id v13mr893143plo.121.1549929198356; Mon, 11 Feb 2019 15:53:18 -0800 (PST) Received: from cloudburst.twiddle.net (97-113-188-82.tukw.qwest.net. [97.113.188.82]) by smtp.gmail.com with ESMTPSA id c4sm11861031pgq.85.2019.02.11.15.53.17 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Mon, 11 Feb 2019 15:53:17 -0800 (PST) From: Richard Henderson To: qemu-devel@nongnu.org Date: Mon, 11 Feb 2019 15:52:43 -0800 Message-Id: <20190211235258.542-14-richard.henderson@linaro.org> X-Mailer: git-send-email 2.17.2 In-Reply-To: <20190211235258.542-1-richard.henderson@linaro.org> References: <20190211235258.542-1-richard.henderson@linaro.org> X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2607:f8b0:4864:20::631 Subject: [Qemu-devel] [PATCH v3 13/28] target/arm: Implement the SUBP instruction X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: "Qemu-devel" Reviewed-by: Peter Maydell Signed-off-by: Richard Henderson --- v2: Fix extraction length. --- target/arm/translate-a64.c | 24 ++++++++++++++++++++++-- 1 file changed, 22 insertions(+), 2 deletions(-) diff --git a/target/arm/translate-a64.c b/target/arm/translate-a64.c index 791bcc3b66..2339556320 100644 --- a/target/arm/translate-a64.c +++ b/target/arm/translate-a64.c @@ -5139,19 +5139,39 @@ static void handle_crc32(DisasContext *s, */ static void disas_data_proc_2src(DisasContext *s, uint32_t insn) { - unsigned int sf, rm, opcode, rn, rd; + unsigned int sf, rm, opcode, rn, rd, setflag; sf = extract32(insn, 31, 1); + setflag = extract32(insn, 29, 1); rm = extract32(insn, 16, 5); opcode = extract32(insn, 10, 6); rn = extract32(insn, 5, 5); rd = extract32(insn, 0, 5); - if (extract32(insn, 29, 1)) { + if (setflag && opcode != 0) { unallocated_encoding(s); return; } switch (opcode) { + case 0: /* SUBP(S) */ + if (sf == 0 || !dc_isar_feature(aa64_mte_insn_reg, s)) { + goto do_unallocated; + } else { + TCGv_i64 tcg_n, tcg_m, tcg_d; + + tcg_n = read_cpu_reg_sp(s, rn, true); + tcg_m = read_cpu_reg_sp(s, rm, true); + tcg_gen_sextract_i64(tcg_n, tcg_n, 0, 56); + tcg_gen_sextract_i64(tcg_m, tcg_m, 0, 56); + tcg_d = cpu_reg(s, rd); + + if (setflag) { + gen_sub_CC(true, tcg_d, tcg_n, tcg_m); + } else { + tcg_gen_sub_i64(tcg_d, tcg_n, tcg_m); + } + } + break; case 2: /* UDIV */ handle_div(s, false, sf, rm, rn, rd); break;