[01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values
diff mbox series

Message ID 20190211141333.28725-1-u.kleine-koenig@pengutronix.de
State New
Headers show
Series
  • [01/15] ARM: dts: imx6qdl-fdi-fs700-m60: Use explicit swpad values
Related show

Commit Message

Uwe Kleine-König Feb. 11, 2019, 2:13 p.m. UTC
Instead of relying on reset defaults or a bootloader to configure
use explicit values for the swpad configuration. Here the reset
defaults are used owing to lack of other evidence.

Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
 arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi | 10 +++++-----
 1 file changed, 5 insertions(+), 5 deletions(-)

Comments

Shawn Guo Feb. 28, 2019, 2:47 a.m. UTC | #1
On Mon, Feb 11, 2019 at 03:13:19PM +0100, Uwe Kleine-König wrote:
> Instead of relying on reset defaults or a bootloader to configure
> use explicit values for the swpad configuration. Here the reset
> defaults are used owing to lack of other evidence.

As there is a pretty good chance that kernel works only because of the
configuration set up by bootloader, we are likely going to break things.
So I'm happy to take the patches only with board maintainers' ACK.

Shawn

> 
> Signed-off-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
>  arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi | 10 +++++-----
>  1 file changed, 5 insertions(+), 5 deletions(-)
> 
> diff --git a/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi b/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
> index ebe7a8bddf04..208f94be1296 100644
> --- a/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
> +++ b/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
> @@ -58,9 +58,9 @@
>  	imx6qdl-dfi-fs700-m60 {
>  		pinctrl_hog: hoggrp {
>  			fsl,pins = <
> -				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
> -				MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x80000000 /* PMIC irq */
> -				MX6QDL_PAD_EIM_D26__GPIO3_IO26 0x80000000 /* MAX11801 irq */
> +				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x0001b0b0
> +				MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x0001b0b0 /* PMIC irq */
> +				MX6QDL_PAD_EIM_D26__GPIO3_IO26 0x0001b0b0 /* MAX11801 irq */
>  				MX6QDL_PAD_NANDF_D5__GPIO2_IO05 0x000030b0 /* Backlight enable */
>  			>;
>  		};
> @@ -114,7 +114,7 @@
>  				MX6QDL_PAD_SD2_DAT1__SD2_DATA1		0x17059
>  				MX6QDL_PAD_SD2_DAT2__SD2_DATA2		0x17059
>  				MX6QDL_PAD_SD2_DAT3__SD2_DATA3		0x17059
> -				MX6QDL_PAD_NANDF_D2__GPIO2_IO02 0x80000000 /* card detect */
> +				MX6QDL_PAD_NANDF_D2__GPIO2_IO02 	0x1b0b0 /* card detect */
>  			>;
>  		};
>  
> @@ -149,7 +149,7 @@
>  				MX6QDL_PAD_DISP0_DAT2__ECSPI3_MISO	0x100b1
>  				MX6QDL_PAD_DISP0_DAT1__ECSPI3_MOSI	0x100b1
>  				MX6QDL_PAD_DISP0_DAT0__ECSPI3_SCLK	0x100b1
> -				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
> +				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24	0x1b0b0 /* SPI NOR chipselect */
>  			>;
>  		};
>  	};
> -- 
> 2.20.1
>

Patch
diff mbox series

diff --git a/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi b/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
index ebe7a8bddf04..208f94be1296 100644
--- a/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
+++ b/arch/arm/boot/dts/imx6qdl-dfi-fs700-m60.dtsi
@@ -58,9 +58,9 @@ 
 	imx6qdl-dfi-fs700-m60 {
 		pinctrl_hog: hoggrp {
 			fsl,pins = <
-				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x80000000
-				MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x80000000 /* PMIC irq */
-				MX6QDL_PAD_EIM_D26__GPIO3_IO26 0x80000000 /* MAX11801 irq */
+				MX6QDL_PAD_ENET_CRS_DV__GPIO1_IO25 0x0001b0b0
+				MX6QDL_PAD_GPIO_18__GPIO7_IO13 0x0001b0b0 /* PMIC irq */
+				MX6QDL_PAD_EIM_D26__GPIO3_IO26 0x0001b0b0 /* MAX11801 irq */
 				MX6QDL_PAD_NANDF_D5__GPIO2_IO05 0x000030b0 /* Backlight enable */
 			>;
 		};
@@ -114,7 +114,7 @@ 
 				MX6QDL_PAD_SD2_DAT1__SD2_DATA1		0x17059
 				MX6QDL_PAD_SD2_DAT2__SD2_DATA2		0x17059
 				MX6QDL_PAD_SD2_DAT3__SD2_DATA3		0x17059
-				MX6QDL_PAD_NANDF_D2__GPIO2_IO02 0x80000000 /* card detect */
+				MX6QDL_PAD_NANDF_D2__GPIO2_IO02 	0x1b0b0 /* card detect */
 			>;
 		};
 
@@ -149,7 +149,7 @@ 
 				MX6QDL_PAD_DISP0_DAT2__ECSPI3_MISO	0x100b1
 				MX6QDL_PAD_DISP0_DAT1__ECSPI3_MOSI	0x100b1
 				MX6QDL_PAD_DISP0_DAT0__ECSPI3_SCLK	0x100b1
-				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24 0x80000000 /* SPI NOR chipselect */
+				MX6QDL_PAD_DISP0_DAT3__GPIO4_IO24	0x1b0b0 /* SPI NOR chipselect */
 			>;
 		};
 	};