[1/2] dt-bindings: marvell, mmp2: Add clock id for the LCDC clock

Message ID 20190211102050.24422-1-lkundrak@v3.sk
State Needs Review / ACK
Headers show
Series
  • [1/2] dt-bindings: marvell, mmp2: Add clock id for the LCDC clock
Related show

Checks

Context Check Description
robh/checkpatch warning "total: 0 errors, 1 warnings, 7 lines checked"

Commit Message

Lubomir Rintel Feb. 11, 2019, 10:20 a.m.
The peripheral clock is required for access the the LCDC registers. It
is in fact separate from the "AXI clock" that is optionally used to generate
the pixel clock and as such requires a separate clock id.

Link: https://lists.freedesktop.org/archives/dri-devel/2019-January/203975.html
Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
---
 include/dt-bindings/clock/marvell,mmp2.h | 1 +
 1 file changed, 1 insertion(+)

Comments

Stephen Boyd Feb. 21, 2019, 10:01 p.m. | #1
Quoting Lubomir Rintel (2019-02-11 02:20:49)
> The peripheral clock is required for access the the LCDC registers. It
> is in fact separate from the "AXI clock" that is optionally used to generate
> the pixel clock and as such requires a separate clock id.
> 
> Link: https://lists.freedesktop.org/archives/dri-devel/2019-January/203975.html
> Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> ---

It's a resend? I picked up the other one.
Lubomir Rintel Feb. 22, 2019, 1:56 a.m. | #2
On Thu, 2019-02-21 at 14:01 -0800, Stephen Boyd wrote:
> Quoting Lubomir Rintel (2019-02-11 02:20:49)
> > The peripheral clock is required for access the the LCDC registers. It
> > is in fact separate from the "AXI clock" that is optionally used to generate
> > the pixel clock and as such requires a separate clock id.
> > 
> > Link: https://lists.freedesktop.org/archives/dri-devel/2019-January/203975.html
> > Signed-off-by: Lubomir Rintel <lkundrak@v3.sk>
> > ---
> 
> It's a resend? I picked up the other one.

It is. Sorry for not marking it as such -- I forgot I already sent it.
The patches are indeed the same.

Thanks for picking it up.

Lubo

Patch

diff --git a/include/dt-bindings/clock/marvell,mmp2.h b/include/dt-bindings/clock/marvell,mmp2.h
index 228a5e234af0..e785c6eb3561 100644
--- a/include/dt-bindings/clock/marvell,mmp2.h
+++ b/include/dt-bindings/clock/marvell,mmp2.h
@@ -71,6 +71,7 @@ 
 #define MMP2_CLK_CCIC1_MIX		117
 #define MMP2_CLK_CCIC1_PHY		118
 #define MMP2_CLK_CCIC1_SPHY		119
+#define MMP2_CLK_DISP0_LCDC		120
 
 #define MMP2_NR_CLKS			200
 #endif