Patchwork [1/3] benet: Add missing comma between constant string array

login
register
mail settings
Submitter Joe Perches
Date July 9, 2011, 6:20 a.m.
Message ID <8c2d9b2ff796489a39408fade30fc93ed6040b3c.1310187270.git.joe@perches.com>
Download mbox | patch
Permalink /patch/103958/
State Accepted
Delegated to: David Miller
Headers show

Comments

Joe Perches - July 9, 2011, 6:20 a.m.
Multiple quoted strings are concatenated without comma separators.

Make the arrays const while there.

Signed-off-by: Joe Perches <joe@perches.com>
---
 drivers/net/benet/be_main.c |    6 +++---
 1 files changed, 3 insertions(+), 3 deletions(-)
David Miller - July 9, 2011, 9:57 a.m.
From: Joe Perches <joe@perches.com>
Date: Fri,  8 Jul 2011 23:20:23 -0700

> Multiple quoted strings are concatenated without comma separators.
> 
> Make the arrays const while there.
> 
> Signed-off-by: Joe Perches <joe@perches.com>

Applied, thanks Joe.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

diff --git a/drivers/net/benet/be_main.c b/drivers/net/benet/be_main.c
index 696f634..4ebd700 100644
--- a/drivers/net/benet/be_main.c
+++ b/drivers/net/benet/be_main.c
@@ -44,7 +44,7 @@  static DEFINE_PCI_DEVICE_TABLE(be_dev_ids) = {
 };
 MODULE_DEVICE_TABLE(pci, be_dev_ids);
 /* UE Status Low CSR */
-static char *ue_status_low_desc[] = {
+static const char * const ue_status_low_desc[] = {
 	"CEV",
 	"CTX",
 	"DBUF",
@@ -79,7 +79,7 @@  static char *ue_status_low_desc[] = {
 	"MPU_INTPEND"
 };
 /* UE Status High CSR */
-static char *ue_status_hi_desc[] = {
+static const char * const ue_status_hi_desc[] = {
 	"LPCMEMHOST",
 	"MGMT_MAC",
 	"PCS0ONLINE",
@@ -103,7 +103,7 @@  static char *ue_status_hi_desc[] = {
 	"HOST7",
 	"HOST8",
 	"HOST9",
-	"NETC"
+	"NETC",
 	"Unknown",
 	"Unknown",
 	"Unknown",