[U-Boot,09/10] spi: kconfig: Enable SUN4I_SPI by default if ARCH_SUNXI

Message ID 20190209131500.29954-10-jagan@amarulasolutions.com
State Changes Requested
Delegated to: Jagannadha Sutradharudu Teki
Headers show
Series
  • spi: Add Allwinner A31 SPI driver
Related show

Commit Message

Jagan Teki Feb. 9, 2019, 1:14 p.m.
Enable SUN4I_SPI by default for ARCH_SUNXI, so that board
that would require to enable DM_SPI that eventually enable
the SUN4I_SPI driver.

Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
---
 drivers/spi/Kconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

André Przywara Feb. 13, 2019, 1:21 a.m. | #1
On 09/02/2019 13:14, Jagan Teki wrote:
> Enable SUN4I_SPI by default for ARCH_SUNXI, so that board
> that would require to enable DM_SPI that eventually enable
> the SUN4I_SPI driver.
> 
> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com>
> ---
>  drivers/spi/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
> index 15207d23c1..2fb4862c4a 100644
> --- a/drivers/spi/Kconfig
> +++ b/drivers/spi/Kconfig
> @@ -224,6 +224,7 @@ config STM32_QSPI
>  
>  config SUN4I_SPI
>  	bool "Allwinner A10/A31 SoCs SPI controller"
> +	default ARCH_SUNXI

I don't think that's justified, only a few boards have SPI flash,
really, also it's a new driver that nobody desperately needed so far.

What about:
	default y if ARCH_SUNXI && SPI

That would mean to just define CONFIG_SPI=y in a defconfig to enable SPI
(flash) support for a board.
Similar we should add
	select DM_SPI if SPI
	select DM_SPI_FLASH if SPI
to the ARCH_SUNXI stanza in arch/arm/Kconfig

Cheers,
Andre.


>  	help
>  	  This enables using the SPI controller on the Allwinner A10/A31 SoCs.
>  
>

Patch

diff --git a/drivers/spi/Kconfig b/drivers/spi/Kconfig
index 15207d23c1..2fb4862c4a 100644
--- a/drivers/spi/Kconfig
+++ b/drivers/spi/Kconfig
@@ -224,6 +224,7 @@  config STM32_QSPI
 
 config SUN4I_SPI
 	bool "Allwinner A10/A31 SoCs SPI controller"
+	default ARCH_SUNXI
 	help
 	  This enables using the SPI controller on the Allwinner A10/A31 SoCs.