| Message ID | 20190209121543.25946-2-jagan@amarulasolutions.com |
|---|---|
| State | Accepted |
| Commit | 989fd97fe56676dd636803c467834c36a86d06a5 |
| Delegated to: | Jagannadha Sutradharudu Teki |
| Headers | show |
| Series | [U-Boot,1/3] spi: Kconfig: Mark CONFIG_SPI as Legacy spi support | expand |
Hi, On 09/02/19 5:45 PM, Jagan Teki wrote: > 1) CONFIG_SPI_FLASH is not just a legacy code, but it has common > core code which handle both dm and non-dm spi flash code. So > fix the info text to make it clear globally. > > 2) Since it's flash core it shouldn't depends on legacy SPI, > so remove the 'depends on SPI' > > Cc: Vignesh R <vigneshr@ti.com> > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > --- > drivers/mtd/spi/Kconfig | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > > diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig > index e3b40fc157..605f60c713 100644 > --- a/drivers/mtd/spi/Kconfig > +++ b/drivers/mtd/spi/Kconfig > @@ -26,11 +26,10 @@ config SPI_FLASH_SANDBOX > stored in a file on the host filesystem. > > config SPI_FLASH > - bool "Legacy SPI Flash Interface support" > - depends on SPI > + bool "SPI Flash Core Interface support" Nit, since we have SPI NAND flash as well, should description be updated to say SPI NOR Flash instead of SPI Flash? > select SPI_MEM > help > - Enable the legacy SPI flash support. This will include basic > + Enable the SPI flash Core support. This will include basic > standard support for things like probing, read / write, and > erasing through cmd_sf interface. > >
On Tue, Feb 12, 2019 at 1:31 PM Vignesh R <vigneshr@ti.com> wrote: > > Hi, > > On 09/02/19 5:45 PM, Jagan Teki wrote: > > 1) CONFIG_SPI_FLASH is not just a legacy code, but it has common > > core code which handle both dm and non-dm spi flash code. So > > fix the info text to make it clear globally. > > > > 2) Since it's flash core it shouldn't depends on legacy SPI, > > so remove the 'depends on SPI' > > > > Cc: Vignesh R <vigneshr@ti.com> > > Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> > > --- > > drivers/mtd/spi/Kconfig | 5 ++--- > > 1 file changed, 2 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig > > index e3b40fc157..605f60c713 100644 > > --- a/drivers/mtd/spi/Kconfig > > +++ b/drivers/mtd/spi/Kconfig > > @@ -26,11 +26,10 @@ config SPI_FLASH_SANDBOX > > stored in a file on the host filesystem. > > > > config SPI_FLASH > > - bool "Legacy SPI Flash Interface support" > > - depends on SPI > > + bool "SPI Flash Core Interface support" > > Nit, since we have SPI NAND flash as well, should description be updated > to say SPI NOR Flash instead of SPI Flash? True, I have bundle of changes even for configs to rename till those are in lets go with as we are.
diff --git a/drivers/mtd/spi/Kconfig b/drivers/mtd/spi/Kconfig index e3b40fc157..605f60c713 100644 --- a/drivers/mtd/spi/Kconfig +++ b/drivers/mtd/spi/Kconfig @@ -26,11 +26,10 @@ config SPI_FLASH_SANDBOX stored in a file on the host filesystem. config SPI_FLASH - bool "Legacy SPI Flash Interface support" - depends on SPI + bool "SPI Flash Core Interface support" select SPI_MEM help - Enable the legacy SPI flash support. This will include basic + Enable the SPI flash Core support. This will include basic standard support for things like probing, read / write, and erasing through cmd_sf interface.
1) CONFIG_SPI_FLASH is not just a legacy code, but it has common core code which handle both dm and non-dm spi flash code. So fix the info text to make it clear globally. 2) Since it's flash core it shouldn't depends on legacy SPI, so remove the 'depends on SPI' Cc: Vignesh R <vigneshr@ti.com> Signed-off-by: Jagan Teki <jagan@amarulasolutions.com> --- drivers/mtd/spi/Kconfig | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-)