From patchwork Fri Feb 8 19:21:24 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Heiner Kallweit X-Patchwork-Id: 1038934 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming-netdev@ozlabs.org Delivered-To: patchwork-incoming-netdev@ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=netdev-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="jJDQFqLN"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43x4np6Xqyz9sLw for ; Sat, 9 Feb 2019 06:22:38 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727679AbfBHTWh (ORCPT ); Fri, 8 Feb 2019 14:22:37 -0500 Received: from mail-wm1-f67.google.com ([209.85.128.67]:50950 "EHLO mail-wm1-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727138AbfBHTWg (ORCPT ); Fri, 8 Feb 2019 14:22:36 -0500 Received: by mail-wm1-f67.google.com with SMTP id z5so5029780wmf.0 for ; Fri, 08 Feb 2019 11:22:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=+Bzb/eGIZ5PR3g2QzDGWDENwp77a80H1mP8eAHXac+0=; b=jJDQFqLNwpJqyHouQ0hWKl9CB8vTIoIy20HPtDwDERbfwJ7bR7F44vNUVPIrw5WC7k rLTpXi/2q2h9cxz1VAYfxSXHjqzliFvUNu8EZq2Jqd/3LRYfKHaFfl2KW/kiLXYQ7cY7 tIfpHNPZlBtCLzX4GXhZ8LZJ4/ww7vR/lLTMeXo+8yCQczUw0aeJYperg4yxD2kQBixq COVqrPuJE6bD+UOTruT8nbPNCHlPR7PVEmAVyyQocXoEs2iOoJmWoiAldsbsl1UvQMxD t18qZEdundIWW8pN8EQdjE0Dv21W5nmvPfd18bUtFJzpNMeWT2s7OAcgZwWo8rrNyJhj 88MA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=+Bzb/eGIZ5PR3g2QzDGWDENwp77a80H1mP8eAHXac+0=; b=gEi45vk3+hbUW1wogWelwPSNzHUa0F0jm/XefQM+V5bfWE0j74k0CQbfyr6/1tV2wr wICM6zbojr2K28jNHE9uZgjn3CLp7wTkwNW1LccN/rb3g11ddMqbj594MZmZwnG0XPAl P2yJv6NOzYGCbd9D5XArORSa+UBXQYEiVebpWbg0r/TwPNu2YY1ktKd4we8SZtJDg6JT 4+Db78y/LBZoyMJ3livhYVhY82LZHwz9XPWYJS3mcwArSQB5gRPwBPhf/O+5zIqBh9Ak MWVFdspHIcAGzQPkHgYxHuNVtGAnDcDrcEXTNCZJAwVeFYKRYQ5uQyu8CHsCTEi924Qh v+Wg== X-Gm-Message-State: AHQUAuZrrsi7ak8QrRlKNLGo547RsHseBEd4a5Qr7v3/GDHgoy7cFpFx QZdspBYmV5b0MNPdXl8U0/fpBx3F X-Google-Smtp-Source: AHgI3IZf1SkD44s5xFlyKJt3plOeGh7XqQHtSfoppdwubPN/8Ec7E3D94rdbetCZin4lTEoS8bO4yw== X-Received: by 2002:a1c:2088:: with SMTP id g130mr69386wmg.122.1549653754904; Fri, 08 Feb 2019 11:22:34 -0800 (PST) Received: from ?IPv6:2003:ea:8bf1:e200:7cef:f5e9:d82c:bb62? (p200300EA8BF1E2007CEFF5E9D82CBB62.dip0.t-ipconnect.de. [2003:ea:8bf1:e200:7cef:f5e9:d82c:bb62]) by smtp.googlemail.com with ESMTPSA id x186sm4410432wmg.41.2019.02.08.11.22.33 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 08 Feb 2019 11:22:34 -0800 (PST) Subject: [PATCH v3 2/3 net-next] net: phy: disregard "Clause 22 registers present" bit in get_phy_c45_devs_in_pkg From: Heiner Kallweit To: Andrew Lunn , Florian Fainelli , David Miller Cc: "netdev@vger.kernel.org" References: <75c9d8ee-582f-f247-7595-d8732ac26c20@gmail.com> Message-ID: Date: Fri, 8 Feb 2019 20:21:24 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.5.0 MIME-Version: 1.0 In-Reply-To: <75c9d8ee-582f-f247-7595-d8732ac26c20@gmail.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Bit 0 in register 1.5 doesn't represent a device but is a flag that Clause 22 registers are present. Therefore disregard this bit when populating the device list. If code needs this information it should read register 1.5 directly instead of accessing the device list. Signed-off-by: Heiner Kallweit Reviewed-by: Andrew Lunn --- drivers/net/phy/phy_device.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/net/phy/phy_device.c b/drivers/net/phy/phy_device.c index 82dd72954..31f9e7c49 100644 --- a/drivers/net/phy/phy_device.c +++ b/drivers/net/phy/phy_device.c @@ -684,6 +684,9 @@ static int get_phy_c45_devs_in_pkg(struct mii_bus *bus, int addr, int dev_addr, return -EIO; *devices_in_package |= phy_reg; + /* Bit 0 doesn't represent a device, it indicates c22 regs presence */ + *devices_in_package &= ~BIT(0); + return 0; }