| Message ID | 20190208181210.GA8388@embeddedor |
|---|---|
| State | Accepted |
| Headers | show |
| Series | mtd: lpddr_cmds: Mark expected switch fall-through | expand |
Hi all, Friendly ping: Who can take this? Thanks -- Gustavo On 2/8/19 12:12 PM, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’: > drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (mode == FL_READY && chip->oldstate == FL_READY) > ^ > drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here > default: > ^~~~~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> > --- > drivers/mtd/lpddr/lpddr_cmds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c > index b13557fe52bd..76a4c73e100e 100644 > --- a/drivers/mtd/lpddr/lpddr_cmds.c > +++ b/drivers/mtd/lpddr/lpddr_cmds.c > @@ -318,6 +318,7 @@ static int chip_ready(struct map_info *map, struct flchip *chip, int mode) > /* Only if there's no operation suspended... */ > if (mode == FL_READY && chip->oldstate == FL_READY) > return 0; > + /* fall through */ > > default: > sleep: >
Hi all, If no one cares I'll add this to my tree for 5.2. Thanks -- Gustavo On 3/20/19 3:17 PM, Gustavo A. R. Silva wrote: > Hi all, > > Friendly ping: > > Who can take this? > > Thanks > -- > Gustavo > > On 2/8/19 12:12 PM, Gustavo A. R. Silva wrote: >> In preparation to enabling -Wimplicit-fallthrough, mark switch >> cases where we are expecting to fall through. >> >> This patch fixes the following warnings: >> >> drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’: >> drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=] >> if (mode == FL_READY && chip->oldstate == FL_READY) >> ^ >> drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here >> default: >> ^~~~~~~ >> >> Warning level 3 was used: -Wimplicit-fallthrough=3 >> >> This patch is part of the ongoing efforts to enabling >> -Wimplicit-fallthrough. >> >> Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> >> --- >> drivers/mtd/lpddr/lpddr_cmds.c | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c >> index b13557fe52bd..76a4c73e100e 100644 >> --- a/drivers/mtd/lpddr/lpddr_cmds.c >> +++ b/drivers/mtd/lpddr/lpddr_cmds.c >> @@ -318,6 +318,7 @@ static int chip_ready(struct map_info *map, struct flchip *chip, int mode) >> /* Only if there's no operation suspended... */ >> if (mode == FL_READY && chip->oldstate == FL_READY) >> return 0; >> + /* fall through */ >> >> default: >> sleep: >>
On Fri, Feb 8, 2019 at 10:12 AM Gustavo A. R. Silva <gustavo@embeddedor.com> wrote: > > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’: > drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=] > if (mode == FL_READY && chip->oldstate == FL_READY) > ^ > drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here > default: > ^~~~~~~ > > Warning level 3 was used: -Wimplicit-fallthrough=3 > > This patch is part of the ongoing efforts to enabling > -Wimplicit-fallthrough. > > Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> Reviewed-by: Kees Cook <keescook@chromium.org> -Kees > --- > drivers/mtd/lpddr/lpddr_cmds.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c > index b13557fe52bd..76a4c73e100e 100644 > --- a/drivers/mtd/lpddr/lpddr_cmds.c > +++ b/drivers/mtd/lpddr/lpddr_cmds.c > @@ -318,6 +318,7 @@ static int chip_ready(struct map_info *map, struct flchip *chip, int mode) > /* Only if there's no operation suspended... */ > if (mode == FL_READY && chip->oldstate == FL_READY) > return 0; > + /* fall through */ > > default: > sleep: > -- > 2.20.1 >
diff --git a/drivers/mtd/lpddr/lpddr_cmds.c b/drivers/mtd/lpddr/lpddr_cmds.c index b13557fe52bd..76a4c73e100e 100644 --- a/drivers/mtd/lpddr/lpddr_cmds.c +++ b/drivers/mtd/lpddr/lpddr_cmds.c @@ -318,6 +318,7 @@ static int chip_ready(struct map_info *map, struct flchip *chip, int mode) /* Only if there's no operation suspended... */ if (mode == FL_READY && chip->oldstate == FL_READY) return 0; + /* fall through */ default: sleep:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. This patch fixes the following warnings: drivers/mtd/lpddr/lpddr_cmds.c: In function ‘chip_ready’: drivers/mtd/lpddr/lpddr_cmds.c:319:6: warning: this statement may fall through [-Wimplicit-fallthrough=] if (mode == FL_READY && chip->oldstate == FL_READY) ^ drivers/mtd/lpddr/lpddr_cmds.c:322:2: note: here default: ^~~~~~~ Warning level 3 was used: -Wimplicit-fallthrough=3 This patch is part of the ongoing efforts to enabling -Wimplicit-fallthrough. Signed-off-by: Gustavo A. R. Silva <gustavo@embeddedor.com> --- drivers/mtd/lpddr/lpddr_cmds.c | 1 + 1 file changed, 1 insertion(+)