Message ID  87k1iajiep.fsf@oldenburg2.str.redhat.com 

State  New 
Headers  show 
Series 

Related  show 
On Fri, 8 Feb 2019, Florian Weimer wrote: > Joseph, > > I think the patch below is needed. Is this how things are supposed to > be done? The existing practice is to use toplevel bits/ instead of sysdeps/generic/bits/ (see <https://sourceware.org/ml/libcalpha/201605/msg00189.html>). Moving to toplevel bits/ would seem correct for this header (for now, anyway, modulo any future integration of mathfinite.h into mathcalls.h to fix bug 23292).
* Joseph Myers: > On Fri, 8 Feb 2019, Florian Weimer wrote: > >> Joseph, >> >> I think the patch below is needed. Is this how things are supposed to >> be done? > > The existing practice is to use toplevel bits/ instead of > sysdeps/generic/bits/ (see > <https://sourceware.org/ml/libcalpha/201605/msg00189.html>). Moving to > toplevel bits/ would seem correct for this header (for now, anyway, > modulo any future integration of mathfinite.h into mathcalls.h to fix bug > 23292). Oh, I didn't realize that bits/ would work for this. I assumed I had to create sysdeps/generic/bits to make this work. 8( Should I move the file sysdeps/generic/bits/unistd_ext.h to bits/unistd_ext.h? Do you agree that moving math/bits/mathfinite.h to bits/mathfinite.h is the right thing to do? Thanks, Florian
On Fri, 8 Feb 2019, Florian Weimer wrote: > Oh, I didn't realize that bits/ would work for this. I assumed I had to > create sysdeps/generic/bits to make this work. 8( Should I move the > file sysdeps/generic/bits/unistd_ext.h to bits/unistd_ext.h? Yes. (I'm not sure of the rationale for the past move from sysdeps/generic/bits/ to bits/, but it was definitely a deliberate change establishing the convention that bits/ is the place to use, and I'm not aware of any *problems* with using bits/ for this.) > Do you agree that moving math/bits/mathfinite.h to bits/mathfinite.h > is the right thing to do? Yes.
diff git a/math/bits/mathfinite.h b/sysdeps/generic/bits/mathfinite.h
similarity index 100%
rename from math/bits/mathfinite.h
rename to sysdeps/generic/bits/mathfinite.h