[u-boot] aspeed: flash: Add MT25QL01GB chip

Message ID 1549646915-5300-1-git-send-email-anoo@linux.ibm.com
State Accepted, archived
Headers show
Series
  • [u-boot] aspeed: flash: Add MT25QL01GB chip
Related show

Commit Message

Adriana Kobylak Feb. 8, 2019, 5:28 p.m.
From: Adriana Kobylak <anoo@us.linux.com>

The MT25QL01GB is a 128MB NOR flash chip planned to be used on
a Witherspoon system (AST2500).

Signed-off-by: Adriana Kobylak <anoo@us.linux.com>
---
 arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
 1 file changed, 14 insertions(+)

Comments

Brad Bishop April 3, 2019, 12:36 p.m. | #1
On Fri, Feb 08, 2019 at 11:28:35AM -0600, Adriana Kobylak wrote:
>From: Adriana Kobylak <anoo@us.linux.com>
>
>The MT25QL01GB is a 128MB NOR flash chip planned to be used on
>a Witherspoon system (AST2500).
>
>Signed-off-by: Adriana Kobylak <anoo@us.linux.com>
>---
> arch/arm/mach-aspeed/flash.c | 14 ++++++++++++++
> 1 file changed, 14 insertions(+)
>
>diff --git a/arch/arm/mach-aspeed/flash.c b/arch/arm/mach-aspeed/flash.c
>index 907e785..54a6059 100644
>--- a/arch/arm/mach-aspeed/flash.c
>+++ b/arch/arm/mach-aspeed/flash.c
>@@ -83,6 +83,7 @@ flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS];		/* FLASH chips info */
> #define SST25VF040B		0x8d25bf
> #define AT25DF161		0x02461F
> #define AT25DF321		0x01471F
>+#define MT25QL01GB		0x21ba20
>
> /* SPI Define */
> #define CS0_CTRL			0x10
>@@ -1141,6 +1142,19 @@ static ulong flash_get_size (ulong base, flash_info_t *info)
> 			ReadClk  = 50;
> 			break;
>
>+		case MT25QL01GB:
>+			info->sector_count = 2048;
>+			info->size = 0x8000000;
>+			erase_region_size  = 0x10000;
>+			info->readcmd = 0x0b;
>+			info->dualport = 0;
>+			info->dummybyte = 1;
>+			info->buffersize = 1;
>+			WriteClk = 50;
>+			EraseClk = 25;
>+			ReadClk  = 50;
>+			break;
>+
> 		default:	/* use JEDEC ID */
> 			printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
> 			erase_region_size  = 0x10000;
>-- 
>1.8.3.1

Hi Joel

Would you be willing to carry this u-boot patch and if so, what all
would you like to see from our end to enable that?

thx - Brad
Joel Stanley April 4, 2019, 6:24 a.m. | #2
On Wed, 3 Apr 2019 at 12:35, Brad Bishop <bradleyb@fuzziesquirrel.com> wrote:
>
> On Fri, Feb 08, 2019 at 11:28:35AM -0600, Adriana Kobylak wrote:
> >From: Adriana Kobylak <anoo@us.linux.com>
> >
> >The MT25QL01GB is a 128MB NOR flash chip planned to be used on
> >a Witherspoon system (AST2500).
> >

>
> Would you be willing to carry this u-boot patch and if so, what all
> would you like to see from our end to enable that?

Where does Adriana want it applied? The subject doesn't indicate a branch.

I didn't look at it becuase I assumed it was an upstream patch.
Looking at it now it is obviously meant for the ancient openbmc tree.
I have applied it to v2016.07-aspeed-openbmc.

In the future, adding the correct tags to the subject, and sending
reviewed and tested tags will help me apply your patch.

Cheers,

Joel
Joel Stanley April 4, 2019, 6:30 a.m. | #3
On Thu, 4 Apr 2019 at 06:24, Joel Stanley <joel@jms.id.au> wrote:
>
> On Wed, 3 Apr 2019 at 12:35, Brad Bishop <bradleyb@fuzziesquirrel.com> wrote:
> >
> > On Fri, Feb 08, 2019 at 11:28:35AM -0600, Adriana Kobylak wrote:
> > >From: Adriana Kobylak <anoo@us.linux.com>

Adriana, you need to fix up your email address. Once you've done that
regenerate the patch with --reset-author and make sure the
signed-off-by is correct.

Cheers,

Joel

> > >
> > >The MT25QL01GB is a 128MB NOR flash chip planned to be used on
> > >a Witherspoon system (AST2500).
> > >
>
> >
> > Would you be willing to carry this u-boot patch and if so, what all
> > would you like to see from our end to enable that?
>
> Where does Adriana want it applied? The subject doesn't indicate a branch.
>
> I didn't look at it becuase I assumed it was an upstream patch.
> Looking at it now it is obviously meant for the ancient openbmc tree.
> I have applied it to v2016.07-aspeed-openbmc.
>
> In the future, adding the correct tags to the subject, and sending
> reviewed and tested tags will help me apply your patch.
>
> Cheers,
>
> Joel

Patch

diff --git a/arch/arm/mach-aspeed/flash.c b/arch/arm/mach-aspeed/flash.c
index 907e785..54a6059 100644
--- a/arch/arm/mach-aspeed/flash.c
+++ b/arch/arm/mach-aspeed/flash.c
@@ -83,6 +83,7 @@  flash_info_t flash_info[CONFIG_SYS_MAX_FLASH_BANKS];		/* FLASH chips info */
 #define SST25VF040B		0x8d25bf
 #define AT25DF161		0x02461F
 #define AT25DF321		0x01471F
+#define MT25QL01GB		0x21ba20
 
 /* SPI Define */
 #define CS0_CTRL			0x10
@@ -1141,6 +1142,19 @@  static ulong flash_get_size (ulong base, flash_info_t *info)
 			ReadClk  = 50;
 			break;
 
+		case MT25QL01GB:
+			info->sector_count = 2048;
+			info->size = 0x8000000;
+			erase_region_size  = 0x10000;
+			info->readcmd = 0x0b;
+			info->dualport = 0;
+			info->dummybyte = 1;
+			info->buffersize = 1;
+			WriteClk = 50;
+			EraseClk = 25;
+			ReadClk  = 50;
+			break;
+
 		default:	/* use JEDEC ID */
 			printf("Unsupported SPI Flash!! 0x%08lx\n", info->flash_id);
 			erase_region_size  = 0x10000;