| Message ID | 20190208151419.1800-1-aneesh.kumar@linux.ibm.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [v3,1/2] drivers/mtd: Use mtd->name when registering nvmem device | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 1 warnings, 0 checks, 7 lines checked |
Hello Aneesh, On Fri, 8 Feb 2019 20:44:18 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote: > With this patch, we use the mtd->name instead of concatenating the name with '0' > > Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API") > Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> You forgot to Cc the MTD ML and maintainers. Can you please send a new version? Thanks, Boris > --- > drivers/mtd/mtdcore.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c > index 999b705769a8..3ef01baef9b6 100644 > --- a/drivers/mtd/mtdcore.c > +++ b/drivers/mtd/mtdcore.c > @@ -507,6 +507,7 @@ static int mtd_nvmem_add(struct mtd_info *mtd) > { > struct nvmem_config config = {}; > > + config.id = -1; > config.dev = &mtd->dev; > config.name = mtd->name; > config.owner = THIS_MODULE;
On 2/10/19 6:25 PM, Boris Brezillon wrote: > Hello Aneesh, > > On Fri, 8 Feb 2019 20:44:18 +0530 > "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote: > >> With this patch, we use the mtd->name instead of concatenating the name with '0' >> >> Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API") >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> > > You forgot to Cc the MTD ML and maintainers. Can you please send a new > version? > linux-mtd list is on CC: Is that not sufficient? -aneesh
On Mon, 11 Feb 2019 16:26:38 +0530 "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote: > On 2/10/19 6:25 PM, Boris Brezillon wrote: > > Hello Aneesh, > > > > On Fri, 8 Feb 2019 20:44:18 +0530 > > "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote: > > > >> With this patch, we use the mtd->name instead of concatenating the name with '0' > >> > >> Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API") > >> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> > > > > You forgot to Cc the MTD ML and maintainers. Can you please send a new > > version? > > > > linux-mtd list is on CC: Is that not sufficient? Not in your original email, I added it in my reply.
On 2/11/19 4:46 PM, Boris Brezillon wrote: > On Mon, 11 Feb 2019 16:26:38 +0530 > "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote: > >> On 2/10/19 6:25 PM, Boris Brezillon wrote: >>> Hello Aneesh, >>> >>> On Fri, 8 Feb 2019 20:44:18 +0530 >>> "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com> wrote: >>> >>>> With this patch, we use the mtd->name instead of concatenating the name with '0' >>>> >>>> Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API") >>>> Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> >>> >>> You forgot to Cc the MTD ML and maintainers. Can you please send a new >>> version? >>> >> >> linux-mtd list is on CC: Is that not sufficient? > > Not in your original email, I added it in my reply. > Sorry about that. I will now resend with linux-mtd on CC: I missed that earlier. -aneesh
diff --git a/drivers/mtd/mtdcore.c b/drivers/mtd/mtdcore.c index 999b705769a8..3ef01baef9b6 100644 --- a/drivers/mtd/mtdcore.c +++ b/drivers/mtd/mtdcore.c @@ -507,6 +507,7 @@ static int mtd_nvmem_add(struct mtd_info *mtd) { struct nvmem_config config = {}; + config.id = -1; config.dev = &mtd->dev; config.name = mtd->name; config.owner = THIS_MODULE;
With this patch, we use the mtd->name instead of concatenating the name with '0' Fixes: c4dfa25ab307 ("mtd: add support for reading MTD devices via the nvmem API") Signed-off-by: Aneesh Kumar K.V <aneesh.kumar@linux.ibm.com> --- drivers/mtd/mtdcore.c | 1 + 1 file changed, 1 insertion(+)