From patchwork Fri Feb 8 03:23:06 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Hung X-Patchwork-Id: 1038461 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=fwts-devel-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43wgWG3fgRz9sBZ; Fri, 8 Feb 2019 14:23:38 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1grwlL-0004Sh-RL; Fri, 08 Feb 2019 03:23:35 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1grwlK-0004SA-7l for fwts-devel@lists.ubuntu.com; Fri, 08 Feb 2019 03:23:34 +0000 Received: from 1.general.alexhung.us.vpn ([10.172.65.254] helo=canonical.com) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1grwlJ-0003eb-LD; Fri, 08 Feb 2019 03:23:34 +0000 From: Alex Hung To: fwts-devel@lists.ubuntu.com Subject: [PATCH 06/14] acpi/srat: add test for Generic Initiator (mantis 1904 for ACPI 6.3) Date: Thu, 7 Feb 2019 19:23:06 -0800 Message-Id: <20190208032314.15215-7-alex.hung@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190208032314.15215-1-alex.hung@canonical.com> References: <20190208032314.15215-1-alex.hung@canonical.com> X-BeenThere: fwts-devel@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Firmware Test Suite Development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: fwts-devel-bounces@lists.ubuntu.com Sender: "fwts-devel" Signed-off-by: Alex Hung Acked-by: Colin Ian King --- src/acpi/srat/srat.c | 65 +++++++++++++++++++++++++++++++++++++ src/lib/include/fwts_acpi.h | 11 +++++++ 2 files changed, 76 insertions(+) diff --git a/src/acpi/srat/srat.c b/src/acpi/srat/srat.c index 3c37d9ed..edd97903 100644 --- a/src/acpi/srat/srat.c +++ b/src/acpi/srat/srat.c @@ -307,6 +307,68 @@ done: *data += sizeof(fwts_acpi_table_its_affinity); } + +static void srat_check_initiator_affinity( + fwts_framework *fw, + ssize_t *length, + uint8_t **data, + bool *passed) +{ + fwts_acpi_table_initiator_affinity *affinity = + (fwts_acpi_table_initiator_affinity *)*data; + + if ((ssize_t)sizeof(fwts_acpi_table_initiator_affinity) > *length) { + fwts_failed(fw, LOG_LEVEL_MEDIUM, + "SRATInitiatorAffinityShort", + "SRAT Initiator Affinity structure too short, got " + "%zu bytes, expecting %zu bytes", + *length, sizeof(fwts_acpi_table_initiator_affinity)); + *passed = false; + goto done; + } + + if (affinity->length != sizeof(fwts_acpi_table_initiator_affinity)) { + fwts_failed(fw, LOG_LEVEL_MEDIUM, + "SRATInitiatorAffinityLength", + "SRAT Initiator Affinity Length incorrect, got " + "%" PRIu8 ", expecting %zu", + affinity->length, sizeof(fwts_acpi_table_initiator_affinity)); + *passed = false; + goto done; + } + + fwts_log_info_verbatim(fw, "SRAT Initiator Affinity Structure:"); + fwts_log_info_verbatim(fw, " Type: 0x%2.2" PRIx8, affinity->type); + fwts_log_info_verbatim(fw, " Length: 0x%2.2" PRIx8, affinity->length); + fwts_log_info_verbatim(fw, " Reserved: 0x%2.2" PRIx8, affinity->reserved1); + fwts_log_info_verbatim(fw, " Device Handle Type: 0x%2.2" PRIx8, affinity->device_handle_type); + fwts_log_info_verbatim(fw, " Proximity Domain: 0x%8.8" PRIx32, affinity->proximity_domain); + fwts_log_info_verbatim(fw, " Device Handle:"); + if (affinity->device_handle_type == 0) { + fwts_log_info_verbatim(fw, " ACPI _HID: 0x%16.16" PRIx64, (uint64_t)affinity->device_handle[0]); + fwts_log_info_verbatim(fw, " ACPI _UID: 0x%8.8" PRIx32, (uint32_t)affinity->device_handle[8]); + } else if (affinity->device_handle_type == 1) { + fwts_log_info_verbatim(fw, " PCI Segment: 0x%4.4" PRIx16, (uint16_t)affinity->device_handle[0]); + fwts_log_info_verbatim(fw, " PCI BDF Number: 0x%4.4" PRIx16, (uint16_t)affinity->device_handle[2]); + } + fwts_log_info_verbatim(fw, " Flags: 0x%4.4" PRIx16, affinity->flags); + fwts_log_info_verbatim(fw, " Reserved: 0x%4.4" PRIx16, affinity->reserved2); + fwts_log_nl(fw); + + fwts_acpi_reserved_zero_check(fw, "SRAT", "Initiator Affinity Reserved", affinity->reserved1, sizeof(affinity->reserved1), passed); + fwts_acpi_reserved_bits_check(fw, "SRAT", "Initiator Affinity Device Handle Type", affinity->device_handle_type, sizeof(affinity->device_handle_type), 1, 7, passed); + if (affinity->device_handle_type == 0) + fwts_acpi_reserved_zero_check(fw, "SRAT", "Initiator Affinity Device Handle Reserve", affinity->device_handle[8], sizeof(uint32_t), passed); + else if (affinity->device_handle_type == 1) + fwts_acpi_reserved_zero_check(fw, "SRAT", "Initiator Affinity Device Handle Reserve", affinity->device_handle[4], sizeof(uint64_t), passed); + fwts_acpi_reserved_bits_check(fw, "SRAT", "Initiator Affinity Flags", affinity->flags, sizeof(affinity->flags), 1, 15, passed); + fwts_acpi_reserved_zero_check(fw, "SRAT", "Initiator Affinity Reserved", affinity->reserved2, sizeof(affinity->reserved2), passed); + +done: + *length -= sizeof(fwts_acpi_table_initiator_affinity); + *data += sizeof(fwts_acpi_table_initiator_affinity); +} + /* * See ACPI 6.0, Section 5.2.16 */ @@ -345,6 +407,9 @@ static int srat_test1(fwts_framework *fw) case 0x04: srat_check_its_affinity(fw, &length, &data, &passed); break; + case 0x05: + srat_check_initiator_affinity(fw, &length, &data, &passed); + break; default: fwts_failed(fw, LOG_LEVEL_HIGH, "SRATInvalidType", diff --git a/src/lib/include/fwts_acpi.h b/src/lib/include/fwts_acpi.h index d03f4c4a..5204744d 100644 --- a/src/lib/include/fwts_acpi.h +++ b/src/lib/include/fwts_acpi.h @@ -434,6 +434,17 @@ typedef struct { uint32_t its_id; } __attribute__ ((packed)) fwts_acpi_table_its_affinity; +typedef struct { + uint8_t type; + uint8_t length; + uint8_t reserved1; + uint8_t device_handle_type; + uint32_t proximity_domain; + uint8_t device_handle[16]; + uint32_t flags; + uint32_t reserved2; +} __attribute__ ((packed)) fwts_acpi_table_initiator_affinity; + /* * ACPI HPET (HPET IA-PC High Precision Event Timer Table), * 3.2.4 The ACPI 2.0 HPET Description Table (HPET)