| Message ID | 20190208030802.10805-1-oohall@gmail.com (mailing list archive) |
|---|---|
| State | Changes Requested |
| Headers | show |
| Series | [1/7] powerpc/eeh: Use debugfs_create_u32 for eeh_max_freezes | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/checkpatch | warning | total: 0 errors, 0 warnings, 3 checks, 49 lines checked |
Oliver O'Halloran <oohall@gmail.com> writes: > There's no need to the custom getter/setter functions so we should remove > them in favour of using the generic one. While we're here, change the type > of eeh_max_freeze to uint32_t and print the value in decimal rather than Please use kernel types, ie. u32. Look fine otherwise. cheers > Signed-off-by: Oliver O'Halloran <oohall@gmail.com> > --- > arch/powerpc/include/asm/eeh.h | 2 +- > arch/powerpc/kernel/eeh.c | 21 +++------------------ > 2 files changed, 4 insertions(+), 19 deletions(-) > > diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h > index 8b596d096ebe..c003628441cc 100644 > --- a/arch/powerpc/include/asm/eeh.h > +++ b/arch/powerpc/include/asm/eeh.h > @@ -219,7 +219,7 @@ struct eeh_ops { > }; > > extern int eeh_subsystem_flags; > -extern int eeh_max_freezes; > +extern uint32_t eeh_max_freezes; > extern struct eeh_ops *eeh_ops; > extern raw_spinlock_t confirm_error_lock; > > diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c > index ae05203eb4de..f6e65375a8de 100644 > --- a/arch/powerpc/kernel/eeh.c > +++ b/arch/powerpc/kernel/eeh.c > @@ -109,7 +109,7 @@ EXPORT_SYMBOL(eeh_subsystem_flags); > * frozen count in last hour exceeds this limit, the PE will > * be forced to be offline permanently. > */ > -int eeh_max_freezes = 5; > +uint32_t eeh_max_freezes = 5; > > /* Platform dependent EEH operations */ > struct eeh_ops *eeh_ops = NULL; > @@ -1796,22 +1796,8 @@ static int eeh_enable_dbgfs_get(void *data, u64 *val) > return 0; > } > > -static int eeh_freeze_dbgfs_set(void *data, u64 val) > -{ > - eeh_max_freezes = val; > - return 0; > -} > - > -static int eeh_freeze_dbgfs_get(void *data, u64 *val) > -{ > - *val = eeh_max_freezes; > - return 0; > -} > - > DEFINE_DEBUGFS_ATTRIBUTE(eeh_enable_dbgfs_ops, eeh_enable_dbgfs_get, > eeh_enable_dbgfs_set, "0x%llx\n"); > -DEFINE_DEBUGFS_ATTRIBUTE(eeh_freeze_dbgfs_ops, eeh_freeze_dbgfs_get, > - eeh_freeze_dbgfs_set, "0x%llx\n"); > #endif > > static int __init eeh_init_proc(void) > @@ -1822,9 +1808,8 @@ static int __init eeh_init_proc(void) > debugfs_create_file_unsafe("eeh_enable", 0600, > powerpc_debugfs_root, NULL, > &eeh_enable_dbgfs_ops); > - debugfs_create_file_unsafe("eeh_max_freezes", 0600, > - powerpc_debugfs_root, NULL, > - &eeh_freeze_dbgfs_ops); > + debugfs_create_u32("eeh_max_freezes", 0600, > + powerpc_debugfs_root, &eeh_max_freezes); > #endif > } > > -- > 2.20.1
diff --git a/arch/powerpc/include/asm/eeh.h b/arch/powerpc/include/asm/eeh.h index 8b596d096ebe..c003628441cc 100644 --- a/arch/powerpc/include/asm/eeh.h +++ b/arch/powerpc/include/asm/eeh.h @@ -219,7 +219,7 @@ struct eeh_ops { }; extern int eeh_subsystem_flags; -extern int eeh_max_freezes; +extern uint32_t eeh_max_freezes; extern struct eeh_ops *eeh_ops; extern raw_spinlock_t confirm_error_lock; diff --git a/arch/powerpc/kernel/eeh.c b/arch/powerpc/kernel/eeh.c index ae05203eb4de..f6e65375a8de 100644 --- a/arch/powerpc/kernel/eeh.c +++ b/arch/powerpc/kernel/eeh.c @@ -109,7 +109,7 @@ EXPORT_SYMBOL(eeh_subsystem_flags); * frozen count in last hour exceeds this limit, the PE will * be forced to be offline permanently. */ -int eeh_max_freezes = 5; +uint32_t eeh_max_freezes = 5; /* Platform dependent EEH operations */ struct eeh_ops *eeh_ops = NULL; @@ -1796,22 +1796,8 @@ static int eeh_enable_dbgfs_get(void *data, u64 *val) return 0; } -static int eeh_freeze_dbgfs_set(void *data, u64 val) -{ - eeh_max_freezes = val; - return 0; -} - -static int eeh_freeze_dbgfs_get(void *data, u64 *val) -{ - *val = eeh_max_freezes; - return 0; -} - DEFINE_DEBUGFS_ATTRIBUTE(eeh_enable_dbgfs_ops, eeh_enable_dbgfs_get, eeh_enable_dbgfs_set, "0x%llx\n"); -DEFINE_DEBUGFS_ATTRIBUTE(eeh_freeze_dbgfs_ops, eeh_freeze_dbgfs_get, - eeh_freeze_dbgfs_set, "0x%llx\n"); #endif static int __init eeh_init_proc(void) @@ -1822,9 +1808,8 @@ static int __init eeh_init_proc(void) debugfs_create_file_unsafe("eeh_enable", 0600, powerpc_debugfs_root, NULL, &eeh_enable_dbgfs_ops); - debugfs_create_file_unsafe("eeh_max_freezes", 0600, - powerpc_debugfs_root, NULL, - &eeh_freeze_dbgfs_ops); + debugfs_create_u32("eeh_max_freezes", 0600, + powerpc_debugfs_root, &eeh_max_freezes); #endif }
There's no need to the custom getter/setter functions so we should remove them in favour of using the generic one. While we're here, change the type of eeh_max_freeze to uint32_t and print the value in decimal rather than hex because printing it in hex makes no sense. Signed-off-by: Oliver O'Halloran <oohall@gmail.com> --- arch/powerpc/include/asm/eeh.h | 2 +- arch/powerpc/kernel/eeh.c | 21 +++------------------ 2 files changed, 4 insertions(+), 19 deletions(-)