Message ID | 1549562254-41157-29-git-send-email-pbonzini@redhat.com |
---|---|
State | New |
Headers | show |
Series | Support Kconfig in QEMU | expand |
On Thu, Feb 07, 2019 at 06:57:11PM +0100, Paolo Bonzini wrote: > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > Signed-off-by: Yang Zhong <yang.zhong@intel.com> > Message-Id: <20190123065618.3520-36-yang.zhong@intel.com> > Reviewed-by: Thomas Huth <thuth@redhat.com> > Signed-off-by: Paolo Bonzini <pbonzini@redhat.com> > --- > default-configs/i386-softmmu.mak | 3 --- > default-configs/ppc64-softmmu.mak | 3 --- > hw/ipmi/Kconfig | 6 ++++++ > 3 files changed, 6 insertions(+), 6 deletions(-) This looks ok to me. Reviewed-by: Corey Minyard <cminyard@mvista.com> > > diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak > index 53e9d5e..e779ee1 100644 > --- a/default-configs/i386-softmmu.mak > +++ b/default-configs/i386-softmmu.mak > @@ -1,9 +1,6 @@ > # Default configuration for i386-softmmu > > CONFIG_VMXNET3_PCI=y > -CONFIG_IPMI=y > -CONFIG_IPMI_LOCAL=y > -CONFIG_IPMI_EXTERN=y > CONFIG_ISA_IPMI_KCS=y > CONFIG_ISA_IPMI_BT=y > > diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak > index a0a9151..d642b67 100644 > --- a/default-configs/ppc64-softmmu.mak > +++ b/default-configs/ppc64-softmmu.mak > @@ -5,9 +5,6 @@ include ppc-softmmu.mak > > # For PowerNV > CONFIG_POWERNV=y > -CONFIG_IPMI=y > -CONFIG_IPMI_LOCAL=y > -CONFIG_IPMI_EXTERN=y > CONFIG_ISA_IPMI_BT=y > > # For pSeries > diff --git a/hw/ipmi/Kconfig b/hw/ipmi/Kconfig > index 6a4f08f..b944fae 100644 > --- a/hw/ipmi/Kconfig > +++ b/hw/ipmi/Kconfig > @@ -3,14 +3,20 @@ config IPMI > > config IPMI_LOCAL > bool > + default y > + depends on IPMI > > config IPMI_EXTERN > bool > + default y > + depends on IPMI > > config ISA_IPMI_KCS > bool > depends on ISA_BUS > + select IPMI > > config ISA_IPMI_BT > bool > depends on ISA_BUS > + select IPMI > -- > 1.8.3.1 > > >
diff --git a/default-configs/i386-softmmu.mak b/default-configs/i386-softmmu.mak index 53e9d5e..e779ee1 100644 --- a/default-configs/i386-softmmu.mak +++ b/default-configs/i386-softmmu.mak @@ -1,9 +1,6 @@ # Default configuration for i386-softmmu CONFIG_VMXNET3_PCI=y -CONFIG_IPMI=y -CONFIG_IPMI_LOCAL=y -CONFIG_IPMI_EXTERN=y CONFIG_ISA_IPMI_KCS=y CONFIG_ISA_IPMI_BT=y diff --git a/default-configs/ppc64-softmmu.mak b/default-configs/ppc64-softmmu.mak index a0a9151..d642b67 100644 --- a/default-configs/ppc64-softmmu.mak +++ b/default-configs/ppc64-softmmu.mak @@ -5,9 +5,6 @@ include ppc-softmmu.mak # For PowerNV CONFIG_POWERNV=y -CONFIG_IPMI=y -CONFIG_IPMI_LOCAL=y -CONFIG_IPMI_EXTERN=y CONFIG_ISA_IPMI_BT=y # For pSeries diff --git a/hw/ipmi/Kconfig b/hw/ipmi/Kconfig index 6a4f08f..b944fae 100644 --- a/hw/ipmi/Kconfig +++ b/hw/ipmi/Kconfig @@ -3,14 +3,20 @@ config IPMI config IPMI_LOCAL bool + default y + depends on IPMI config IPMI_EXTERN bool + default y + depends on IPMI config ISA_IPMI_KCS bool depends on ISA_BUS + select IPMI config ISA_IPMI_BT bool depends on ISA_BUS + select IPMI