From patchwork Tue Feb 5 10:32:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andy Whitcroft X-Patchwork-Id: 1037964 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43wFsS6x93z9sN8; Thu, 7 Feb 2019 22:07:56 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1grhX5-0006h1-Jh; Thu, 07 Feb 2019 11:07:51 +0000 Received: from youngberry.canonical.com ([91.189.89.112]) by huckleberry.canonical.com with esmtps (TLS1.0:DHE_RSA_AES_128_CBC_SHA1:128) (Exim 4.86_2) (envelope-from ) id 1grhX3-0006gP-Lh for kernel-team@lists.ubuntu.com; Thu, 07 Feb 2019 11:07:49 +0000 Received: from 1.general.apw.uk.vpn ([10.172.192.78] helo=localhost) by youngberry.canonical.com with esmtpsa (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.76) (envelope-from ) id 1grhX3-0002WD-Cb; Thu, 07 Feb 2019 11:07:49 +0000 From: Andy Whitcroft To: kernel-team@lists.ubuntu.com Subject: [PATCH 1/2] UBUNTU: [Packaging] drop redundant = from define statements Date: Tue, 5 Feb 2019 10:32:26 +0000 Message-Id: <20190205103227.6048-2-apw@canonical.com> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190205103227.6048-1-apw@canonical.com> References: <20190205103227.6048-1-apw@canonical.com> MIME-Version: 1.0 X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Andy Whitcroft Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" This = syntax is not supported in older GNU Make versions and the = form is exactly equivalent to the unannoted define. Signed-off-by: Andy Whitcroft --- debian/rules.d/2-binary-arch.mk | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/debian/rules.d/2-binary-arch.mk b/debian/rules.d/2-binary-arch.mk index 3200f755bb26..f32b61e2d1fc 100644 --- a/debian/rules.d/2-binary-arch.mk +++ b/debian/rules.d/2-binary-arch.mk @@ -39,7 +39,7 @@ prepare-%: $(stampdir)/stamp-prepare-% build-%: $(stampdir)/stamp-build-% @echo Debug: $@ -define build_zfs = +define build_zfs # # SPL/ZFS wants a fully built kernel before you can configure and build. # It seems to be impossible to tease out the application configuration @@ -74,14 +74,14 @@ $(stampdir)/stamp-build-%: $(stampdir)/stamp-prepare-% @touch $@ -define install_zfs = +define install_zfs cd $(builddir)/build-$*/spl/module; \ $(kmake) -C $(builddir)/build-$* SUBDIRS=`pwd` modules_install $(splopts) cd $(builddir)/build-$*/zfs/module; \ $(kmake) -C $(builddir)/build-$* SUBDIRS=`pwd` modules_install $(zfsopts) endef -define install_control = +define install_control for which in $(3); \ do \ template="$(DROOT)/templates/$(2).$$which.in"; \