From patchwork Fri Jul 8 09:01:28 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Jean Delvare X-Patchwork-Id: 103785 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 8EE57B6F00 for ; Fri, 8 Jul 2011 19:01:37 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754437Ab1GHJBb (ORCPT ); Fri, 8 Jul 2011 05:01:31 -0400 Received: from cantor2.suse.de ([195.135.220.15]:53638 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754287Ab1GHJBa (ORCPT ); Fri, 8 Jul 2011 05:01:30 -0400 Received: from relay1.suse.de (charybdis-ext.suse.de [195.135.221.2]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx2.suse.de (Postfix) with ESMTP id ECB378A95F; Fri, 8 Jul 2011 11:01:29 +0200 (CEST) From: Jean Delvare Organization: Suse Linux To: netdev@vger.kernel.org Subject: [PATCH] net/natsemi: Fix module parameter permissions Date: Fri, 8 Jul 2011 11:01:28 +0200 User-Agent: KMail/1.12.4 (Linux/2.6.32.36-0.5-pae; KDE/4.3.5; i686; ; ) Cc: Tim Hockin , Mark Brown MIME-Version: 1.0 Message-Id: <201107081101.28812.jdelvare@suse.de> Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org The third parameter of module_param is supposed to represent sysfs file permissions. A value of "1" leads to the following: $ ls -l /sys/module/natsemi/parameters/ total 0 ---------x 1 root root 4096 Jul 8 09:46 dspcfg_workaround I am changing it to "0" to align with the other module parameters in this driver. Signed-off-by: Jean Delvare Cc: Tim Hockin Cc: Mark Brown --- drivers/net/natsemi.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) --- linux-3.0-rc6.orig/drivers/net/natsemi.c 2011-05-30 20:45:13.000000000 +0200 +++ linux-3.0-rc6/drivers/net/natsemi.c 2011-07-08 09:57:47.000000000 +0200 @@ -140,7 +140,7 @@ MODULE_LICENSE("GPL"); module_param(mtu, int, 0); module_param(debug, int, 0); module_param(rx_copybreak, int, 0); -module_param(dspcfg_workaround, int, 1); +module_param(dspcfg_workaround, int, 0); module_param_array(options, int, NULL, 0); module_param_array(full_duplex, int, NULL, 0); MODULE_PARM_DESC(mtu, "DP8381x MTU (all boards)");