From patchwork Tue Feb 5 21:21:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Thomas De Schampheleire X-Patchwork-Id: 1037208 Return-Path: X-Original-To: incoming-buildroot@patchwork.ozlabs.org Delivered-To: patchwork-incoming-buildroot@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=busybox.net (client-ip=140.211.166.137; helo=fraxinus.osuosl.org; envelope-from=buildroot-bounces@busybox.net; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="p3crUneb"; dkim-atps=neutral Received: from fraxinus.osuosl.org (smtp4.osuosl.org [140.211.166.137]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43vHZq2SCLz9sDL for ; Wed, 6 Feb 2019 08:21:55 +1100 (AEDT) Received: from localhost (localhost [127.0.0.1]) by fraxinus.osuosl.org (Postfix) with ESMTP id AA27A86E9F; Tue, 5 Feb 2019 21:21:52 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from fraxinus.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id OtHFQvy1ko3H; Tue, 5 Feb 2019 21:21:48 +0000 (UTC) Received: from ash.osuosl.org (ash.osuosl.org [140.211.166.34]) by fraxinus.osuosl.org (Postfix) with ESMTP id 3AB6886E71; Tue, 5 Feb 2019 21:21:48 +0000 (UTC) X-Original-To: buildroot@lists.busybox.net Delivered-To: buildroot@osuosl.org Received: from whitealder.osuosl.org (smtp1.osuosl.org [140.211.166.138]) by ash.osuosl.org (Postfix) with ESMTP id 0EE3D1BF398 for ; Tue, 5 Feb 2019 21:21:47 +0000 (UTC) Received: from localhost (localhost [127.0.0.1]) by whitealder.osuosl.org (Postfix) with ESMTP id 0BBF887CA3 for ; Tue, 5 Feb 2019 21:21:47 +0000 (UTC) X-Virus-Scanned: amavisd-new at osuosl.org Received: from whitealder.osuosl.org ([127.0.0.1]) by localhost (.osuosl.org [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id ij7KjUI52BRW for ; Tue, 5 Feb 2019 21:21:46 +0000 (UTC) X-Greylist: domain auto-whitelisted by SQLgrey-1.7.6 Received: from mail-ed1-f48.google.com (mail-ed1-f48.google.com [209.85.208.48]) by whitealder.osuosl.org (Postfix) with ESMTPS id 3142487CB0 for ; Tue, 5 Feb 2019 21:21:46 +0000 (UTC) Received: by mail-ed1-f48.google.com with SMTP id p6so4201234eds.0 for ; Tue, 05 Feb 2019 13:21:46 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=056DbvBIf6tOF3T5h78ksckYL5q74/p/Igx3zrX7CtM=; b=p3crUnebu/AcUaJlXY3Lv7a7acsLfjeB1Lxs1CgMze8N/iQYfJwYABi0JlN61Y9Q6f tW3RokcrAJavUerHbOI30tjpqSt0Gcv6kiNDwiX5J3SZ0XbVBQ67GkaT04tQ6RwYonKH gqyPx+VwBmpsKj2R7U8VeudzAnxtLGc6IrCSc4OW5VpVza/FCKXbhh5re+icFF/RQpKW wBVn2zhtFod0Oti7zxvZSxL12VBFHaL76lkD4QXbjleMpktJiyN0lbJ9ml3LdM3mBneJ 3ah95u9nsMMtTlsWXBeqh8t/4YibUMimqCu36L2YX8WQLDJ7MRK5w96Fe8dp03qwhesf sQeg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=056DbvBIf6tOF3T5h78ksckYL5q74/p/Igx3zrX7CtM=; b=KvuYUWrFCGQcrB+8n8WVzUysq7RjtErLkF1RMn/DqwGcwvKAXl09uX7YNPddSD0zgx 2sDV1QBXFwIwzE0FdX5E4wCLz+eMPt19W50LDDClbN2EM0iCRKR/6ynPZt6SFYGs1qzT ufZXZmS3xTZ/YU+lmYjjsCbc8o38siaJAdmxVcfxj6H7zsA1iEg37KqMYw6pUaFikepY 2Ot4V2GHgZZlO1ruAuntcXg5nxwGt9SadJTCleZI8NqOdZKnR8jpnw6bRFhL5xdaP0gb 4oRs+2+RB2d63J8+FsQ/QpcufmHjFsC/QHDBDs7AMmCZPHTVmvOl/UsrLq8yyfbA1fYF aBQQ== X-Gm-Message-State: AHQUAubEPBHwbVjrzLz282EbGG7XZesgCCVvjILQveVY4L6/bAxmmnaV ZmUKoMC31xCzo76nGHTEsQ64WwwRhZg= X-Google-Smtp-Source: AHgI3IZBcDBigeL7+3dCffGxRAj+ayifKBCc9lkr7L/ojYP1w05HIe7iUbG1zSGrEzFOenOv2mpztg== X-Received: by 2002:a17:906:5501:: with SMTP id r1mr5023878ejp.167.1549401704065; Tue, 05 Feb 2019 13:21:44 -0800 (PST) Received: from localhost.localdomain (ptr-5ltycmajy3605r3p7a.18120a2.ip6.access.telenet.be. [2a02:1810:530:b600:aa50:f99f:a32c:5156]) by smtp.gmail.com with ESMTPSA id u18sm3270021ejl.5.2019.02.05.13.21.42 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 05 Feb 2019 13:21:43 -0800 (PST) From: Thomas De Schampheleire To: buildroot@buildroot.org Date: Tue, 5 Feb 2019 22:21:41 +0100 Message-Id: <20190205212142.2244-1-patrickdepinguin@gmail.com> X-Mailer: git-send-email 2.19.2 MIME-Version: 1.0 Subject: [Buildroot] [PATCHv3 1/2] utils/test-pkg: fix long option parsing X-BeenThere: buildroot@busybox.net X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion and development of buildroot List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: Thomas De Schampheleire Errors-To: buildroot-bounces@busybox.net Sender: "buildroot" From: Thomas De Schampheleire The long option parsing of test-pkg is broken because: - some long options are not declared - there should be a comma between long options, the colon does not replace it. This change also revealed that the declaration of 'toolchains-dir' should have been 'toolchains-csv', originally introduced in commit ed59f81a3cb4ddb. Signed-off-by: Thomas De Schampheleire Acked-by: Yann E. MORIN --- utils/test-pkg | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) v3: unchanged v2: new patch diff --git a/utils/test-pkg b/utils/test-pkg index 1995fa8578..087f9ddca9 100755 --- a/utils/test-pkg +++ b/utils/test-pkg @@ -5,12 +5,12 @@ TOOLCHAINS_CSV='support/config-fragments/autobuild/toolchain-configs.csv' main() { local o O opts - local cfg dir pkg random toolchains_dir toolchain all number mode + local cfg dir pkg random toolchains_csv toolchain all number mode local ret nb nb_skip nb_fail nb_legal nb_tc build_dir local -a toolchains o='hac:d:n:p:r:t:' - O='help,config-snippet:build-dir:package:,random:,toolchains-dir:' + O='help,all,config-snippet:,build-dir:,number:,package:,random:,toolchains-csv:' opts="$(getopt -n "${my_name}" -o "${o}" -l "${O}" -- "${@}")" eval set -- "${opts}"