Patchwork [pull-request,Natty,SRU] Fix wlan soft block issues on Acer Aspire 1830

login
register
mail settings
Submitter Seth Forshee
Date July 7, 2011, 5:30 p.m.
Message ID <20110707173016.GB9805@thinkpad-t410>
Download mbox
Permalink /patch/103705/
State New
Headers show

Pull-request

git://kernel.ubuntu.com/sforshee/ubuntu-natty.git acer-wmi

Comments

Seth Forshee - July 7, 2011, 5:30 p.m.
All patches are either upstream backports or queued for upstream in the
platform-drivers-x86 tree.


SRU Justification

Impact: The wlan on the Acer Aspire 1830 always has a soft block applied
due to incorrect values read from the BIOS on periodic updates.

Fix: Backport patch that makes this model use WMI events to update
rfkill states instead of periodic polling. Data in WMI events accurately
reflects the status of the blocks. The backport results in a wlan soft
block when pressing the touchpad hotkey, so also include a fix to only
update rfkill states when wireless hotkeys are pressed as well as a
trivial patch to support the wlan hotkey on this model.

Test case: Verify that wlan soft block can be removed, wlan hotkey
functions, and touchpad hotkey does not affect wlan on the affected
model. Tested on LP #771758.


The following changes since commit c37dcf3c2155becf5f2a2cd650fafff8960cb6e9:

  UBUNTU: Ubuntu-2.6.38-10.46 (2011-06-28 14:38:06 +0100)

are available in the git repository at:
  git://kernel.ubuntu.com/sforshee/ubuntu-natty.git acer-wmi

Lee, Chun-Yi (1):
      acer-wmi: does not poll device status when WMI event is available

Seth Forshee (2):
      acer-wmi: Only update rfkill status for associated hotkey events
      acer-wmi: Add support for Aspire 1830 wlan hotkey

 drivers/platform/x86/acer-wmi.c |   39 ++++++++++++++++++++++++++++++++++-----
 1 files changed, 34 insertions(+), 5 deletions(-)
Tim Gardner - July 7, 2011, 7:45 p.m.
On 07/07/2011 11:30 AM, Seth Forshee wrote:
> git://kernel.ubuntu.com/sforshee/ubuntu-natty.git acer-wmi

What is the state of 'acer-wmi: Only update rfkill status for associated 
hotkey events' ? Is that patch working its way upstream ?

rtg
Seth Forshee - July 7, 2011, 8:27 p.m.
On Thu, Jul 07, 2011 at 01:45:06PM -0600, Tim Gardner wrote:
> On 07/07/2011 11:30 AM, Seth Forshee wrote:
> >git://kernel.ubuntu.com/sforshee/ubuntu-natty.git acer-wmi
> 
> What is the state of 'acer-wmi: Only update rfkill status for
> associated hotkey events' ? Is that patch working its way upstream ?

Yes. It's sitting in Matthew Garrett's for_linus branch.

http://git.kernel.org/?p=linux/kernel/git/mjg59/platform-drivers-x86.git;a=commit;h=92530664bbe5a13aede4a8763459bbe560ad9221
Seth Forshee - July 7, 2011, 9:21 p.m.
On Thu, Jul 07, 2011 at 03:27:47PM -0500, Seth Forshee wrote:
> On Thu, Jul 07, 2011 at 01:45:06PM -0600, Tim Gardner wrote:
> > On 07/07/2011 11:30 AM, Seth Forshee wrote:
> > >git://kernel.ubuntu.com/sforshee/ubuntu-natty.git acer-wmi
> > 
> > What is the state of 'acer-wmi: Only update rfkill status for
> > associated hotkey events' ? Is that patch working its way upstream ?
> 
> Yes. It's sitting in Matthew Garrett's for_linus branch.
> 
> http://git.kernel.org/?p=linux/kernel/git/mjg59/platform-drivers-x86.git;a=commit;h=92530664bbe5a13aede4a8763459bbe560ad9221

Hrm, I just noticed that I had pushed a stale version of that patch with
an extraneous break statement. Guess I must have grabbed an old version
when I was reworking the branch to remove an unneeded patch.

I updated the branch with the correct version, so make sure you get that
one instead of the patch I pushed originally. I double-checked the other
two patches, and they are correct.
Tim Gardner - July 8, 2011, 4:52 p.m.
On 07/07/2011 02:27 PM, Seth Forshee wrote:
> On Thu, Jul 07, 2011 at 01:45:06PM -0600, Tim Gardner wrote:
>> On 07/07/2011 11:30 AM, Seth Forshee wrote:
>>> git://kernel.ubuntu.com/sforshee/ubuntu-natty.git acer-wmi
>>
>> What is the state of 'acer-wmi: Only update rfkill status for
>> associated hotkey events' ? Is that patch working its way upstream ?
>
> Yes. It's sitting in Matthew Garrett's for_linus branch.
>
> http://git.kernel.org/?p=linux/kernel/git/mjg59/platform-drivers-x86.git;a=commit;h=92530664bbe5a13aede4a8763459bbe560ad9221

Is that gonna land in 3.0 or 3.1 ? My preference would be to wait until 
the patch makes its way upstream in its final form.

rtg
Seth Forshee - July 8, 2011, 6:24 p.m.
On Fri, Jul 08, 2011 at 10:52:40AM -0600, Tim Gardner wrote:
> On 07/07/2011 02:27 PM, Seth Forshee wrote:
> >On Thu, Jul 07, 2011 at 01:45:06PM -0600, Tim Gardner wrote:
> >>On 07/07/2011 11:30 AM, Seth Forshee wrote:
> >>>git://kernel.ubuntu.com/sforshee/ubuntu-natty.git acer-wmi
> >>
> >>What is the state of 'acer-wmi: Only update rfkill status for
> >>associated hotkey events' ? Is that patch working its way upstream ?
> >
> >Yes. It's sitting in Matthew Garrett's for_linus branch.
> >
> >http://git.kernel.org/?p=linux/kernel/git/mjg59/platform-drivers-x86.git;a=commit;h=92530664bbe5a13aede4a8763459bbe560ad9221
> 
> Is that gonna land in 3.0 or 3.1 ? My preference would be to wait
> until the patch makes its way upstream in its final form.

This one should be landing in 3.0, as it's fixing a regression, so I'll
resend after Linus merges it. Thanks.