diff mbox series

[rs6000] Further vec-extract test fixes

Message ID 20190205160403.GV2135@tucnak
State New
Headers show
Series [rs6000] Further vec-extract test fixes | expand

Commit Message

Jakub Jelinek Feb. 5, 2019, 4:04 p.m. UTC
On Sat, Feb 02, 2019 at 05:09:37PM -0600, Segher Boessenkool wrote:
> > 2019-02-01  Kelvin Nilsen  <kelvin@gcc.gnu.org>
> > 
> > 	* gcc.target/powerpc/vec-extract-slong-1.c: Require p8 execution
> > 	hardware.
> > 	* gcc.target/powerpc/vec-extract-schar-1.c: Likewise.
> > 	* gcc.target/powerpc/vec-extract-sint128-1.c: Likewise.
> > 	* gcc.target/powerpc/vec-extract-sshort-1.c: Likewise.
> > 	* gcc.target/powerpc/vec-extract-ulong-1.c: Likewise.
> > 	* gcc.target/powerpc/vec-extract-uchar-1.c: Likewise.
> > 	* gcc.target/powerpc/vec-extract-sint-1.c: Likewise.
> > 	* gcc.target/powerpc/vec-extract-uint128-1.c: Likewise.
> > 	* gcc.target/powerpc/vec-extract-ushort-1.c: Likewise.
> > 	* gcc.target/powerpc/vec-extract-uint-1.c: Likewise.

I don't see how the vec-extract-?int128-1.c tests could pass on big endian
power8 with -m32, __int128 type is only supported for 64-bit targets.

Ok for trunk?

2019-02-05  Jakub Jelinek  <jakub@redhat.com>

	* gcc.target/powerpc/vec-extract-sint128-1.c: Require int128 effective
	target.
	* gcc.target/powerpc/vec-extract-uint128-1.c: Likewise.



	Jakub

Comments

Segher Boessenkool Feb. 5, 2019, 4:19 p.m. UTC | #1
On Tue, Feb 05, 2019 at 05:04:03PM +0100, Jakub Jelinek wrote:
> On Sat, Feb 02, 2019 at 05:09:37PM -0600, Segher Boessenkool wrote:
> > > 2019-02-01  Kelvin Nilsen  <kelvin@gcc.gnu.org>
> > > 
> > > 	* gcc.target/powerpc/vec-extract-slong-1.c: Require p8 execution
> > > 	hardware.
> > > 	* gcc.target/powerpc/vec-extract-schar-1.c: Likewise.
> > > 	* gcc.target/powerpc/vec-extract-sint128-1.c: Likewise.
> > > 	* gcc.target/powerpc/vec-extract-sshort-1.c: Likewise.
> > > 	* gcc.target/powerpc/vec-extract-ulong-1.c: Likewise.
> > > 	* gcc.target/powerpc/vec-extract-uchar-1.c: Likewise.
> > > 	* gcc.target/powerpc/vec-extract-sint-1.c: Likewise.
> > > 	* gcc.target/powerpc/vec-extract-uint128-1.c: Likewise.
> > > 	* gcc.target/powerpc/vec-extract-ushort-1.c: Likewise.
> > > 	* gcc.target/powerpc/vec-extract-uint-1.c: Likewise.
> 
> I don't see how the vec-extract-?int128-1.c tests could pass on big endian
> power8 with -m32, __int128 type is only supported for 64-bit targets.

This is fine, okay for trunk, thanks!


Segher


> 2019-02-05  Jakub Jelinek  <jakub@redhat.com>
> 
> 	* gcc.target/powerpc/vec-extract-sint128-1.c: Require int128 effective
> 	target.
> 	* gcc.target/powerpc/vec-extract-uint128-1.c: Likewise.
diff mbox series

Patch

--- gcc/testsuite/gcc.target/powerpc/vec-extract-sint128-1.c.jj	2019-02-05 16:34:42.955573498 +0100
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-sint128-1.c	2019-02-05 16:54:11.188111106 +0100
@@ -1,6 +1,6 @@ 
 /* Test to verify that the vec_extract from a vector of
    signed __int128s remains signed.  */
-/* { dg-do run } */
+/* { dg-do run { target int128 } } */
 /* { dg-options "-ansi -mcpu=power8 " } */
 /* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
--- gcc/testsuite/gcc.target/powerpc/vec-extract-uint128-1.c.jj	2019-02-05 16:34:42.957573464 +0100
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-uint128-1.c	2019-02-05 16:54:23.503906762 +0100
@@ -1,6 +1,6 @@ 
 /* Test to verify that the vec_extract from a vector of
    unsigned __int128s remains unsigned.  */
-/* { dg-do run } */
+/* { dg-do run { target int128 } } */
 /* { dg-options "-ansi -mcpu=power8 " } */
 /* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */