| Message ID | 1549371525-29899-1-git-send-email-thuth@redhat.com |
|---|---|
| State | New |
| Headers | show |
| Series | hw/cpu/cluster: Mark the cpu-cluster device with user_creatable = false | expand |
On 2019-02-05 14:09, Peter Maydell wrote: > On Tue, 5 Feb 2019 at 12:58, Thomas Huth <thuth@redhat.com> wrote: >> >> The device can not be instantiated by the user and QEMU currently >> aborts when you try to use it: >> >> $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster >> qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize: >> Assertion `cbdata.cpu_count > 0' failed. >> Aborted (core dumped) >> >> Since this is an internal device only, mark it with user_creatable = false. >> >> Signed-off-by: Thomas Huth <thuth@redhat.com> >> --- >> hw/cpu/cluster.c | 3 +++ >> 1 file changed, 3 insertions(+) >> >> diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c >> index 25f9070..6f5f037 100644 >> --- a/hw/cpu/cluster.c >> +++ b/hw/cpu/cluster.c >> @@ -79,6 +79,9 @@ static void cpu_cluster_class_init(ObjectClass *klass, void *data) >> >> dc->props = cpu_cluster_properties; >> dc->realize = cpu_cluster_realize; >> + >> + /* This is not directly for users, CPU children must be attached by code */ >> + dc->user_creatable = false; >> } >> >> static const TypeInfo cpu_cluster_type_info = { >> -- > > > Reviewed-by: Peter Maydell <peter.maydell@linaro.org> > > Would it be possible to add a 'make check' test that every device > we claim to be user-creatable can be created without crashing ? That's what Eduardo's scripts/device-crash-test is good for. It's just too slow to run during "make check" currently, since it checks each device with each machine type... But IIRC Eduardo once had ideas to improve this...? Thomas
On 2/5/19 1:58 PM, Thomas Huth wrote: > The device can not be instantiated by the user and QEMU currently > aborts when you try to use it: > > $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster > qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize: > Assertion `cbdata.cpu_count > 0' failed. > Aborted (core dumped) > > Since this is an internal device only, mark it with user_creatable = false. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Philippe Mathieu-Daudé <philmd@redhat.com> > --- > hw/cpu/cluster.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c > index 25f9070..6f5f037 100644 > --- a/hw/cpu/cluster.c > +++ b/hw/cpu/cluster.c > @@ -79,6 +79,9 @@ static void cpu_cluster_class_init(ObjectClass *klass, void *data) > > dc->props = cpu_cluster_properties; > dc->realize = cpu_cluster_realize; > + > + /* This is not directly for users, CPU children must be attached by code */ > + dc->user_creatable = false; > } > > static const TypeInfo cpu_cluster_type_info = { >
On 2/5/19 1:58 PM, Thomas Huth wrote: > The device can not be instantiated by the user and QEMU currently > aborts when you try to use it: > > $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster > qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize: > Assertion `cbdata.cpu_count > 0' failed. > Aborted (core dumped) > > Since this is an internal device only, mark it with user_creatable = false. > > Signed-off-by: Thomas Huth <thuth@redhat.com> Reviewed-by: Luc Michel <luc.michel@greensocs.com> > --- > hw/cpu/cluster.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c > index 25f9070..6f5f037 100644 > --- a/hw/cpu/cluster.c > +++ b/hw/cpu/cluster.c > @@ -79,6 +79,9 @@ static void cpu_cluster_class_init(ObjectClass *klass, void *data) > > dc->props = cpu_cluster_properties; > dc->realize = cpu_cluster_realize; > + > + /* This is not directly for users, CPU children must be attached by code */ > + dc->user_creatable = false; > } > > static const TypeInfo cpu_cluster_type_info = { >
On Tue, Feb 5, 2019 at 7:22 AM Luc Michel <luc.michel@greensocs.com> wrote: > > > > On 2/5/19 1:58 PM, Thomas Huth wrote: > > The device can not be instantiated by the user and QEMU currently > > aborts when you try to use it: > > > > $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster > > qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize: > > Assertion `cbdata.cpu_count > 0' failed. > > Aborted (core dumped) > > > > Since this is an internal device only, mark it with user_creatable = false. > > > > Signed-off-by: Thomas Huth <thuth@redhat.com> > Reviewed-by: Luc Michel <luc.michel@greensocs.com> Reviewed-by: Alistair Francis <alistair.francis@wdc.com> Alistair > > > --- > > hw/cpu/cluster.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c > > index 25f9070..6f5f037 100644 > > --- a/hw/cpu/cluster.c > > +++ b/hw/cpu/cluster.c > > @@ -79,6 +79,9 @@ static void cpu_cluster_class_init(ObjectClass *klass, void *data) > > > > dc->props = cpu_cluster_properties; > > dc->realize = cpu_cluster_realize; > > + > > + /* This is not directly for users, CPU children must be attached by code */ > > + dc->user_creatable = false; > > } > > > > static const TypeInfo cpu_cluster_type_info = { > > >
On 05/02/2019 13:58, Thomas Huth wrote: > The device can not be instantiated by the user and QEMU currently > aborts when you try to use it: > > $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster > qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize: > Assertion `cbdata.cpu_count > 0' failed. > Aborted (core dumped) > > Since this is an internal device only, mark it with user_creatable = false. > > Signed-off-by: Thomas Huth <thuth@redhat.com> > --- > hw/cpu/cluster.c | 3 +++ > 1 file changed, 3 insertions(+) > > diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c > index 25f9070..6f5f037 100644 > --- a/hw/cpu/cluster.c > +++ b/hw/cpu/cluster.c > @@ -79,6 +79,9 @@ static void cpu_cluster_class_init(ObjectClass *klass, void *data) > > dc->props = cpu_cluster_properties; > dc->realize = cpu_cluster_realize; > + > + /* This is not directly for users, CPU children must be attached by code */ > + dc->user_creatable = false; > } > > static const TypeInfo cpu_cluster_type_info = { > Applied to my trivial-patches branch. Thanks, Laurent
diff --git a/hw/cpu/cluster.c b/hw/cpu/cluster.c index 25f9070..6f5f037 100644 --- a/hw/cpu/cluster.c +++ b/hw/cpu/cluster.c @@ -79,6 +79,9 @@ static void cpu_cluster_class_init(ObjectClass *klass, void *data) dc->props = cpu_cluster_properties; dc->realize = cpu_cluster_realize; + + /* This is not directly for users, CPU children must be attached by code */ + dc->user_creatable = false; } static const TypeInfo cpu_cluster_type_info = {
The device can not be instantiated by the user and QEMU currently aborts when you try to use it: $ x86_64-softmmu/qemu-system-x86_64 -device cpu-cluster qemu-system-x86_64: hw/cpu/cluster.c:73: cpu_cluster_realize: Assertion `cbdata.cpu_count > 0' failed. Aborted (core dumped) Since this is an internal device only, mark it with user_creatable = false. Signed-off-by: Thomas Huth <thuth@redhat.com> --- hw/cpu/cluster.c | 3 +++ 1 file changed, 3 insertions(+)