Patchwork [U-Boot,V2,1/4] Added documentation for CONFIG_SYS_TEXT_BASE.

login
register
mail settings
Submitter Christopher Harvey
Date July 7, 2011, 2:26 p.m.
Message ID <20110707142627.GB5438@harvey-pc.matrox.com>
Download mbox | patch
Permalink /patch/103672/
State Accepted
Delegated to: Albert ARIBAUD
Headers show

Comments

Christopher Harvey - July 7, 2011, 2:26 p.m.
Signed-off-by: Christopher Harvey <charvey@matrox.com>
---
V2:
Make it clear that this is the start address of u-boot. 

 README |    6 ++++++
 1 files changed, 6 insertions(+), 0 deletions(-)
Albert ARIBAUD - Aug. 4, 2011, 6:20 a.m.
Hi Christopher,

Le 07/07/2011 16:26, Christopher Harvey a écrit :
> Signed-off-by: Christopher Harvey<charvey@matrox.com>
> ---
> V2:
> Make it clear that this is the start address of u-boot.
>
>   README |    6 ++++++
>   1 files changed, 6 insertions(+), 0 deletions(-)
>
> diff --git a/README b/README
> index 2da0f96..8345746 100644
> --- a/README
> +++ b/README
> @@ -2366,6 +2366,12 @@ Configuration Settings:
>   - CONFIG_SYS_SDRAM_BASE:
>   		Physical start address of SDRAM. _Must_ be 0 here.
>
> +- CONFIG_SYS_TEXT_BASE:
> +		Is the start address of the u-boot code.
> +		This value can be in ROM space since u-boot can startup from
> +		within ROM. This value has nothing to do with the relocation
> +		destination in RAM.
> +
>   - CONFIG_SYS_MBIO_BASE:
>   		Physical start address of Motherboard I/O (if using a
>   		Cogent motherboard)

Applied to u-boot-arm/master (with 3 trailing whitespaces fixed), thanks!

Amicalement,
Christopher Harvey - Aug. 24, 2011, 6:34 p.m.
On Thu, Aug 04, 2011 at 08:20:33AM +0200, Albert ARIBAUD wrote:
> Hi Christopher,
> 
> Le 07/07/2011 16:26, Christopher Harvey a ?crit :
> > Signed-off-by: Christopher Harvey<charvey@matrox.com>
> > ---
> > V2:
> > Make it clear that this is the start address of u-boot.
> >
> >   README |    6 ++++++
> >   1 files changed, 6 insertions(+), 0 deletions(-)
> >
> > diff --git a/README b/README
> > index 2da0f96..8345746 100644
> > --- a/README
> > +++ b/README
> > @@ -2366,6 +2366,12 @@ Configuration Settings:
> >   - CONFIG_SYS_SDRAM_BASE:
> >   		Physical start address of SDRAM. _Must_ be 0 here.
> >
> > +- CONFIG_SYS_TEXT_BASE:
> > +		Is the start address of the u-boot code.
> > +		This value can be in ROM space since u-boot can startup from
> > +		within ROM. This value has nothing to do with the relocation
> > +		destination in RAM.
> > +
> >   - CONFIG_SYS_MBIO_BASE:
> >   		Physical start address of Motherboard I/O (if using a
> >   		Cogent motherboard)
> 
> Applied to u-boot-arm/master (with 3 trailing whitespaces fixed), thanks!
> 
> Amicalement,
> -- 
> Albert.

I'm curious, this one never went in. I'd like to know if I'm
not understanding CONFIG_SYS_TEXT_BASE completely.

thanks.
Wolfgang Denk - Aug. 24, 2011, 7:12 p.m.
Dear Christopher Harvey,

In message <20110824183457.GB3070@harvey-pc.matrox.com> you wrote:
>
> > > +- CONFIG_SYS_TEXT_BASE:
> > > +		Is the start address of the u-boot code.
> > > +		This value can be in ROM space since u-boot can startup from
> > > +		within ROM. This value has nothing to do with the relocation
> > > +		destination in RAM.
> > > +
> > >   - CONFIG_SYS_MBIO_BASE:
> > >   		Physical start address of Motherboard I/O (if using a
> > >   		Cogent motherboard)
> > 
> > Applied to u-boot-arm/master (with 3 trailing whitespaces fixed), thanks!
...
> I'm curious, this one never went in. I'd like to know if I'm
> not understanding CONFIG_SYS_TEXT_BASE completely.

I can't see it in Albert's u-boot-arm/master branch, either.

...and the text is actually wrong.

What is the "start address"?  I would say that "_start" defines the
start address, i. e. the entry point into the U-Boot code where the
CPU starts execution after a reset.  But this is on most systems NOT
CONFIG_SYS_TEXT_BASE.  CONFIG_SYS_TEXT_BASE is the start address of
the text segment.  - as the name suggests.

Guess that should be fixed...

Best regards,

Wolfgang Denk

Patch

diff --git a/README b/README
index 2da0f96..8345746 100644
--- a/README
+++ b/README
@@ -2366,6 +2366,12 @@  Configuration Settings:
 - CONFIG_SYS_SDRAM_BASE:
 		Physical start address of SDRAM. _Must_ be 0 here.
 
+- CONFIG_SYS_TEXT_BASE:
+		Is the start address of the u-boot code. 
+		This value can be in ROM space since u-boot can startup from
+		within ROM. This value has nothing to do with the relocation 
+		destination in RAM. 
+
 - CONFIG_SYS_MBIO_BASE:
 		Physical start address of Motherboard I/O (if using a
 		Cogent motherboard)