| Message ID | 20190205035704.26014-1-eblake@redhat.com |
|---|---|
| State | New |
| Headers | show |
Patchew URL: https://patchew.org/QEMU/20190205035704.26014-1-eblake@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04
Type: series
Message-id: 20190205035704.26014-1-eblake@redhat.com
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
t [tag update] patchew/20190204204517.23698-1-philmd@redhat.com -> patchew/20190204204517.23698-1-philmd@redhat.com
* [new tag] patchew/20190205035704.26014-1-eblake@redhat.com -> patchew/20190205035704.26014-1-eblake@redhat.com
Switched to a new branch 'test'
9f22048c0a block/nbd-client: rename read_reply_co to connection_co
e81ab27f82 block/nbd-client: don't check ioc
ce55b4b331 block/nbd-client: fix nbd_reply_chunk_iter_receive
80c093f3b1 block/nbd-client: split connection from initialization
a24543ee7b block/nbd: move connection code from block/nbd to block/nbd-client
467a28dbf2 block/nbd-client: split channel errors from export errors
bd906b01ff nbd: generalize usage of nbd_read
3d3be1f9bc qemu-nbd: Deprecate qemu-nbd --partition
=== OUTPUT BEGIN ===
1/8 Checking commit 3d3be1f9bcc8 (qemu-nbd: Deprecate qemu-nbd --partition)
2/8 Checking commit bd906b01ffe8 (nbd: generalize usage of nbd_read)
ERROR: spaces required around that '*' (ctx:WxV)
#85: FILE: include/block/nbd.h:356:
+ uint##bits##_t *val, \
^
total: 1 errors, 0 warnings, 386 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 467a28dbf261 (block/nbd-client: split channel errors from export errors)
4/8 Checking commit a24543ee7b41 (block/nbd: move connection code from block/nbd to block/nbd-client)
5/8 Checking commit 80c093f3b180 (block/nbd-client: split connection from initialization)
6/8 Checking commit ce55b4b331f9 (block/nbd-client: fix nbd_reply_chunk_iter_receive)
7/8 Checking commit e81ab27f828e (block/nbd-client: don't check ioc)
8/8 Checking commit 9f22048c0a07 (block/nbd-client: rename read_reply_co to connection_co)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190205035704.26014-1-eblake@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190205035704.26014-1-eblake@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Message-id: 20190205035704.26014-1-eblake@redhat.com
Subject: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
* [new tag] patchew/1549336101-17623-1-git-send-email-thuth@redhat.com -> patchew/1549336101-17623-1-git-send-email-thuth@redhat.com
- [tag update] patchew/20190204204517.23698-1-philmd@redhat.com -> patchew/20190204204517.23698-1-philmd@redhat.com
* [new tag] patchew/20190205035704.26014-1-eblake@redhat.com -> patchew/20190205035704.26014-1-eblake@redhat.com
Switched to a new branch 'test'
9f22048 block/nbd-client: rename read_reply_co to connection_co
e81ab27 block/nbd-client: don't check ioc
ce55b4b block/nbd-client: fix nbd_reply_chunk_iter_receive
80c093f block/nbd-client: split connection from initialization
a24543e block/nbd: move connection code from block/nbd to block/nbd-client
467a28d block/nbd-client: split channel errors from export errors
bd906b0 nbd: generalize usage of nbd_read
3d3be1f qemu-nbd: Deprecate qemu-nbd --partition
=== OUTPUT BEGIN ===
1/8 Checking commit 3d3be1f9bcc8 (qemu-nbd: Deprecate qemu-nbd --partition)
2/8 Checking commit bd906b01ffe8 (nbd: generalize usage of nbd_read)
ERROR: spaces required around that '*' (ctx:WxV)
#85: FILE: include/block/nbd.h:356:
+ uint##bits##_t *val, \
^
total: 1 errors, 0 warnings, 386 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 467a28dbf261 (block/nbd-client: split channel errors from export errors)
4/8 Checking commit a24543ee7b41 (block/nbd: move connection code from block/nbd to block/nbd-client)
5/8 Checking commit 80c093f3b180 (block/nbd-client: split connection from initialization)
6/8 Checking commit ce55b4b331f9 (block/nbd-client: fix nbd_reply_chunk_iter_receive)
7/8 Checking commit e81ab27f828e (block/nbd-client: don't check ioc)
8/8 Checking commit 9f22048c0a07 (block/nbd-client: rename read_reply_co to connection_co)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190205035704.26014-1-eblake@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
Patchew URL: https://patchew.org/QEMU/20190205035704.26014-1-eblake@redhat.com/
Hi,
This series seems to have some coding style problems. See output below for
more information:
Subject: [Qemu-devel] [PULL 0/8] NBD patches for 2019-02-04
Message-id: 20190205035704.26014-1-eblake@redhat.com
Type: series
=== TEST SCRIPT BEGIN ===
#!/bin/bash
git config --local diff.renamelimit 0
git config --local diff.renames True
git config --local diff.algorithm histogram
./scripts/checkpatch.pl --mailback base..
=== TEST SCRIPT END ===
Updating 3c8cf5a9c21ff8782164d1def7f44bd888713384
From https://github.com/patchew-project/qemu
- [tag update] patchew/20190204204517.23698-1-philmd@redhat.com -> patchew/20190204204517.23698-1-philmd@redhat.com
* [new tag] patchew/20190205035704.26014-1-eblake@redhat.com -> patchew/20190205035704.26014-1-eblake@redhat.com
Submodule 'capstone' (https://git.qemu.org/git/capstone.git) registered for path 'capstone'
Submodule 'dtc' (https://git.qemu.org/git/dtc.git) registered for path 'dtc'
Submodule 'roms/QemuMacDrivers' (https://git.qemu.org/git/QemuMacDrivers.git) registered for path 'roms/QemuMacDrivers'
Submodule 'roms/SLOF' (https://git.qemu.org/git/SLOF.git) registered for path 'roms/SLOF'
Submodule 'roms/ipxe' (https://git.qemu.org/git/ipxe.git) registered for path 'roms/ipxe'
Submodule 'roms/openbios' (https://git.qemu.org/git/openbios.git) registered for path 'roms/openbios'
Submodule 'roms/openhackware' (https://git.qemu.org/git/openhackware.git) registered for path 'roms/openhackware'
Submodule 'roms/qemu-palcode' (https://git.qemu.org/git/qemu-palcode.git) registered for path 'roms/qemu-palcode'
Submodule 'roms/seabios' (https://git.qemu.org/git/seabios.git/) registered for path 'roms/seabios'
Submodule 'roms/seabios-hppa' (https://github.com/hdeller/seabios-hppa.git) registered for path 'roms/seabios-hppa'
Submodule 'roms/sgabios' (https://git.qemu.org/git/sgabios.git) registered for path 'roms/sgabios'
Submodule 'roms/skiboot' (https://git.qemu.org/git/skiboot.git) registered for path 'roms/skiboot'
Submodule 'roms/u-boot' (https://git.qemu.org/git/u-boot.git) registered for path 'roms/u-boot'
Submodule 'roms/u-boot-sam460ex' (https://git.qemu.org/git/u-boot-sam460ex.git) registered for path 'roms/u-boot-sam460ex'
Submodule 'tests/fp/berkeley-softfloat-3' (https://github.com/cota/berkeley-softfloat-3) registered for path 'tests/fp/berkeley-softfloat-3'
Submodule 'tests/fp/berkeley-testfloat-3' (https://github.com/cota/berkeley-testfloat-3) registered for path 'tests/fp/berkeley-testfloat-3'
Submodule 'ui/keycodemapdb' (https://git.qemu.org/git/keycodemapdb.git) registered for path 'ui/keycodemapdb'
Cloning into 'capstone'...
Submodule path 'capstone': checked out '22ead3e0bfdb87516656453336160e0a37b066bf'
Cloning into 'dtc'...
Submodule path 'dtc': checked out '88f18909db731a627456f26d779445f84e449536'
Cloning into 'roms/QemuMacDrivers'...
Submodule path 'roms/QemuMacDrivers': checked out '90c488d5f4a407342247b9ea869df1c2d9c8e266'
Cloning into 'roms/SLOF'...
Submodule path 'roms/SLOF': checked out 'a5b428e1c1eae703bdd62a3f527223c291ee3fdc'
Cloning into 'roms/ipxe'...
Submodule path 'roms/ipxe': checked out 'de4565cbe76ea9f7913a01f331be3ee901bb6e17'
Cloning into 'roms/openbios'...
Submodule path 'roms/openbios': checked out '441a84d3a642a10b948369c63f32367e8ff6395b'
Cloning into 'roms/openhackware'...
Submodule path 'roms/openhackware': checked out 'c559da7c8eec5e45ef1f67978827af6f0b9546f5'
Cloning into 'roms/qemu-palcode'...
Submodule path 'roms/qemu-palcode': checked out '51c237d7e20d05100eacadee2f61abc17e6bc097'
Cloning into 'roms/seabios'...
Submodule path 'roms/seabios': checked out 'a698c8995ffb2838296ec284fe3c4ad33dfca307'
Cloning into 'roms/seabios-hppa'...
Submodule path 'roms/seabios-hppa': checked out '1ef99a01572c2581c30e16e6fe69e9ea2ef92ce0'
Cloning into 'roms/sgabios'...
Submodule path 'roms/sgabios': checked out 'cbaee52287e5f32373181cff50a00b6c4ac9015a'
Cloning into 'roms/skiboot'...
Submodule path 'roms/skiboot': checked out 'e0ee24c27a172bcf482f6f2bc905e6211c134bcc'
Cloning into 'roms/u-boot'...
Submodule path 'roms/u-boot': checked out 'd85ca029f257b53a96da6c2fb421e78a003a9943'
Cloning into 'roms/u-boot-sam460ex'...
Submodule path 'roms/u-boot-sam460ex': checked out '60b3916f33e617a815973c5a6df77055b2e3a588'
Cloning into 'tests/fp/berkeley-softfloat-3'...
Submodule path 'tests/fp/berkeley-softfloat-3': checked out 'b64af41c3276f97f0e181920400ee056b9c88037'
Cloning into 'tests/fp/berkeley-testfloat-3'...
Submodule path 'tests/fp/berkeley-testfloat-3': checked out '5a59dcec19327396a011a17fd924aed4fec416b3'
Cloning into 'ui/keycodemapdb'...
Submodule path 'ui/keycodemapdb': checked out '6b3d716e2b6472eb7189d3220552280ef3d832ce'
Switched to a new branch 'test'
9f22048 block/nbd-client: rename read_reply_co to connection_co
e81ab27 block/nbd-client: don't check ioc
ce55b4b block/nbd-client: fix nbd_reply_chunk_iter_receive
80c093f block/nbd-client: split connection from initialization
a24543e block/nbd: move connection code from block/nbd to block/nbd-client
467a28d block/nbd-client: split channel errors from export errors
bd906b0 nbd: generalize usage of nbd_read
3d3be1f qemu-nbd: Deprecate qemu-nbd --partition
=== OUTPUT BEGIN ===
1/8 Checking commit 3d3be1f9bcc8 (qemu-nbd: Deprecate qemu-nbd --partition)
2/8 Checking commit bd906b01ffe8 (nbd: generalize usage of nbd_read)
ERROR: spaces required around that '*' (ctx:WxV)
#85: FILE: include/block/nbd.h:356:
+ uint##bits##_t *val, \
^
total: 1 errors, 0 warnings, 386 lines checked
Patch 2/8 has style problems, please review. If any of these errors
are false positives report them to the maintainer, see
CHECKPATCH in MAINTAINERS.
3/8 Checking commit 467a28dbf261 (block/nbd-client: split channel errors from export errors)
4/8 Checking commit a24543ee7b41 (block/nbd: move connection code from block/nbd to block/nbd-client)
5/8 Checking commit 80c093f3b180 (block/nbd-client: split connection from initialization)
6/8 Checking commit ce55b4b331f9 (block/nbd-client: fix nbd_reply_chunk_iter_receive)
7/8 Checking commit e81ab27f828e (block/nbd-client: don't check ioc)
8/8 Checking commit 9f22048c0a07 (block/nbd-client: rename read_reply_co to connection_co)
=== OUTPUT END ===
Test command exited with code: 1
The full log is available at
http://patchew.org/logs/20190205035704.26014-1-eblake@redhat.com/testing.checkpatch/?type=message.
---
Email generated automatically by Patchew [http://patchew.org/].
Please send your feedback to patchew-devel@redhat.com
On 2/4/19 10:08 PM, no-reply@patchew.org wrote: > Patchew URL: https://patchew.org/QEMU/20190205035704.26014-1-eblake@redhat.com/ > > > > Hi, > > This series seems to have some coding style problems. See output below for > more information: > > 2/8 Checking commit bd906b01ffe8 (nbd: generalize usage of nbd_read) > ERROR: spaces required around that '*' (ctx:WxV) > #85: FILE: include/block/nbd.h:356: > + uint##bits##_t *val, \ > ^ > > total: 1 errors, 0 warnings, 386 lines checked > > Patch 2/8 has style problems, please review. If any of these errors > are false positives report them to the maintainer, see > CHECKPATCH in MAINTAINERS. False positive. Seeing past ## pasting in a macro is not trivial to fix in checkpatch, so I'm intentionally ignoring this one.
On Tue, 5 Feb 2019 at 03:58, Eric Blake <eblake@redhat.com> wrote: > > The following changes since commit 773c4a6228fd910556cee2d477ee56c591a30000: > > test-filter-mirror: pass UNIX domain socket through fd (2019-02-04 16:03:20 +0000) > > are available in the Git repository at: > > https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-02-04 > > for you to fetch changes up to bc5a03350c220698229e7d6929dd242d5d358345: > > block/nbd-client: rename read_reply_co to connection_co (2019-02-04 15:11:27 -0600) > > ---------------------------------------------------------------- > nbd patches for 2019-02-04 > > - deprecate 'qemu-nbd --partition' > - preparation for NBD reconnect, including better logging of read errors > > ---------------------------------------------------------------- Applied, thanks. Please update the changelog at https://wiki.qemu.org/ChangeLog/4.0 for any user-visible changes. -- PMM
The following changes since commit 773c4a6228fd910556cee2d477ee56c591a30000: test-filter-mirror: pass UNIX domain socket through fd (2019-02-04 16:03:20 +0000) are available in the Git repository at: https://repo.or.cz/qemu/ericb.git tags/pull-nbd-2019-02-04 for you to fetch changes up to bc5a03350c220698229e7d6929dd242d5d358345: block/nbd-client: rename read_reply_co to connection_co (2019-02-04 15:11:27 -0600) ---------------------------------------------------------------- nbd patches for 2019-02-04 - deprecate 'qemu-nbd --partition' - preparation for NBD reconnect, including better logging of read errors ---------------------------------------------------------------- Eric Blake (1): qemu-nbd: Deprecate qemu-nbd --partition Vladimir Sementsov-Ogievskiy (7): nbd: generalize usage of nbd_read block/nbd-client: split channel errors from export errors block/nbd: move connection code from block/nbd to block/nbd-client block/nbd-client: split connection from initialization block/nbd-client: fix nbd_reply_chunk_iter_receive block/nbd-client: don't check ioc block/nbd-client: rename read_reply_co to connection_co qemu-deprecated.texi | 33 +++++++++ qemu-nbd.texi | 6 +- block/nbd-client.h | 6 +- include/block/nbd.h | 32 ++++++++- block/nbd-client.c | 199 ++++++++++++++++++++++++++++++++------------------- block/nbd.c | 40 +---------- nbd/client.c | 88 ++++++++--------------- nbd/common.c | 2 +- nbd/server.c | 27 +++---- qemu-nbd.c | 2 + 10 files changed, 239 insertions(+), 196 deletions(-)