Patchwork [Bugme-new,Bug,38862] New: No support for DGE-530T Rev C1

login
register
mail settings
Submitter Andrew Morton
Date July 6, 2011, 9:54 p.m.
Message ID <20110706145407.7e06eece.akpm@linux-foundation.org>
Download mbox | patch
Permalink /patch/103581/
State RFC
Delegated to: David Miller
Headers show

Comments

Andrew Morton - July 6, 2011, 9:54 p.m.
On Wed, 6 Jul 2011 17:48:44 -0400
James Henderson <JamesHenderson@ruggedcom.com> wrote:

> > Did you test simply adding that device to the driver?
> >
> > --- a/drivers/net/skge.c~a
> > +++ a/drivers/net/skge.c
> > @@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T */
> > +	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) },	/* DGE-530T Rev C1 */
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
> >  	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },
> > _
> >
> >   
> No I haven't tested that change - I don't have a kernel development 
> environment setup and unfortunately I don't have any more work time to 
> budget to the issue beyond reporting it.
> 
> Also, I meant to say that Rev B2 has PCI id 1186:4B01 (although you seem 
> to have figured that out).

OK, I suppose we can add that info thusly:

Patch

--- a/drivers/net/skge.c~drivers-net-skgec-support-dlink-dge-530t-rev-c1
+++ a/drivers/net/skge.c
@@ -88,7 +88,8 @@  static DEFINE_PCI_DEVICE_TABLE(skge_id_t
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_GE) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) },
-	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) },	/* DGE-530T Rev B2 */
+	{ PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) },	/* DGE-530T Rev C1 */
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) },
 	{ PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */
 	{ PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },