From patchwork Wed Jul 6 21:37:09 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Andrew Morton X-Patchwork-Id: 103580 X-Patchwork-Delegate: davem@davemloft.net Return-Path: X-Original-To: patchwork-incoming@ozlabs.org Delivered-To: patchwork-incoming@ozlabs.org Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id F2650B6F64 for ; Thu, 7 Jul 2011 07:37:27 +1000 (EST) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755333Ab1GFVhR (ORCPT ); Wed, 6 Jul 2011 17:37:17 -0400 Received: from smtp1.linux-foundation.org ([140.211.169.13]:60085 "EHLO smtp1.linux-foundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1756325Ab1GFVhN (ORCPT ); Wed, 6 Jul 2011 17:37:13 -0400 Received: from imap1.linux-foundation.org (imap1.linux-foundation.org [140.211.169.55]) by smtp1.linux-foundation.org (8.14.2/8.13.5/Debian-3ubuntu1.1) with ESMTP id p66LbA2C024645 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Wed, 6 Jul 2011 14:37:10 -0700 Received: from akpm.mtv.corp.google.com (localhost [127.0.0.1]) by imap1.linux-foundation.org (8.13.5.20060308/8.13.5/Debian-3ubuntu1.1) with SMTP id p66Lb9gR000984; Wed, 6 Jul 2011 14:37:09 -0700 Date: Wed, 6 Jul 2011 14:37:09 -0700 From: Andrew Morton To: jameshenderson@ruggedcom.com Cc: bugme-daemon@bugzilla.kernel.org, netdev@vger.kernel.org, Stephen Hemminger Subject: Re: [Bugme-new] [Bug 38862] New: No support for DGE-530T Rev C1 Message-Id: <20110706143709.0f5ab7d6.akpm@linux-foundation.org> In-Reply-To: References: X-Mailer: Sylpheed 3.0.2 (GTK+ 2.20.1; x86_64-pc-linux-gnu) Mime-Version: 1.0 X-Spam-Status: No, hits=-103.476 required=5 tests=AWL, BAYES_00, OSDL_HEADER_SUBJECT_BRACKETED, USER_IN_WHITELIST X-Spam-Checker-Version: SpamAssassin 3.2.4-osdl_revision__1.47__ X-MIMEDefang-Filter: lf$Revision: 1.188 $ X-Scanned-By: MIMEDefang 2.63 on 140.211.169.13 Sender: netdev-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org (switched to email. Please respond via emailed reply-to-all, not via the bugzilla web interface). On Wed, 6 Jul 2011 16:05:36 GMT bugzilla-daemon@bugzilla.kernel.org wrote: > https://bugzilla.kernel.org/show_bug.cgi?id=38862 > > Summary: No support for DGE-530T Rev C1 > Product: Drivers > Version: 2.5 > Kernel Version: 2.6.39.2 > Platform: All > OS/Version: Linux > Tree: Mainline > Status: NEW > Severity: normal > Priority: P1 > Component: Network > AssignedTo: drivers_network@kernel-bugs.osdl.org > ReportedBy: jameshenderson@ruggedcom.com > Regression: No > > > The kernel support DGE-530T REV B2 through the skge driver. The PCI device id > of REV-B2 is 1186:4302. Rev C1 has a PCI device id of 1186:4302. No driver in > the current kernel supports this device id/vendor combination. Furthermore, > this device is not even listed in the device database -> > http://www.pcidatabase.com/vendor_details.php?id=921 . > > On the chip is the following information: > D-Link > DLG10028C > A8A34A1 > GA50 TAIWAN > > A sticker on the card reads: > DGE-530T Rev C1 > > I am including a picture I took of the card. > Did you test simply adding that device to the driver? --- a/drivers/net/skge.c~a +++ a/drivers/net/skge.c @@ -89,6 +89,7 @@ static DEFINE_PCI_DEVICE_TABLE(skge_id_t { PCI_DEVICE(PCI_VENDOR_ID_SYSKONNECT, PCI_DEVICE_ID_SYSKONNECT_YU) }, { PCI_DEVICE(PCI_VENDOR_ID_DLINK, PCI_DEVICE_ID_DLINK_DGE510T) }, { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4b01) }, /* DGE-530T */ + { PCI_DEVICE(PCI_VENDOR_ID_DLINK, 0x4302) }, /* DGE-530T Rev C1 */ { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x4320) }, { PCI_DEVICE(PCI_VENDOR_ID_MARVELL, 0x5005) }, /* Belkin */ { PCI_DEVICE(PCI_VENDOR_ID_CNET, PCI_DEVICE_ID_CNET_GIGACARD) },