| Message ID | 20190202235908.30751-1-linus.walleij@linaro.org |
|---|---|
| State | Changes Requested, archived |
| Headers | show |
| Series | [1/2] USB: gadget: pxa25x: Add DT bindings | expand |
| Context | Check | Description |
|---|---|---|
| robh/checkpatch | success |
On Sun, Feb 03, 2019 at 12:59:07AM +0100, Linus Walleij wrote: > This adds device tree bindings for the PXA25x USB Device > Controller as found in the PXA25x and the IXP4xx. > > Cc: Robert Jarzmik <robert.jarzmik@free.fr> > Cc: devicetree@vger.kernel.org > Signed-off-by: Linus Walleij <linus.walleij@linaro.org> > --- > .../devicetree/bindings/usb/pxa25x-udc.txt | 27 +++++++++++++++++++ > 1 file changed, 27 insertions(+) > create mode 100644 Documentation/devicetree/bindings/usb/pxa25x-udc.txt > > diff --git a/Documentation/devicetree/bindings/usb/pxa25x-udc.txt b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt > new file mode 100644 > index 000000000000..bbdbe0df3565 > --- /dev/null > +++ b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt > @@ -0,0 +1,27 @@ > +PXA25x UDC (USB Device Controller) > + > +The PXA25x and IXP4xx USB Device Controller is different from the > +PXA27x UDC described in pxa-usb.txt and is compatible between the > +Marvell PXA25x and the Intel IXP4xx devices. > + > +Required properties: > + - compatible: Should be one of > + "marvell,pxa25x-udc" Look at the 'has_cfr' flag in the driver. You should have 250 and 255 compatible strings to distinguish. That would get rid of the assembly instruction helping towards building on !ARM. > + "intel,ixp4xx-udc" > + for USB controllers used in device mode. > + - reg: usb device MMIO address space > + - interrupts: single interrupt generated by the UDC IP > + - clocks: input clock of the UDC IP (see clock-bindings.txt) > + > +Optional properties: > + - gpios: > + - gpio activated to control the USB D+ pullup (see gpio.txt) This really should be part of a connector. Also, the Lubbock board is different. > + > +Example: > + > +usb@c800b000 { > + compatible = "intel,ixp4xx-udc"; > + reg = <0xc800b000 0x1000>; > + interrupts = <12 IRQ_TYPE_LEVEL_HIGH>; > + clocks = <&pclk 0>; > +}; > -- > 2.20.1 >
diff --git a/Documentation/devicetree/bindings/usb/pxa25x-udc.txt b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt new file mode 100644 index 000000000000..bbdbe0df3565 --- /dev/null +++ b/Documentation/devicetree/bindings/usb/pxa25x-udc.txt @@ -0,0 +1,27 @@ +PXA25x UDC (USB Device Controller) + +The PXA25x and IXP4xx USB Device Controller is different from the +PXA27x UDC described in pxa-usb.txt and is compatible between the +Marvell PXA25x and the Intel IXP4xx devices. + +Required properties: + - compatible: Should be one of + "marvell,pxa25x-udc" + "intel,ixp4xx-udc" + for USB controllers used in device mode. + - reg: usb device MMIO address space + - interrupts: single interrupt generated by the UDC IP + - clocks: input clock of the UDC IP (see clock-bindings.txt) + +Optional properties: + - gpios: + - gpio activated to control the USB D+ pullup (see gpio.txt) + +Example: + +usb@c800b000 { + compatible = "intel,ixp4xx-udc"; + reg = <0xc800b000 0x1000>; + interrupts = <12 IRQ_TYPE_LEVEL_HIGH>; + clocks = <&pclk 0>; +};
This adds device tree bindings for the PXA25x USB Device Controller as found in the PXA25x and the IXP4xx. Cc: Robert Jarzmik <robert.jarzmik@free.fr> Cc: devicetree@vger.kernel.org Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- .../devicetree/bindings/usb/pxa25x-udc.txt | 27 +++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 Documentation/devicetree/bindings/usb/pxa25x-udc.txt