Patchwork [go] : Compile go checks with $(GOCFLAGS)

login
register
mail settings
Submitter Uros Bizjak
Date July 6, 2011, 5:30 p.m.
Message ID <CAFULd4aSiNDbSknTcBxbPSRO1QbHWg9kchPvx_4na5XdWjT5EA@mail.gmail.com>
Download mbox | patch
Permalink /patch/103553/
State New
Headers show

Comments

Uros Bizjak - July 6, 2011, 5:30 p.m.
Hello!

IMO, it makes sense to compile go tests with the same pack of flags as
the library. Additionally, this solves an issue with extra compile
flags (i.e. -mieee) that needs to be added to handle NaN/Inf.

Patch was tested on x86_64-pc-linux-gnu {, -m32} and
alphaev68-pc-linux-gnu (where the patch fixes all FPE related
testsuite failures due to missing -mieee flags).

Uros.
Ian Taylor - July 6, 2011, 7:52 p.m.
Uros Bizjak <ubizjak@gmail.com> writes:

> IMO, it makes sense to compile go tests with the same pack of flags as
> the library. Additionally, this solves an issue with extra compile
> flags (i.e. -mieee) that needs to be added to handle NaN/Inf.
>
> Patch was tested on x86_64-pc-linux-gnu {, -m32} and
> alphaev68-pc-linux-gnu (where the patch fixes all FPE related
> testsuite failures due to missing -mieee flags).

Approved and applied.

Thanks.

Ian

Patch

Index: Makefile.in
===================================================================
--- Makefile.in	(revision 175904)
+++ Makefile.in	(working copy)
@@ -1937,7 +1937,7 @@ 
 
 # Check a package.
 CHECK = \
-	GC="$(GOC) -L `${PWD_COMMAND}` -L `${PWD_COMMAND}`/.libs"; \
+	GC="$(GOC) $(GOCFLAGS) -L `${PWD_COMMAND}` -L `${PWD_COMMAND}`/.libs"; \
 	export GC; \
 	RUNTESTFLAGS="$(RUNTESTFLAGS)"; \
 	export RUNTESTFLAGS; \
Index: Makefile.am
===================================================================
--- Makefile.am	(revision 175904)
+++ Makefile.am	(working copy)
@@ -1619,7 +1619,7 @@ 
 
 # Check a package.
 CHECK = \
-	GC="$(GOC) -L `${PWD_COMMAND}` -L `${PWD_COMMAND}`/.libs"; \
+	GC="$(GOC) $(GOCFLAGS) -L `${PWD_COMMAND}` -L `${PWD_COMMAND}`/.libs"; \
 	export GC; \
 	RUNTESTFLAGS="$(RUNTESTFLAGS)"; \
 	export RUNTESTFLAGS; \