[rs6000] Correct dg directives on recently added vec-extract tests
diff mbox series

Message ID 64162b4f-b2fa-dbab-f36a-37886fb3b2d4@linux.ibm.com
State New
Headers show
Series
  • [rs6000] Correct dg directives on recently added vec-extract tests
Related show

Commit Message

Kelvin Nilsen Feb. 1, 2019, 8:58 p.m. UTC
Overnight regression testing revealed a portability problem with several recently installed tests.  The tests were observed to fail on a power7 test platform.

The tests, which are intended to execute, are compiled with -mcpu=power8.  Thus, they require power 8 hardware.

I have regression tested this on powerpc64-linux (P7 big-endian, both -m32 and -m64), both 32-bit and 64-bit.  Is this ok for trunk and for various backports to which the original patch is to be directed?

gcc/testsuite/ChangeLog:

2019-02-01  Kelvin Nilsen  <kelvin@gcc.gnu.org>

	* gcc.target/powerpc/vec-extract-slong-1.c: Require p8 execution
	hardware.
	* gcc.target/powerpc/vec-extract-schar-1.c: Likewise.
	* gcc.target/powerpc/vec-extract-sint128-1.c: Likewise.
	* gcc.target/powerpc/vec-extract-sshort-1.c: Likewise.
	* gcc.target/powerpc/vec-extract-ulong-1.c: Likewise.
	* gcc.target/powerpc/vec-extract-uchar-1.c: Likewise.
	* gcc.target/powerpc/vec-extract-sint-1.c: Likewise.
	* gcc.target/powerpc/vec-extract-uint128-1.c: Likewise.
	* gcc.target/powerpc/vec-extract-ushort-1.c: Likewise.
	* gcc.target/powerpc/vec-extract-uint-1.c: Likewise.

Comments

Segher Boessenkool Feb. 2, 2019, 11:09 p.m. UTC | #1
Hi!

On Fri, Feb 01, 2019 at 02:58:48PM -0600, Kelvin Nilsen wrote:
> Overnight regression testing revealed a portability problem with several recently installed tests.  The tests were observed to fail on a power7 test platform.
> 
> The tests, which are intended to execute, are compiled with -mcpu=power8.  Thus, they require power 8 hardware.
> 
> I have regression tested this on powerpc64-linux (P7 big-endian, both -m32 and -m64), both 32-bit and 64-bit.  Is this ok for trunk and for various backports to which the original patch is to be directed?

Okay for both trunk and relevant backports.  Thanks!


Segher


> 2019-02-01  Kelvin Nilsen  <kelvin@gcc.gnu.org>
> 
> 	* gcc.target/powerpc/vec-extract-slong-1.c: Require p8 execution
> 	hardware.
> 	* gcc.target/powerpc/vec-extract-schar-1.c: Likewise.
> 	* gcc.target/powerpc/vec-extract-sint128-1.c: Likewise.
> 	* gcc.target/powerpc/vec-extract-sshort-1.c: Likewise.
> 	* gcc.target/powerpc/vec-extract-ulong-1.c: Likewise.
> 	* gcc.target/powerpc/vec-extract-uchar-1.c: Likewise.
> 	* gcc.target/powerpc/vec-extract-sint-1.c: Likewise.
> 	* gcc.target/powerpc/vec-extract-uint128-1.c: Likewise.
> 	* gcc.target/powerpc/vec-extract-ushort-1.c: Likewise.
> 	* gcc.target/powerpc/vec-extract-uint-1.c: Likewise.

Patch
diff mbox series

Index: gcc/testsuite/gcc.target/powerpc/vec-extract-slong-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-slong-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-slong-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    signed longs remains signed.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-extract-schar-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-schar-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-schar-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    signed chars remains signed.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-extract-sint128-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-sint128-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-sint128-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    signed __int128s remains signed.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-extract-sshort-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-sshort-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-sshort-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    signed shorts remains signed.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-extract-ulong-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-ulong-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-ulong-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    unsigned longs remains unsigned.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-extract-uchar-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-uchar-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-uchar-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    unsigned chars remains unsigned.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-extract-sint-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-sint-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-sint-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    signed ints remains signed.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-extract-uint128-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-uint128-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-uint128-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    unsigned __int128s remains unsigned.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-extract-ushort-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-ushort-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-ushort-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    signed shorts remains signed.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>
Index: gcc/testsuite/gcc.target/powerpc/vec-extract-uint-1.c
===================================================================
--- gcc/testsuite/gcc.target/powerpc/vec-extract-uint-1.c	(revision 268424)
+++ gcc/testsuite/gcc.target/powerpc/vec-extract-uint-1.c	(working copy)
@@ -2,7 +2,7 @@ 
    unsigned ints remains unsigned.  */
 /* { dg-do run } */
 /* { dg-options "-ansi -mcpu=power8 " } */
-/* { dg-require-effective-target powerpc_p8vector_ok } */
+/* { dg-require-effective-target p8vector_hw } */
 /* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
 
 #include <altivec.h>