Patchwork [U-Boot] ARMv7: Add missing boards to MAKEALL

login
register
mail settings
Submitter Dirk Behme
Date July 6, 2011, 3:35 p.m.
Message ID <1309966526-4401-1-git-send-email-dirk.behme@gmail.com>
Download mbox | patch
Permalink /patch/103500/
State Rejected
Delegated to: Albert ARIBAUD
Headers show

Comments

Dirk Behme - July 6, 2011, 3:35 p.m.
From: Dirk Behme <dirk.behme@googlemail.com>

Add all missing boards with CPU==armv7 from boards.cfg
to MAKEALL.

Signed-off-by: Dirk Behme <dirk.behme@googlemail.com>

---
 MAKEALL |   12 ++++++++++++
 1 file changed, 12 insertions(+)
Albert ARIBAUD - Aug. 3, 2011, 2:43 p.m.
Hi Dirk,

On 06/07/2011 17:35, Dirk Behme wrote:
> From: Dirk Behme<dirk.behme@googlemail.com>
>
> Add all missing boards with CPU==armv7 from boards.cfg
> to MAKEALL.
>
> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
>
> ---
>   MAKEALL |   12 ++++++++++++
>   1 file changed, 12 insertions(+)
>
> Index: u-boot.git/MAKEALL
> ===================================================================
> --- u-boot.git.orig/MAKEALL
> +++ u-boot.git/MAKEALL
> @@ -423,11 +423,18 @@ LIST_ARMV7="		\
>   	am3517_crane		\
>   	am3517_evm		\
>   	ca9x4_ct_vxp		\
> +	cm_t35 			\
>   	devkit8000		\
>   	dig297			\
> +	efikamx			\
> +	harmony			\
>   	igep0020		\
>   	igep0030		\
>   	mx51evk			\
> +	mx53ard			\
> +	mx53evk			\
> +	mx53loco		\
> +	mx53smd			\
>   	omap3_beagle		\
>   	omap3_overo		\
>   	omap3_evm		\
> @@ -437,8 +444,13 @@ LIST_ARMV7="		\
>   	omap3_zoom2		\
>   	omap4_panda		\
>   	omap4_sdp4430		\
> +	s5pc210_universal	\
>   	s5p_goni		\
> +	seaboard		\
>   	smdkc100		\
> +	smdkv310		\
> +	u8500_href		\
> +	vision2			\
>   "
>
>   #########################################################################
> _______________________________________________
> U-Boot mailing list
> U-Boot@lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>
Applied to u-boot-arm/master, thanks.

This raises the number of boards built / built with errors or warnings 
from 201 / 97 to 213 / 100 -- which means three of these new boards do 
not build cleanly: cm_t53 and smdkv310 fail building with errors, and 
u8500 has warnings.

The boards which are still in error at the time of the release will be 
removed by way of an additional patch above Wolfgang's 'card deck' of 52 
board removal patches (well actually less than 52 now since several 
boards have been made to build since).

Amicalement,
Albert ARIBAUD - Aug. 3, 2011, 2:49 p.m.
On 03/08/2011 16:43, Albert ARIBAUD wrote:
> Hi Dirk,
>
> On 06/07/2011 17:35, Dirk Behme wrote:
>> From: Dirk Behme<dirk.behme@googlemail.com>
>>
>> Add all missing boards with CPU==armv7 from boards.cfg
>> to MAKEALL.
>>
>> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
>>
>> ---
>> MAKEALL | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> Index: u-boot.git/MAKEALL
>> ===================================================================
>> --- u-boot.git.orig/MAKEALL
>> +++ u-boot.git/MAKEALL
>> @@ -423,11 +423,18 @@ LIST_ARMV7=" \
>> am3517_crane \
>> am3517_evm \
>> ca9x4_ct_vxp \
>> + cm_t35 \
>> devkit8000 \
>> dig297 \
>> + efikamx \
>> + harmony \
>> igep0020 \
>> igep0030 \
>> mx51evk \
>> + mx53ard \
>> + mx53evk \
>> + mx53loco \
>> + mx53smd \
>> omap3_beagle \
>> omap3_overo \
>> omap3_evm \
>> @@ -437,8 +444,13 @@ LIST_ARMV7=" \
>> omap3_zoom2 \
>> omap4_panda \
>> omap4_sdp4430 \
>> + s5pc210_universal \
>> s5p_goni \
>> + seaboard \
>> smdkc100 \
>> + smdkv310 \
>> + u8500_href \
>> + vision2 \
>> "
>>
>> #########################################################################
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>>
> Applied to u-boot-arm/master, thanks.
>
> This raises the number of boards built / built with errors or warnings
> from 201 / 97 to 213 / 100 -- which means three of these new boards do
> not build cleanly: cm_t53 and smdkv310 fail building with errors, and
> u8500 has warnings.
>
> The boards which are still in error at the time of the release will be
> removed by way of an additional patch above Wolfgang's 'card deck' of 52
> board removal patches (well actually less than 52 now since several
> boards have been made to build since).

After Reinhard's remark on boards.cfg vs MAKEALL, I may have accepted 
the patch a bit hastily. All of these boards are already in boards.cfg, 
and need not be in makeall IIUC.

Thus, I am rolling back master one notch and will mark the patch as 
Supersedes (could not find a better match for "not needed any more")

Amicalement,
Albert ARIBAUD - Aug. 3, 2011, 2:53 p.m.
On 03/08/2011 16:49, Albert ARIBAUD wrote:
> On 03/08/2011 16:43, Albert ARIBAUD wrote:
>> Hi Dirk,
>>
>> On 06/07/2011 17:35, Dirk Behme wrote:
>>> From: Dirk Behme<dirk.behme@googlemail.com>
>>>
>>> Add all missing boards with CPU==armv7 from boards.cfg
>>> to MAKEALL.
>>>
>>> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
>>>
>>> ---
>>> MAKEALL | 12 ++++++++++++
>>> 1 file changed, 12 insertions(+)
>>>
>>> Index: u-boot.git/MAKEALL
>>> ===================================================================
>>> --- u-boot.git.orig/MAKEALL
>>> +++ u-boot.git/MAKEALL
>>> @@ -423,11 +423,18 @@ LIST_ARMV7=" \
>>> am3517_crane \
>>> am3517_evm \
>>> ca9x4_ct_vxp \
>>> + cm_t35 \
>>> devkit8000 \
>>> dig297 \
>>> + efikamx \
>>> + harmony \
>>> igep0020 \
>>> igep0030 \
>>> mx51evk \
>>> + mx53ard \
>>> + mx53evk \
>>> + mx53loco \
>>> + mx53smd \
>>> omap3_beagle \
>>> omap3_overo \
>>> omap3_evm \
>>> @@ -437,8 +444,13 @@ LIST_ARMV7=" \
>>> omap3_zoom2 \
>>> omap4_panda \
>>> omap4_sdp4430 \
>>> + s5pc210_universal \
>>> s5p_goni \
>>> + seaboard \
>>> smdkc100 \
>>> + smdkv310 \
>>> + u8500_href \
>>> + vision2 \
>>> "
>>>
>>> #########################################################################
>>>
>>> _______________________________________________
>>> U-Boot mailing list
>>> U-Boot@lists.denx.de
>>> http://lists.denx.de/mailman/listinfo/u-boot
>>>
>>>
>> Applied to u-boot-arm/master, thanks.
>>
>> This raises the number of boards built / built with errors or warnings
>> from 201 / 97 to 213 / 100 -- which means three of these new boards do
>> not build cleanly: cm_t53 and smdkv310 fail building with errors, and
>> u8500 has warnings.
>>
>> The boards which are still in error at the time of the release will be
>> removed by way of an additional patch above Wolfgang's 'card deck' of 52
>> board removal patches (well actually less than 52 now since several
>> boards have been made to build since).
>
> After Reinhard's remark on boards.cfg vs MAKEALL, I may have accepted
> the patch a bit hastily. All of these boards are already in boards.cfg,
> and need not be in makeall IIUC.
>
> Thus, I am rolling back master one notch and will mark the patch as
> Supersedes (could not find a better match for "not needed any more")

... or not: here, adding this patch should have resulted in 12 more 
boards built and 12 more boards failing to build, but actuelly 9 succeed.

Reinhard, are you sure that boards that are in boards.cfg *and* in 
MAKEALL will fail to build? This is not consistent with what I see here 
with this patch.

Amicalement,
Dirk Behme - Aug. 3, 2011, 2:56 p.m.
On 03.08.2011 16:43, Albert ARIBAUD wrote:
> Hi Dirk,
>
> On 06/07/2011 17:35, Dirk Behme wrote:
>> From: Dirk Behme<dirk.behme@googlemail.com>
>>
>> Add all missing boards with CPU==armv7 from boards.cfg
>> to MAKEALL.
>>
>> Signed-off-by: Dirk Behme<dirk.behme@googlemail.com>
>>
>> ---
>> MAKEALL | 12 ++++++++++++
>> 1 file changed, 12 insertions(+)
>>
>> Index: u-boot.git/MAKEALL
>> ===================================================================
>> --- u-boot.git.orig/MAKEALL
>> +++ u-boot.git/MAKEALL
>> @@ -423,11 +423,18 @@ LIST_ARMV7=" \
>> am3517_crane \
>> am3517_evm \
>> ca9x4_ct_vxp \
>> + cm_t35 \
>> devkit8000 \
>> dig297 \
>> + efikamx \
>> + harmony \
>> igep0020 \
>> igep0030 \
>> mx51evk \
>> + mx53ard \
>> + mx53evk \
>> + mx53loco \
>> + mx53smd \
>> omap3_beagle \
>> omap3_overo \
>> omap3_evm \
>> @@ -437,8 +444,13 @@ LIST_ARMV7=" \
>> omap3_zoom2 \
>> omap4_panda \
>> omap4_sdp4430 \
>> + s5pc210_universal \
>> s5p_goni \
>> + seaboard \
>> smdkc100 \
>> + smdkv310 \
>> + u8500_href \
>> + vision2 \
>> "
>>
>> #########################################################################
>>
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot@lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>>
> Applied to u-boot-arm/master, thanks.
>
> This raises the number of boards built / built with errors or warnings
> from 201 / 97 to 213 / 100 -- which means three of these new boards do
> not build cleanly: cm_t53

I have to look for cm_t53. Maybe this is new? I can't remember that I 
saw that while testing this patch.

> and smdkv310

http://lists.denx.de/pipermail/u-boot/2011-July/095959.html

> fail building with errors, and
> u8500

http://lists.denx.de/pipermail/u-boot/2011-July/095791.html

Best regards

Dirk

> The boards which are still in error at the time of the release will be
> removed by way of an additional patch above Wolfgang's 'card deck' of
> 52 board removal patches (well actually less than 52 now since several
> boards have been made to build since).
>
> Amicalement,
Reinhard Meyer - Aug. 3, 2011, 3:49 p.m.
Dear Albert,
> > After Reinhard's remark on boards.cfg vs MAKEALL, I may have accepted
> > the patch a bit hastily. All of these boards are already in boards.cfg,
> > and need not be in makeall IIUC.
> >
> > Thus, I am rolling back master one notch and will mark the patch as
> > Supersedes (could not find a better match for "not needed any more")
> 
> ... or not: here, adding this patch should have resulted in 12 more 
> boards built and 12 more boards failing to build, but actuelly 9 succeed.
> 
> Reinhard, are you sure that boards that are in boards.cfg *and* in 
> MAKEALL will fail to build? This is not consistent with what I see here 
> with this patch.

When at91sam9261 was still in MAKEALL, it did build clean (no errors or
warnings), but the report at the end of a MAKEALL run had it in the list
of boards with problems. After removing it from MAKEALL the effect was
gone. I also noticed that it was not build twice, as one might expect.

Maybe the effect was only there with an explicit "MAKEALL at91", I don't
know - and its not worth to experiment there :)

On any account, however, boards in boards.cfg are automatically included
in a MAKEALL run.

Best Regards,
Reinhard
Wolfgang Denk - Aug. 3, 2011, 7:12 p.m.
Dear Albert ARIBAUD,

In message <4E395E7A.3020402@aribaud.net> you wrote:
> Hi Dirk,
> 
> On 06/07/2011 17:35, Dirk Behme wrote:
> > From: Dirk Behme<dirk.behme@googlemail.com>
> >
> > Add all missing boards with CPU==armv7 from boards.cfg
> > to MAKEALL.
...
> Applied to u-boot-arm/master, thanks.

Oh no, please not!

We do not add any boards to MAKEALL any more.  boards.cfg is the only
and ultimate place to add a board.  MAKEALL automatically pickt it up
there.

If you also add it to MAKEAL, you will build it TWICE.

Please undo.

Best regards,

Wolfgang Denk
Wolfgang Denk - Aug. 3, 2011, 7:13 p.m.
Dear Dirk Behme,

In message <1309966526-4401-1-git-send-email-dirk.behme@gmail.com> you wrote:
> 
> Add all missing boards with CPU==armv7 from boards.cfg
> to MAKEALL.

NAK.

We don't add boards to MAKEALL any more.  An entry in boards.cfg is
all we need.

Best regards,

Wolfgang Denk
Wolfgang Denk - Aug. 3, 2011, 7:15 p.m.
Dear Albert ARIBAUD,

In message <4E3960EA.9050406@aribaud.net> you wrote:
>
> Reinhard, are you sure that boards that are in boards.cfg *and* in 
> MAKEALL will fail to build? This is not consistent with what I see here 
> with this patch.

They will be built twice - and both builds will either succeed or
fail, in teh very same way.

Best regards,

Wolfgang Denk
Albert ARIBAUD - Aug. 3, 2011, 7:21 p.m.
Le 03/08/2011 21:15, Wolfgang Denk a écrit :
> Dear Albert ARIBAUD,
>
> In message<4E3960EA.9050406@aribaud.net>  you wrote:
>>
>> Reinhard, are you sure that boards that are in boards.cfg *and* in
>> MAKEALL will fail to build? This is not consistent with what I see here
>> with this patch.
>
> They will be built twice - and both builds will either succeed or
> fail, in teh very same way.

Ok, so I'll rewind this commit.

> Best regards,
>
> Wolfgang Denk
>


Amicalement,
Albert ARIBAUD - Aug. 4, 2011, 8:43 a.m.
Hi Wolfgang,

On 03/08/2011 21:12, Wolfgang Denk wrote:
> Dear Albert ARIBAUD,
>
> In message<4E395E7A.3020402@aribaud.net>  you wrote:
>> Hi Dirk,
>>
>> On 06/07/2011 17:35, Dirk Behme wrote:
>>> From: Dirk Behme<dirk.behme@googlemail.com>
>>>
>>> Add all missing boards with CPU==armv7 from boards.cfg
>>> to MAKEALL.
> ...
>> Applied to u-boot-arm/master, thanks.
>
> Oh no, please not!
>
> We do not add any boards to MAKEALL any more.  boards.cfg is the only
> and ultimate place to add a board.  MAKEALL automatically pickt it up
> there.

Already rolled back and marked rejected, as per the rest of the thread.

Amicalement,

Patch

Index: u-boot.git/MAKEALL
===================================================================
--- u-boot.git.orig/MAKEALL
+++ u-boot.git/MAKEALL
@@ -423,11 +423,18 @@  LIST_ARMV7="		\
 	am3517_crane		\
 	am3517_evm		\
 	ca9x4_ct_vxp		\
+	cm_t35 			\
 	devkit8000		\
 	dig297			\
+	efikamx			\
+	harmony			\
 	igep0020		\
 	igep0030		\
 	mx51evk			\
+	mx53ard			\
+	mx53evk			\
+	mx53loco		\
+	mx53smd			\
 	omap3_beagle		\
 	omap3_overo		\
 	omap3_evm		\
@@ -437,8 +444,13 @@  LIST_ARMV7="		\
 	omap3_zoom2		\
 	omap4_panda		\
 	omap4_sdp4430		\
+	s5pc210_universal	\
 	s5p_goni		\
+	seaboard		\
 	smdkc100		\
+	smdkv310		\
+	u8500_href		\
+	vision2			\
 "
 
 #########################################################################