Patchwork Fix configure --with-cloog

login
register
mail settings
Submitter Romain Geissler
Date July 6, 2011, 12:40 p.m.
Message ID <CAF+LTedFP8xKrrd8WX+NfRtqTnT6X1SkoUTmR-nMEewesCKPEQ@mail.gmail.com>
Download mbox | patch
Permalink /patch/103465/
State New
Headers show

Comments

Romain Geissler - July 6, 2011, 12:40 p.m.
> Hello
>
> This patch fix an issue while building with cloog and gmp installed in
> a custom separate directories.
>
> How to reproduce :
>  - Make sure you've installed cloog and gmp in separate directories
> (ie ${WITH-CLOOG-PATH}/lib doesn't contain libgmp)
>  - Make sure neither gmp nor cloog is not installed in a directory
> searched by default by your linker when looking for libs.
>  - Launch configure script with both --with-gmp and --with-cloog
> switch properly set
>
> This result in an unexpected error while configuring: error: Unable to
> find a usable CLooG.
>
>
> 2011-07-06  Romain Geissler  <romain.geissler@gmail.com>
>
>       * configure: Add $gmplibs to cloog $LDFLAGS
>
> Index: configure
> ===================================================================
> --- configure   (revision 175709)
> +++ configure   (working copy)
> @@ -5713,7 +5713,7 @@ if test "x$with_cloog" != "xno"; then
>
>     CFLAGS="${CFLAGS} ${clooginc} ${gmpinc}"
>   CPPFLAGS="${CPPFLAGS} ${_cloogorginc}"
> -  LDFLAGS="${LDFLAGS} ${clooglibs}"
> +  LDFLAGS="${LDFLAGS} ${clooglibs} ${gmplibs}"
>
>   case $cloog_backend in
>     "ppl-legacy")
>

I forgot configure was a generated script. Here is the patch that fix
it at the m4 macro level :


2011-07-06  Romain Geissler  <romain.geissler@gmail.com>

      * config/cloog.m4: Add $gmplibs to cloog $LDFLAGS
      * configure: Regenerate
Romain Geissler - July 11, 2011, 7:48 a.m.
2011/7/6 Romain Geissler <romain.geissler@gmail.com>:
>
> I forgot configure was a generated script. Here is the patch that fix
> it at the m4 macro level :
>
>
> 2011-07-06  Romain Geissler  <romain.geissler@gmail.com>
>
>      * config/cloog.m4: Add $gmplibs to cloog $LDFLAGS
>      * configure: Regenerate
>
>
> Index: config/cloog.m4
> ===================================================================
> --- config/cloog.m4     (revision 175907)
> +++ config/cloog.m4     (working copy)
> @@ -142,7 +142,7 @@ AC_DEFUN([CLOOG_FIND_FLAGS],
>   dnl clooglibs & clooginc may have been initialized by CLOOG_INIT_FLAGS.
>   CFLAGS="${CFLAGS} ${clooginc} ${gmpinc}"
>   CPPFLAGS="${CPPFLAGS} ${_cloogorginc}"
> -  LDFLAGS="${LDFLAGS} ${clooglibs}"
> +  LDFLAGS="${LDFLAGS} ${clooglibs} ${gmplibs}"
>
>   case $cloog_backend in
>     "ppl-legacy")
>

Ping: It seems that little patch has been forgotten.
Is ok for the trunk ?

NB: I don't have write access to the trunk

Romain Geissler
Romain Geissler - July 18, 2011, 7:04 a.m.
2011/7/11 Romain Geissler <romain.geissler@gmail.com>:
> 2011/7/6 Romain Geissler <romain.geissler@gmail.com>:
>>
>> I forgot configure was a generated script. Here is the patch that fix
>> it at the m4 macro level :
>>
>>
>> 2011-07-06  Romain Geissler  <romain.geissler@gmail.com>
>>
>>      * config/cloog.m4: Add $gmplibs to cloog $LDFLAGS
>>      * configure: Regenerate
>>
>>
>> Index: config/cloog.m4
>> ===================================================================
>> --- config/cloog.m4     (revision 175907)
>> +++ config/cloog.m4     (working copy)
>> @@ -142,7 +142,7 @@ AC_DEFUN([CLOOG_FIND_FLAGS],
>>   dnl clooglibs & clooginc may have been initialized by CLOOG_INIT_FLAGS.
>>   CFLAGS="${CFLAGS} ${clooginc} ${gmpinc}"
>>   CPPFLAGS="${CPPFLAGS} ${_cloogorginc}"
>> -  LDFLAGS="${LDFLAGS} ${clooglibs}"
>> +  LDFLAGS="${LDFLAGS} ${clooglibs} ${gmplibs}"
>>
>>   case $cloog_backend in
>>     "ppl-legacy")
>>
>
> Ping: It seems that little patch has been forgotten.
> Is ok for the trunk ?
>
> NB: I don't have write access to the trunk
>
> Romain Geissler
>

Ping !

Patch

Index: config/cloog.m4
===================================================================
--- config/cloog.m4     (revision 175907)
+++ config/cloog.m4     (working copy)
@@ -142,7 +142,7 @@  AC_DEFUN([CLOOG_FIND_FLAGS],
   dnl clooglibs & clooginc may have been initialized by CLOOG_INIT_FLAGS.
   CFLAGS="${CFLAGS} ${clooginc} ${gmpinc}"
   CPPFLAGS="${CPPFLAGS} ${_cloogorginc}"
-  LDFLAGS="${LDFLAGS} ${clooglibs}"
+  LDFLAGS="${LDFLAGS} ${clooglibs} ${gmplibs}"

   case $cloog_backend in
     "ppl-legacy")