[v2,6/6] Update DEVELOPERS.
diff mbox series

Message ID 20190131121526.11816-7-lpdev@cordier.org
State Changes Requested
Headers show
Series
  • *** Add Intel QuickSync support to ffmpeg ***
Related show

Commit Message

Louis-Paul Cordier Jan. 31, 2019, 12:15 p.m. UTC
Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
---
 DEVELOPERS | 5 +++++
 1 file changed, 5 insertions(+)

Comments

Thomas Petazzoni Feb. 2, 2019, 2:47 p.m. UTC | #1
Hello Louis-Paul,

Thanks for working on this topic. A few minor/silly comments below.

On Thu, 31 Jan 2019 13:15:26 +0100
Louis-Paul Cordier <lpdev@cordier.org> wrote:

> Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
> ---
>  DEVELOPERS | 5 +++++
>  1 file changed, 5 insertions(+)
> 
> diff --git a/DEVELOPERS b/DEVELOPERS
> index c1950bb0f4..dfe7bd67c0 100644
> --- a/DEVELOPERS
> +++ b/DEVELOPERS
> @@ -1262,6 +1262,11 @@ F:	package/ti-sgx-demos/
>  F:	package/ti-sgx-km/
>  F:	package/ti-sgx-um/
>  
> +N:  Louis-Paul Cordier <lpdev@cordier.org>
> +F:  package/intel-gmmlib
> +F:  package/intel-mediadriver
> +F:  package/intel-mediasdk

Indentation is not correct, please follow the indentation style used in
the rest of the file.

Also, the update to the DEVELOPERS file should be done within the
patches adding the packages. So the patch adding intel-gmmlib should
update the DEVELOPERS file for intel-gmmlib, and so on for
intel-mediadriver and intel-mediasdk.

Final nit: don't put a final dot in commit titles.

Thanks!

Thomas
Louis-Paul Cordier Feb. 4, 2019, 9:11 a.m. UTC | #2
Hello Thomas,

First of all, thank you for taking the time to review this serie of patches.

>De : Thomas Petazzoni <thomas.petazzoni@bootlin.com>
>À : Louis-Paul Cordier <lpdev@cordier.org>
>Sujet : Re: [Buildroot] [PATCH v2 6/6] Update DEVELOPERS.
>Date : 02/02/2019 15:47:22 Europe/Paris
>Copie à : buildroot@buildroot.org;
>   Bernd Kuhls <bernd.kuhls@t-online.de>;
>   MahyarKoshkouei <mahyar.koshkouei@gmail.com>
>
>Hello Louis-Paul,
>
>Thanks for working on this topic. A few minor/silly comments below.
>
>On Thu, 31 Jan 2019 13:15:26 +0100
>Louis-Paul Cordier <lpdev@cordier.org> wrote:
>
>> Signed-off-by: Louis-Paul Cordier <lpdev@cordier.org>
>> ---
>> DEVELOPERS | 5 +++++
>> 1 file changed, 5 insertions(+)
>> 
>> diff --git a/DEVELOPERS b/DEVELOPERS
>> index c1950bb0f4..dfe7bd67c0 100644
>> --- a/DEVELOPERS
>> +++ b/DEVELOPERS
>> @@ -1262,6 +1262,11 @@ F: package/ti-sgx-demos/
>> F: package/ti-sgx-km/
>> F: package/ti-sgx-um/
>> 
>> +N: Louis-Paul Cordier <lpdev@cordier.org>
>> +F: package/intel-gmmlib
>> +F: package/intel-mediadriver
>> +F: package/intel-mediasdk
>
>Indentation is not correct, please follow the indentation style used in
>the rest of the file.

My text editor trapped me on this.

>
>Also, the update to the DEVELOPERS file should be done within the
>patches adding the packages. So the patch adding intel-gmmlib should
>update the DEVELOPERS file for intel-gmmlib, and so on for
>intel-mediadriver and intel-mediasdk.
>
>Final nit: don't put a final dot in commit titles.

Copy that, thanks!

>
>Thanks!
>
>Thomas
>-- 
>Thomas Petazzoni, CTO, Bootlin
>Embedded Linux and Kernel engineering
>https://bootlin.com
Thomas Petazzoni Feb. 4, 2019, 9:43 a.m. UTC | #3
Hello,

On Mon,  4 Feb 2019 10:11:19 +0100 (CET)
lpdev@cordier.org wrote:

> First of all, thank you for taking the time to review this serie of patches.

I just applied your PATCH 1/6. For the rest, I'll mark as Changes
Requested, so if you could repost a new iteration, it would be good.

I believe the most difficult issue to solve is fixing the
gstreamer1/gst1-libav build issue with ffmpeg 4.x (see the discussion
with Bernd on this).

Thanks!

Thomas
Louis-Paul Cordier Feb. 4, 2019, 9:48 a.m. UTC | #4
> De : Thomas Petazzoni <thomas.petazzoni@bootlin.com>
> À : lpdev@cordier.org
> Sujet : Re: [Buildroot] [PATCH v2 6/6] Update DEVELOPERS.
> Date : 04/02/2019 10:43:00 Europe/Paris
> Copie à : Bernd Kuhls <bernd.kuhls@t-online.de>;
>    MahyarKoshkouei <mahyar.koshkouei@gmail.com>;
>    buildroot@buildroot.org
>
> Hello,
>
> On Mon, 4 Feb 2019 10:11:19 +0100 (CET)
> lpdev@cordier.org wrote:
>
> > First of all, thank you for taking the time to review this serie of patches.
>
> I just applied your PATCH 1/6. For the rest, I'll mark as Changes
> Requested, so if you could repost a new iteration, it would be good.
>
> I believe the most difficult issue to solve is fixing the
> gstreamer1/gst1-libav build issue with ffmpeg 4.x (see the discussion
> with Bernd on this).

I am affraid that I don't know gstreamer enough to review/fix this patch... Still, we can merge the other patches after the next iteration, I will temporary fork buildroot for ffmpeg4 then :(

>
> Thanks!
>
> Thomas
> -- 
> Thomas Petazzoni, CTO, Bootlin
> Embedded Linux and Kernel engineering
> https://bootlin.com

Patch
diff mbox series

diff --git a/DEVELOPERS b/DEVELOPERS
index c1950bb0f4..dfe7bd67c0 100644
--- a/DEVELOPERS
+++ b/DEVELOPERS
@@ -1262,6 +1262,11 @@  F:	package/ti-sgx-demos/
 F:	package/ti-sgx-km/
 F:	package/ti-sgx-um/
 
+N:  Louis-Paul Cordier <lpdev@cordier.org>
+F:  package/intel-gmmlib
+F:  package/intel-mediadriver
+F:  package/intel-mediasdk
+
 N:	Luca Ceresoli <luca@lucaceresoli.net>
 F:	board/olimex/a20_olinuxino/
 F:	board/zynq/