From patchwork Thu Jan 31 02:27:49 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joseph Lo X-Patchwork-Id: 1033882 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=pass (p=none dis=none) header.from=nvidia.com Authentication-Results: ozlabs.org; dkim=pass (2048-bit key; unprotected) header.d=nvidia.com header.i=@nvidia.com header.b="O8lh3s3K"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43qkfm2wgqz9sBb for ; Thu, 31 Jan 2019 13:28:00 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727861AbfAaC17 (ORCPT ); Wed, 30 Jan 2019 21:27:59 -0500 Received: from hqemgate15.nvidia.com ([216.228.121.64]:8917 "EHLO hqemgate15.nvidia.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725535AbfAaC17 (ORCPT ); Wed, 30 Jan 2019 21:27:59 -0500 Received: from hqpgpgate101.nvidia.com (Not Verified[216.228.121.13]) by hqemgate15.nvidia.com (using TLS: TLSv1.2, DES-CBC3-SHA) id ; Wed, 30 Jan 2019 18:27:30 -0800 Received: from hqmail.nvidia.com ([172.20.161.6]) by hqpgpgate101.nvidia.com (PGP Universal service); Wed, 30 Jan 2019 18:27:58 -0800 X-PGP-Universal: processed; by hqpgpgate101.nvidia.com on Wed, 30 Jan 2019 18:27:58 -0800 Received: from HQMAIL105.nvidia.com (172.20.187.12) by HQMAIL103.nvidia.com (172.20.187.11) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 31 Jan 2019 02:27:58 +0000 Received: from hqnvemgw02.nvidia.com (172.16.227.111) by HQMAIL105.nvidia.com (172.20.187.12) with Microsoft SMTP Server (TLS) id 15.0.1395.4 via Frontend Transport; Thu, 31 Jan 2019 02:27:58 +0000 Received: from josephl-linux.nvidia.com (Not Verified[10.19.108.132]) by hqnvemgw02.nvidia.com with Trustwave SEG (v7, 5, 8, 10121) id ; Wed, 30 Jan 2019 18:27:58 -0800 From: Joseph Lo To: "Rafael J . Wysocki" , Daniel Lezcano CC: , , , Joseph Lo Subject: [PATCH] cpuidle: dt: bail out if the idle-state DT node is not compatible Date: Thu, 31 Jan 2019 10:27:49 +0800 Message-ID: <20190131022749.19046-1-josephl@nvidia.com> X-Mailer: git-send-email 2.20.1 MIME-Version: 1.0 X-NVConfidentiality: public DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=nvidia.com; s=n1; t=1548901650; bh=K/Sn/R96/V9UvB/oooNtf+xhwMY4u/ll78TrSAWn144=; h=X-PGP-Universal:From:To:CC:Subject:Date:Message-ID:X-Mailer: MIME-Version:X-NVConfidentiality:Content-Transfer-Encoding: Content-Type; b=O8lh3s3Kwn2uoeVfl2/HJLf7w3gH5/vpq4ZQN0xlxuvd5EznFp0O6akC+cHtwkUSE UYugE0aXFvugYeKdUdppD299Vr8uRmUGpanMKL9F1/u1JnDI/GW1q/dZvNWfefEHQR S/6utw5p/3fY2zreMZh5xiJcGVdNWR35D6LyNWibypZyd7dyv6v1323wbdSgRWp3KO rTZQZyRFtnWcDAH+7Y8J+7Ac2XSawEW2TMb83EL1mEs/0Iw3RmDxm0v59nyRdUuWQc XXL+mRhI4uIFUYzMKzxuvOF5y4KdhfJNiEsQ7se916fM3c6RUZ08mPmujNyLv8yxQr X2rShz40dqYwA== Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Currently, the DT of the idle states will be parsed first whether it's compatible or not. This could cause a warning message that comes from if the CPU doesn't support identical idle states. E.g. Tegra186 can run with 2 Cortex-A57 and 2 Denver cores with different idle states on different types of these cores. We fix it to check the compatible string before the parsing procedures. So it can make sure it only goes through the idle states that the CPU supported. Signed-off-by: Joseph Lo --- drivers/cpuidle/dt_idle_states.c | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/drivers/cpuidle/dt_idle_states.c b/drivers/cpuidle/dt_idle_states.c index 53342b7f1010..4a528908abb3 100644 --- a/drivers/cpuidle/dt_idle_states.c +++ b/drivers/cpuidle/dt_idle_states.c @@ -180,6 +180,11 @@ int dt_init_idle_driver(struct cpuidle_driver *drv, if (!state_node) break; + if (!of_device_is_compatible(state_node, matches->compatible)) { + err = -EINVAL; + break; + } + if (!of_device_is_available(state_node)) { of_node_put(state_node); continue;