From patchwork Wed Jan 30 09:10:26 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: AceLan Kao X-Patchwork-Id: 1033367 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=lists.ubuntu.com (client-ip=91.189.94.19; helo=huckleberry.canonical.com; envelope-from=kernel-team-bounces@lists.ubuntu.com; receiver=) Authentication-Results: ozlabs.org; dmarc=fail (p=none dis=none) header.from=canonical.com Authentication-Results: ozlabs.org; dkim=fail reason="signature verification failed" (2048-bit key; unprotected) header.d=gmail.com header.i=@gmail.com header.b="uagasNvt"; dkim-atps=neutral Received: from huckleberry.canonical.com (huckleberry.canonical.com [91.189.94.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by ozlabs.org (Postfix) with ESMTPS id 43qHf06g81z9s9h; Wed, 30 Jan 2019 20:10:48 +1100 (AEDT) Received: from localhost ([127.0.0.1] helo=huckleberry.canonical.com) by huckleberry.canonical.com with esmtp (Exim 4.86_2) (envelope-from ) id 1goltL-0005JV-Up; Wed, 30 Jan 2019 09:10:43 +0000 Received: from mail-pg1-f194.google.com ([209.85.215.194]) by huckleberry.canonical.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1goltJ-0005HK-Cx for kernel-team@lists.ubuntu.com; Wed, 30 Jan 2019 09:10:41 +0000 Received: by mail-pg1-f194.google.com with SMTP id g189so10080596pgc.5 for ; Wed, 30 Jan 2019 01:10:41 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:from:to:subject:date:message-id:in-reply-to:references; bh=RA+xib69xX40qyKhRKncf2vsUVPPXH0Umo2qLuVzZA8=; b=uagasNvtAdeUoRNO9bj/K/YgU4WoUuGiFBtHUtPNK1vIdWsswbA2dc7P4ZhQBo5ir3 HnRjweuYwLvnW1c3pCggf3TEDcDWScwIiQa476Ey65IqHC+YKb8VwamFb1O1/qvyVsRg YoLtoAJU8bmHHOjtSx+AiAxngDa2IrREGO5pVUab5XmjmQ0+mAcQL9jjKSZOwTp09q9u oVjeNxaPBmmXFHTN/pLP1u3EflzJX8xOobsLqx7HKJG70U87WItlNByewilC+TurWug6 zfpYJb3erWvHfi0pehA5tZvPKExcx2hTqpion+bPeNGHJHXtQz8NNGdw8slsnH4BOjDw TFTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:from:to:subject:date:message-id :in-reply-to:references; bh=RA+xib69xX40qyKhRKncf2vsUVPPXH0Umo2qLuVzZA8=; b=PHFOwjCdKQGpehoY6Tizj4GfwYRyVKzXFylIoUNyncDhROxKOtr3KnlyCS3bdAlOb+ 6uhKWKTak+ZCibC6UjsDJ+caA12QQL+TOk10YaHLFmib49YuN7r2/xhBUDdNMF1IgFqJ dPq/vctDOjbUAFaxD/o/qTOq87OAp532868WJ2j5f6sqpZ9DjWCz6RUbbczPvFxIIQTr oXkaH5LRKsImZm85Bfg5iX+MH+dbfXs+PjtGKMdpoNUYqFwjeaQO1c/+MncPbtcwBBjI zQcaIfQJwxkkxjRasbtG98VS8vKfdVDiIUSW6UHlJ2i7ggup3YCYfbbcgISzNaIcKnm9 5tQg== X-Gm-Message-State: AJcUukffYzqclkkLGO68pnuuYiFTf8a9NGo5nWnbO4HreucpzulryCDy IbxDhy1slR2Pb2Jk3RwwgD1GV/R13ck= X-Google-Smtp-Source: ALg8bN7szPWcq+FdNfcnBR6OdwOXJtx+5lm5rxOhlIVsttJOFnRRo+kfTNo2f7LDu3REg+MRD6rUrg== X-Received: by 2002:a63:d208:: with SMTP id a8mr26415582pgg.77.1548839439589; Wed, 30 Jan 2019 01:10:39 -0800 (PST) Received: from localhost (114-32-69-186.HINET-IP.hinet.net. [114.32.69.186]) by smtp.gmail.com with ESMTPSA id k24sm1731289pfj.13.2019.01.30.01.10.38 for (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 30 Jan 2019 01:10:38 -0800 (PST) From: AceLan Kao To: kernel-team@lists.ubuntu.com Subject: [PATCH 3/3][SRU][B][C][D] UBUNTU: SAUCE: platform/x86: dell-uart-backlight: add force parameter Date: Wed, 30 Jan 2019 17:10:26 +0800 Message-Id: <20190130091026.14290-4-acelan.kao@canonical.com> X-Mailer: git-send-email 2.17.1 In-Reply-To: <20190130091026.14290-1-acelan.kao@canonical.com> References: <20190130091026.14290-1-acelan.kao@canonical.com> X-BeenThere: kernel-team@lists.ubuntu.com X-Mailman-Version: 2.1.20 Precedence: list List-Id: Kernel team discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: kernel-team-bounces@lists.ubuntu.com Sender: "kernel-team" BugLink: https://bugs.launchpad.net/bugs/1813877 Add force parameter to force load the driver if the platform doesn't provide a working scalar status command. Signed-off-by: AceLan Kao --- drivers/platform/x86/dell-uart-backlight.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/drivers/platform/x86/dell-uart-backlight.c b/drivers/platform/x86/dell-uart-backlight.c index a1ec0067291f..f81fc01606d0 100644 --- a/drivers/platform/x86/dell-uart-backlight.c +++ b/drivers/platform/x86/dell-uart-backlight.c @@ -40,6 +40,10 @@ unsigned int (*io_serial_in)(struct uart_port *p, int offset); int (*uart_write)(struct tty_struct *tty, const unsigned char *buf, int count); int (*uart_chars_in_buffer)(struct tty_struct *tty); +static bool force; +module_param(force, bool, 0444); +MODULE_PARM_DESC(force, "load the driver regardless of the scalar status"); + static struct dell_uart_bl_cmd uart_cmd[] = { /* * Get Firmware Version: Tool uses this command to get firmware version. @@ -381,7 +385,7 @@ static int dell_uart_bl_add(struct acpi_device *dev) mutex_init(&dell_pdata->brightness_mutex); - if (!dell_uart_get_scalar_status(dell_pdata)) { + if (!force && !dell_uart_get_scalar_status(dell_pdata)) { pr_debug("Scalar is not in charge of brightness adjustment.\n"); kzfree(dell_pdata); return -1;