From patchwork Tue Jul 5 11:31:08 2011 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Feiran Zheng X-Patchwork-Id: 103264 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Received: from lists.gnu.org (lists.gnu.org [140.186.70.17]) (using TLSv1 with cipher AES256-SHA (256/256 bits)) (Client did not present a certificate) by ozlabs.org (Postfix) with ESMTPS id CAB32B6F6E for ; Tue, 5 Jul 2011 22:04:13 +1000 (EST) Received: from localhost ([::1]:41065 helo=lists.gnu.org) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qe4MK-0006K0-KT for incoming@patchwork.ozlabs.org; Tue, 05 Jul 2011 08:04:08 -0400 Received: from eggs.gnu.org ([140.186.70.92]:45097) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qe3rH-0006zZ-QW for qemu-devel@nongnu.org; Tue, 05 Jul 2011 07:32:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1Qe3rG-00020n-8L for qemu-devel@nongnu.org; Tue, 05 Jul 2011 07:32:03 -0400 Received: from mail-iy0-f173.google.com ([209.85.210.173]:32835) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1Qe3rF-0001zz-TI for qemu-devel@nongnu.org; Tue, 05 Jul 2011 07:32:02 -0400 Received: by mail-iy0-f173.google.com with SMTP id 3so5889555iyb.4 for ; Tue, 05 Jul 2011 04:32:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=gamma; h=from:to:cc:subject:date:message-id:x-mailer:in-reply-to:references; bh=nZOmmWexEhmDsne6bmFbx4WzSdsWcg9Edaf5/bGIYeA=; b=LrCRKKL9buuPWrxbPodSAHxtv++oHAwjzdCienrR1Wa1hPv023uEEf/HlRGkWCcBZr rHX1wQH+Vp0TaiJVG0pzeJhiDriMlqDaWZiMFaWZLQeNgiQWpjsO3bwC0wZRaLBt3PhU gaJDPg3OTnJ7GZrRgtqCpjjyLBXI6FPeeOA88= Received: by 10.42.166.3 with SMTP id m3mr8335260icy.113.1309865521497; Tue, 05 Jul 2011 04:32:01 -0700 (PDT) Received: from localhost.localdomain ([111.187.70.55]) by mx.google.com with ESMTPS id x13sm4194798ibh.67.2011.07.05.04.31.57 (version=TLSv1/SSLv3 cipher=OTHER); Tue, 05 Jul 2011 04:32:00 -0700 (PDT) From: Fam Zheng To: qemu-devel@nongnu.org Date: Tue, 5 Jul 2011 19:31:08 +0800 Message-Id: <1309865478-32766-3-git-send-email-famcool@gmail.com> X-Mailer: git-send-email 1.7.6 In-Reply-To: <1309865478-32766-1-git-send-email-famcool@gmail.com> References: <1309865478-32766-1-git-send-email-famcool@gmail.com> X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.6 (newer, 2) X-Received-From: 209.85.210.173 Cc: kwolf@redhat.com, Fam Zheng , hch@lst.de, stefanha@gmail.com Subject: [Qemu-devel] [PATCH v8 02/12] VMDK: bugfix, align offset to cluster in get_whole_cluster X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org Sender: qemu-devel-bounces+incoming=patchwork.ozlabs.org@nongnu.org In get_whole_cluster, the offset is not aligned to cluster when reading from backing_hd. When the first write to child is not at the cluster boundary, wrong address data from parent is copied to child. Signed-off-by: Fam Zheng --- block/vmdk.c | 8 +++++--- 1 files changed, 5 insertions(+), 3 deletions(-) diff --git a/block/vmdk.c b/block/vmdk.c index 3b78583..03a4619 100644 --- a/block/vmdk.c +++ b/block/vmdk.c @@ -514,21 +514,23 @@ static int get_whole_cluster(BlockDriverState *bs, /* 128 sectors * 512 bytes each = grain size 64KB */ uint8_t whole_grain[extent->cluster_sectors * 512]; - // we will be here if it's first write on non-exist grain(cluster). - // try to read from parent image, if exist + /* we will be here if it's first write on non-exist grain(cluster). + * try to read from parent image, if exist */ if (bs->backing_hd) { int ret; if (!vmdk_is_cid_valid(bs)) return -1; + /* floor offset to cluster */ + offset -= offset % (extent->cluster_sectors * 512); ret = bdrv_read(bs->backing_hd, offset >> 9, whole_grain, extent->cluster_sectors); if (ret < 0) { return -1; } - //Write grain only into the active image + /* Write grain only into the active image */ ret = bdrv_write(extent->file, cluster_offset, whole_grain, extent->cluster_sectors); if (ret < 0) {