Patchwork [testsuite] : Add require fopenmp as needed

login
register
mail settings
Submitter Georg-Johann Lay
Date July 5, 2011, 10:07 a.m.
Message ID <4E12E264.8090407@gjlay.de>
Download mbox | patch
Permalink /patch/103236/
State New
Headers show

Comments

Georg-Johann Lay - July 5, 2011, 10:07 a.m.
There is a testcase that fails if no openmp is available.

This patch fixed that.

CCed contributor.

Johann


	* gcc.dg/cpp/pragma-3.c: Add dg-require-effective-target fopenmp.
Mike Stump - July 5, 2011, 5:45 p.m.
On Jul 5, 2011, at 3:07 AM, Georg-Johann Lay wrote:
> There is a testcase that fails if no openmp is available.
> 
> This patch fixed that.
> 
> CCed contributor.

Not quite sure what this means.

So, on patches you want approval on, the custom is to ask Ok? so that we can quickly tell which need review.  If you think it qualifies under the obvious rule, typically these don't ask Ok?.

Anyway, I assume you'd like to get it approved so that you can check it in...

Ok.
Georg-Johann Lay - July 5, 2011, 5:59 p.m.
Mike Stump wrote:
> On Jul 5, 2011, at 3:07 AM, Georg-Johann Lay wrote:
>> There is a testcase that fails if no openmp is available.
>> 
>> This patch fixed that.
>> 
>> CCed contributor.
> 
> Not quite sure what this means.
> 
> So, on patches you want approval on, the custom is to ask Ok? so
> that we can quickly tell which need review.  If you think it

Ok, Thanks for pointing that out.

> qualifies under the obvious rule, typically these don't ask Ok?.
> 
> Anyway, I assume you'd like to get it approved so that you can
> check it in...
> 
> Ok.

Patch

Index: gcc.dg/cpp/pragma-3.c
===================================================================
--- gcc.dg/cpp/pragma-3.c	(revision 175811)
+++ gcc.dg/cpp/pragma-3.c	(working copy)
@@ -1,6 +1,7 @@ 
 /* 
    { dg-options "-fopenmp" }
    { dg-do preprocess }
+   { dg-require-effective-target fopenmp }
  */
 
 void foo (void)