Patchwork rtc-efi: fix section mismatch warning

login
register
mail settings
Submitter Jan Beulich
Date July 5, 2011, 7:52 a.m.
Message ID <4E12DEC8020000780004C1CE@nat28.tlf.novell.com>
Download mbox | patch
Permalink /patch/103208/
State New
Headers show

Comments

Jan Beulich - July 5, 2011, 7:52 a.m.
With the use of platform_driver_probe(), pre-initializing the .probe
member of struct platform_driver is superfluous. As it causes a section
mismtach warning from modpost, the initializer should be removed.

Signed-off-by: Jan Beulich <jbeulich@novell.com>

---
 drivers/rtc/rtc-efi.c |    1 -
 1 file changed, 1 deletion(-)
dann frazier - July 5, 2011, 5:07 p.m.
On Tue, Jul 05, 2011 at 08:52:08AM +0100, Jan Beulich wrote:
> With the use of platform_driver_probe(), pre-initializing the .probe
> member of struct platform_driver is superfluous. As it causes a section
> mismtach warning from modpost, the initializer should be removed.
> 
> Signed-off-by: Jan Beulich <jbeulich@novell.com>

Acked-by: dann frazier <dannf@dannf.org>

> ---
>  drivers/rtc/rtc-efi.c |    1 -
>  1 file changed, 1 deletion(-)
> 
> --- 3.0-rc6/drivers/rtc/rtc-efi.c
> +++ 3.0-rc6-EFI-RTC-probe/drivers/rtc/rtc-efi.c
> @@ -213,7 +213,6 @@ static struct platform_driver efi_rtc_dr
>  		.name = "rtc-efi",
>  		.owner = THIS_MODULE,
>  	},
> -	.probe = efi_rtc_probe,
>  	.remove = __exit_p(efi_rtc_remove),
>  };
>  
> 
> 
>

Patch

--- 3.0-rc6/drivers/rtc/rtc-efi.c
+++ 3.0-rc6-EFI-RTC-probe/drivers/rtc/rtc-efi.c
@@ -213,7 +213,6 @@  static struct platform_driver efi_rtc_dr
 		.name = "rtc-efi",
 		.owner = THIS_MODULE,
 	},
-	.probe = efi_rtc_probe,
 	.remove = __exit_p(efi_rtc_remove),
 };