Message ID | 20190128165333.3814-1-svens@stackframe.org |
---|---|
State | New |
Headers | show |
Series | target/hppa: fix setting registers via gdb | expand |
On 1/28/19 4:53 PM, Sven Schnelle wrote: > While doing 'set $pcoqh=0xf0000000' i triggered the assertion below. From looking > at the source, it looks like the argument order for deposit64() is wrong, and val > needs to be moved to the end. > > Signed-off-by: Sven Schnelle <svens@stackframe.org> Queued, thanks. r~
diff --git a/target/hppa/gdbstub.c b/target/hppa/gdbstub.c index e2e9c4d77f..3157a690f2 100644 --- a/target/hppa/gdbstub.c +++ b/target/hppa/gdbstub.c @@ -266,7 +266,7 @@ int hppa_cpu_gdb_write_register(CPUState *cs, uint8_t *mem_buf, int n) case 65 ... 127: { uint64_t *fr = &env->fr[(n - 64) / 2]; - *fr = deposit64(*fr, val, (n & 1 ? 0 : 32), 32); + *fr = deposit64(*fr, (n & 1 ? 0 : 32), 32, val); } break; default: