[OpenWrt-Devel] ath79: Remove NAND targets as no available drivers
diff mbox series

Message ID eb859404-cd9f-d340-7426-e3d58fa5d4cd@wagsky.com
State Superseded, archived
Headers show
Series
  • [OpenWrt-Devel] ath79: Remove NAND targets as no available drivers
Related show

Commit Message

Jeff Kletsky Jan. 28, 2019, 4:35 p.m. UTC
From 7bd39bc01d8b0a03e796268f06f99b5a65fc353a Mon Sep 17 00:00:00 2001
From: Jeff Kletsky <git-commits@allycomm.com>
Date: Mon, 28 Jan 2019 08:25:52 -0800
Subject: [PATCH] ath79: Remove NAND targets as no available drivers

At this time, there are no drivers for NAND flash for ath79.

Remove the only present ath79 NAND target, GL.iNet AR300M,
as it will not boot due to lack of a suitable NAND driver.

 From openwrt-devel on 2019-01-25

   The upstream SPI NAND framework is available in 4.19.

   As for raw nand driver for AR9344/QCA9558, the ar934x-nfc driver
   isn't ported to ath79 yet.

 From https://github.com/openwrt/openwrt/pull/1428 on 2018-11-26

   (In reference to patches trying to support the GL.iNet AR300M NAND
    without using the spi-nand as it not present in Kernel 4.14)

   Please re-spin the patch as soon as we have kernel 4.19 support. The
   approach was already NAK'ed upstream and I don't see much gain in
   adding the hack if the next major kernel in OpenWrt will provide a
   suitable solution.
---
  target/linux/ath79/image/nand.mk | 15 ++-------------
  1 file changed, 2 insertions(+), 13 deletions(-)

-endef
-TARGET_DEVICES += glinet_gl-ar300m-nand
+# No NAND drivers available for the ath79 target at this time
+# (January, 2018)

Comments

Jeff Kletsky Jan. 28, 2019, 6:07 p.m. UTC | #1
(Resend due to garbled patch)

 From 7bd39bc01d8b0a03e796268f06f99b5a65fc353a Mon Sep 17 00:00:00 2001

From: Jeff Kletsky <git-commits@allycomm.com>
Date: Mon, 28 Jan 2019 08:25:52 -0800
Subject: [PATCH] ath79: Remove NAND targets as no available drivers

At this time, there are no drivers for NAND flash for ath79.

Remove the only present ath79 NAND target, GL.iNet AR300M,
as it will not boot due to lack of a suitable NAND driver.

 From openwrt-devel on 2019-01-25

   The upstream SPI NAND framework is available in 4.19.

   As for raw nand driver for AR9344/QCA9558, the ar934x-nfc driver
   isn't ported to ath79 yet.

 From https://github.com/openwrt/openwrt/pull/1428 on 2018-11-26

   (In reference to patches trying to support the GL.iNet AR300M NAND
    without using the spi-nand as it not present in Kernel 4.14)

   Please re-spin the patch as soon as we have kernel 4.19 support. The
   approach was already NAK'ed upstream and I don't see much gain in
   adding the hack if the next major kernel in OpenWrt will provide a
   suitable solution.
---
  target/linux/ath79/image/nand.mk | 15 ++-------------
  1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/target/linux/ath79/image/nand.mk 
b/target/linux/ath79/image/nand.mk
index eee419194b..91873ef007 100644
--- a/target/linux/ath79/image/nand.mk
+++ b/target/linux/ath79/image/nand.mk
@@ -1,13 +1,2 @@
-define Device/glinet_gl-ar300m-nand
-  ATH_SOC := qca9531
-  DEVICE_TITLE := GL-AR300M (NAND)
-  DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-storage 
kmod-usb-ledtrig-usbport
-  KERNEL_SIZE := 2048k
-  BLOCKSIZE := 128k
-  PAGESIZE := 2048
-  VID_HDR_OFFSET := 512
-  IMAGES += factory.ubi
-  IMAGE/sysupgrade.bin := sysupgrade-tar
-  IMAGE/factory.ubi := append-kernel | pad-to $$$$(KERNEL_SIZE) | 
append-ubi
-endef
-TARGET_DEVICES += glinet_gl-ar300m-nand
+# No NAND drivers available for the ath79 target at this time
+# (January, 2018)
Jeff Kletsky April 29, 2019, 7:33 a.m. UTC | #2
Updating this patch as likely still valuable for v19

WIP on master edited for Linux 4.19 and ath79 spi-nand suggests that
support will be possible after ath79 master moves to Linux 4.19

Jeff



 From 7bd39bc01d8b0a03e796268f06f99b5a65fc353a Mon Sep 17 00:00:00 2001
From: Jeff Kletsky <git-commits@allycomm.com>
Date: Mon, 28 Jan 2019 08:25:52 -0800
Subject: [PATCH] ath79: Remove NAND targets as no available drivers

At this time, there are no drivers for NAND flash for ath79.

Remove the only present ath79 NAND target, GL.iNet AR300M,
as it will not boot due to lack of a suitable NAND driver.

 From openwrt-devel on 2019-01-25

   The upstream SPI NAND framework is available in 4.19.

   As for raw nand driver for AR9344/QCA9558, the ar934x-nfc driver
   isn't ported to ath79 yet.

 From https://github.com/openwrt/openwrt/pull/1428 on 2018-11-26

   (In reference to patches trying to support the GL.iNet AR300M NAND
    without using the spi-nand as it not present in Kernel 4.14)

   Please re-spin the patch as soon as we have kernel 4.19 support. The
   approach was already NAK'ed upstream and I don't see much gain in
   adding the hack if the next major kernel in OpenWrt will provide a
   suitable solution.
---
  target/linux/ath79/image/nand.mk | 15 ++-------------
  1 file changed, 2 insertions(+), 13 deletions(-)

diff --git a/target/linux/ath79/image/nand.mk b/target/linux/ath79/image/nand.mk
index eee419194b..91873ef007 100644
--- a/target/linux/ath79/image/nand.mk
+++ b/target/linux/ath79/image/nand.mk
@@ -1,13 +1,2 @@
-define Device/glinet_gl-ar300m-nand
-  ATH_SOC := qca9531
-  DEVICE_TITLE := GL-AR300M (NAND)
-  DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-storage kmod-usb-ledtrig-usbport
-  KERNEL_SIZE := 2048k
-  BLOCKSIZE := 128k
-  PAGESIZE := 2048
-  VID_HDR_OFFSET := 512
-  IMAGES += factory.ubi
-  IMAGE/sysupgrade.bin := sysupgrade-tar
-  IMAGE/factory.ubi := append-kernel | pad-to $$$$(KERNEL_SIZE) | append-ubi
-endef
-TARGET_DEVICES += glinet_gl-ar300m-nand
+# No NAND drivers available for the ath79 target at this time
+# (January, 2019)

Patch
diff mbox series

diff --git a/target/linux/ath79/image/nand.mk 
b/target/linux/ath79/image/nand.mk
index eee419194b..91873ef007 100644
--- a/target/linux/ath79/image/nand.mk
+++ b/target/linux/ath79/image/nand.mk
@@ -1,13 +1,2 @@ 
-define Device/glinet_gl-ar300m-nand
-  ATH_SOC := qca9531
-  DEVICE_TITLE := GL-AR300M (NAND)
-  DEVICE_PACKAGES := kmod-usb-core kmod-usb2 kmod-usb-storage 
kmod-usb-ledtrig-usbport
-  KERNEL_SIZE := 2048k
-  BLOCKSIZE := 128k
-  PAGESIZE := 2048
-  VID_HDR_OFFSET := 512
-  IMAGES += factory.ubi
-  IMAGE/sysupgrade.bin := sysupgrade-tar
-  IMAGE/factory.ubi := append-kernel | pad-to $$$$(KERNEL_SIZE) | 
append-ubi