Patchwork target-alpha, target-ppc: Remove unnecessary setjmp.h include

login
register
mail settings
Submitter Peter Maydell
Date July 4, 2011, 9:02 p.m.
Message ID <1309813366-7994-1-git-send-email-peter.maydell@linaro.org>
Download mbox | patch
Permalink /patch/103168/
State New
Headers show

Comments

Peter Maydell - July 4, 2011, 9:02 p.m.
Remove the include of setjmp.h from the cpu.h of target-alpha
and target-ppc. This is unnecessary because cpu-defs.h already
includes this header; this change brings these two targets
into line with all the rest.

Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
---
 target-alpha/cpu.h |    2 --
 target-ppc/cpu.h   |    2 --
 2 files changed, 0 insertions(+), 4 deletions(-)
Alexander Graf - July 4, 2011, 9:45 p.m.
On 04.07.2011, at 23:02, Peter Maydell wrote:

> Remove the include of setjmp.h from the cpu.h of target-alpha
> and target-ppc. This is unnecessary because cpu-defs.h already
> includes this header; this change brings these two targets
> into line with all the rest.
> 
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>

Yeah, I actually think no code (unless specifically configure'd for it) should include non-local headers (<...> instead of "..."). Of course that would include device/target specific headers as well ;).


Acked-by: Alexander Graf <agraf@suse.de>

> ---
> target-alpha/cpu.h |    2 --
> target-ppc/cpu.h   |    2 --
> 2 files changed, 0 insertions(+), 4 deletions(-)
> 
> diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
> index 411bd55..78caa79 100644
> --- a/target-alpha/cpu.h
> +++ b/target-alpha/cpu.h
> @@ -28,8 +28,6 @@
> 
> #include "cpu-defs.h"
> 
> -#include <setjmp.h>
> -
> #include "softfloat.h"
> 
> #define TARGET_HAS_ICE 1
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 84f8ff6..d903366 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -75,8 +75,6 @@
> 
> #include "cpu-defs.h"
> 
> -#include <setjmp.h>
> -
> #include "softfloat.h"
> 
> #define TARGET_HAS_ICE 1
> -- 
> 1.7.4.1
> 
>
Blue Swirl - July 12, 2011, 9:29 p.m.
Thanks, applied.

On Tue, Jul 5, 2011 at 12:02 AM, Peter Maydell <peter.maydell@linaro.org> wrote:
> Remove the include of setjmp.h from the cpu.h of target-alpha
> and target-ppc. This is unnecessary because cpu-defs.h already
> includes this header; this change brings these two targets
> into line with all the rest.
>
> Signed-off-by: Peter Maydell <peter.maydell@linaro.org>
> ---
>  target-alpha/cpu.h |    2 --
>  target-ppc/cpu.h   |    2 --
>  2 files changed, 0 insertions(+), 4 deletions(-)
>
> diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
> index 411bd55..78caa79 100644
> --- a/target-alpha/cpu.h
> +++ b/target-alpha/cpu.h
> @@ -28,8 +28,6 @@
>
>  #include "cpu-defs.h"
>
> -#include <setjmp.h>
> -
>  #include "softfloat.h"
>
>  #define TARGET_HAS_ICE 1
> diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
> index 84f8ff6..d903366 100644
> --- a/target-ppc/cpu.h
> +++ b/target-ppc/cpu.h
> @@ -75,8 +75,6 @@
>
>  #include "cpu-defs.h"
>
> -#include <setjmp.h>
> -
>  #include "softfloat.h"
>
>  #define TARGET_HAS_ICE 1
> --
> 1.7.4.1
>
>
>

Patch

diff --git a/target-alpha/cpu.h b/target-alpha/cpu.h
index 411bd55..78caa79 100644
--- a/target-alpha/cpu.h
+++ b/target-alpha/cpu.h
@@ -28,8 +28,6 @@ 
 
 #include "cpu-defs.h"
 
-#include <setjmp.h>
-
 #include "softfloat.h"
 
 #define TARGET_HAS_ICE 1
diff --git a/target-ppc/cpu.h b/target-ppc/cpu.h
index 84f8ff6..d903366 100644
--- a/target-ppc/cpu.h
+++ b/target-ppc/cpu.h
@@ -75,8 +75,6 @@ 
 
 #include "cpu-defs.h"
 
-#include <setjmp.h>
-
 #include "softfloat.h"
 
 #define TARGET_HAS_ICE 1