[1/6] dt-bindings: usb: xhci-tegra: Add Tegra186 support

Message ID 20190125113013.11447-1-thierry.reding@gmail.com
State Changes Requested
Headers show
Series
  • [1/6] dt-bindings: usb: xhci-tegra: Add Tegra186 support
Related show

Commit Message

Thierry Reding Jan. 25, 2019, 11:30 a.m.
From: Thierry Reding <treding@nvidia.com>

Extend the bindings to cover the set of features found in Tegra186.

Signed-off-by: Thierry Reding <treding@nvidia.com>
---
 .../devicetree/bindings/usb/nvidia,tegra124-xusb.txt          | 4 ++++
 1 file changed, 4 insertions(+)

Comments

jckuo Jan. 28, 2019, 7:46 a.m. | #1
Reviewed-by: JC Kuo <jckuo@nvidia.com>

On 1/25/19 7:30 PM, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
>
> Extend the bindings to cover the set of features found in Tegra186.
>
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>   .../devicetree/bindings/usb/nvidia,tegra124-xusb.txt          | 4 ++++
>   1 file changed, 4 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
> index 4156c3e181c5..5bfcc0b4d6b9 100644
> --- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
> +++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
> @@ -10,6 +10,7 @@ Required properties:
>     - Tegra124: "nvidia,tegra124-xusb"
>     - Tegra132: "nvidia,tegra132-xusb", "nvidia,tegra124-xusb"
>     - Tegra210: "nvidia,tegra210-xusb"
> +  - Tegra186: "nvidia,tegra186-xusb"
>   - reg: Must contain the base and length of the xHCI host registers, XUSB FPCI
>     registers and XUSB IPFS registers.
>   - reg-names: Must contain the following entries:
> @@ -59,6 +60,8 @@ For Tegra210:
>   - avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
>   - dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
>   - hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V.
> +
> +For Tegra210 and Tegra186:
>   - power-domains: A list of PM domain specifiers that reference each power-domain
>     used by the xHCI controller. This list must comprise of a specifier for the
>     XUSBA and XUSBC power-domains. See ../power/power_domain.txt and
> @@ -78,6 +81,7 @@ Optional properties:
>     - Tegra132: usb2-0, usb2-1, usb2-2, hsic-0, hsic-1, usb3-0, usb3-1
>     - Tegra210: usb2-0, usb2-1, usb2-2, usb2-3, hsic-0, usb3-0, usb3-1, usb3-2,
>                 usb3-3
> +  - Tegra186: usb2-0, usb2-1, usb2-2, hsic-0, usb3-0, usb3-1, usb3-2
>   
>   Example:
>   --------
Thierry Reding Feb. 7, 2019, 11:14 a.m. | #2
On Fri, Jan 25, 2019 at 12:30:08PM +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Extend the bindings to cover the set of features found in Tegra186.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  .../devicetree/bindings/usb/nvidia,tegra124-xusb.txt          | 4 ++++
>  1 file changed, 4 insertions(+)

Hi Greg, Mathias,

do you have any comments on this series or is it good to go into v5.1?

Thanks,
Thierry
Mathias Nyman Feb. 13, 2019, 3:21 p.m. | #3
On 07.02.2019 13:14, Thierry Reding wrote:
> On Fri, Jan 25, 2019 at 12:30:08PM +0100, Thierry Reding wrote:
>> From: Thierry Reding <treding@nvidia.com>
>>
>> Extend the bindings to cover the set of features found in Tegra186.
>>
>> Signed-off-by: Thierry Reding <treding@nvidia.com>
>> ---
>>   .../devicetree/bindings/usb/nvidia,tegra124-xusb.txt          | 4 ++++
>>   1 file changed, 4 insertions(+)
> 
> Hi Greg, Mathias,
> 
> do you have any comments on this series or is it good to go into v5.1?
> 

xhci parts look good to me, (patches 2/6 and 3/6)
Sorry about the delay.

Acked-by: Mathias Nyman <mathias.nyman@linux.intel.com>
Rob Herring Feb. 23, 2019, 12:36 a.m. | #4
On Fri, 25 Jan 2019 12:30:08 +0100, Thierry Reding wrote:
> From: Thierry Reding <treding@nvidia.com>
> 
> Extend the bindings to cover the set of features found in Tegra186.
> 
> Signed-off-by: Thierry Reding <treding@nvidia.com>
> ---
>  .../devicetree/bindings/usb/nvidia,tegra124-xusb.txt          | 4 ++++
>  1 file changed, 4 insertions(+)
> 

Reviewed-by: Rob Herring <robh@kernel.org>

Patch

diff --git a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
index 4156c3e181c5..5bfcc0b4d6b9 100644
--- a/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
+++ b/Documentation/devicetree/bindings/usb/nvidia,tegra124-xusb.txt
@@ -10,6 +10,7 @@  Required properties:
   - Tegra124: "nvidia,tegra124-xusb"
   - Tegra132: "nvidia,tegra132-xusb", "nvidia,tegra124-xusb"
   - Tegra210: "nvidia,tegra210-xusb"
+  - Tegra186: "nvidia,tegra186-xusb"
 - reg: Must contain the base and length of the xHCI host registers, XUSB FPCI
   registers and XUSB IPFS registers.
 - reg-names: Must contain the following entries:
@@ -59,6 +60,8 @@  For Tegra210:
 - avdd-pll-uerefe-supply: PLLE reference PLL power supply. Must supply 1.05 V.
 - dvdd-pex-pll-supply: PCIe/USB3 PLL power supply. Must supply 1.05 V.
 - hvdd-pex-pll-e-supply: High-voltage PLLE power supply. Must supply 1.8 V.
+
+For Tegra210 and Tegra186:
 - power-domains: A list of PM domain specifiers that reference each power-domain
   used by the xHCI controller. This list must comprise of a specifier for the
   XUSBA and XUSBC power-domains. See ../power/power_domain.txt and
@@ -78,6 +81,7 @@  Optional properties:
   - Tegra132: usb2-0, usb2-1, usb2-2, hsic-0, hsic-1, usb3-0, usb3-1
   - Tegra210: usb2-0, usb2-1, usb2-2, usb2-3, hsic-0, usb3-0, usb3-1, usb3-2,
               usb3-3
+  - Tegra186: usb2-0, usb2-1, usb2-2, hsic-0, usb3-0, usb3-1, usb3-2
 
 Example:
 --------