Patchwork [net-next] myri10ge: fix indentation

login
register
mail settings
Submitter Brice Goglin
Date Nov. 23, 2008, 1:43 p.m.
Message ID <49295DFD.9050609@myri.com>
Download mbox | patch
Permalink /patch/10308/
State Rejected
Delegated to: David Miller
Headers show

Comments

Brice Goglin - Nov. 23, 2008, 1:43 p.m.
Bring the indentation in line with the output of the Lindent script.

Signed-off-by: Brice Goglin <brice@myri.com>



--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Nov. 24, 2008, 10:43 p.m.
From: Brice Goglin <brice@myri.com>
Date: Sun, 23 Nov 2008 14:43:25 +0100

> Bring the indentation in line with the output of the Lindent script.
> 
> Signed-off-by: Brice Goglin <brice@myri.com>

Please don't blindly apply tools like this.

>  static const struct net_device_ops myri10ge_netdev_ops = {
> -	.ndo_open		= myri10ge_open,
> -	.ndo_stop		= myri10ge_close,
> -	.ndo_start_xmit		= myri10ge_xmit,
> -	.ndo_get_stats		= myri10ge_get_stats,
> -	.ndo_validate_addr	= eth_validate_addr,
> -	.ndo_change_mtu		= myri10ge_change_mtu,
> +	.ndo_open = myri10ge_open,
> +	.ndo_stop = myri10ge_close,
> +	.ndo_start_xmit = myri10ge_xmit,
> +	.ndo_get_stats = myri10ge_get_stats,
> +	.ndo_validate_addr = eth_validate_addr,
> +	.ndo_change_mtu = myri10ge_change_mtu,
>  	.ndo_set_multicast_list = myri10ge_set_multicast_list,
> -	.ndo_set_mac_address	= myri10ge_set_mac_address,
> +	.ndo_set_mac_address = myri10ge_set_mac_address,
>  };
>  

I specifically used tabs here when applying this, on the left side of
the equal sign, in order to line everything up nicely.  And now this
patch is undoing that.

Patch not applied.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Brice Goglin - Nov. 24, 2008, 10:52 p.m.
David Miller wrote:
> From: Brice Goglin <brice@myri.com>
> Date: Sun, 23 Nov 2008 14:43:25 +0100
>
>   
>> Bring the indentation in line with the output of the Lindent script.
>>
>> Signed-off-by: Brice Goglin <brice@myri.com>
>>     
>
> Please don't blindly apply tools like this.
>   

We apply indent because our internal CVS contains some #ifdef'ery to
support old kernels and we want to cleanup the mess before submitting
patches. I'll see if I can hack something here to make this struct
initializer match your will.

Brice

--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
David Miller - Nov. 24, 2008, 10:55 p.m.
From: Brice Goglin <brice@myri.com>
Date: Mon, 24 Nov 2008 23:52:47 +0100

> We apply indent because our internal CVS contains some #ifdef'ery to
> support old kernels and we want to cleanup the mess before submitting
> patches.

That, of course, is purely your problem not ours.
--
To unsubscribe from this list: send the line "unsubscribe netdev" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Patch

--- net-next-2.6/drivers/net/myri10ge/myri10ge.c	2008-11-23 14:35:01.000000000 +0100
+++ linux-tmp/drivers/net/myri10ge/myri10ge.c	2008-11-23 11:57:24.000000000 +0100
@@ -1024,7 +1024,7 @@ 
 			ss->dca_tag = NULL;
 		}
 	}
-#endif				/* CONFIG_MYRI10GE_DCA */
+#endif /* CONFIG_MYRI10GE_DCA */
 
 	/* reset mcp/driver shared state back to 0 */
 
@@ -1121,7 +1121,7 @@ 
 		myri10ge_teardown_dca(mgp);
 	return 0;
 }
-#endif				/* CONFIG_MYRI10GE_DCA */
+#endif /* CONFIG_MYRI10GE_DCA */
 
 static inline void
 myri10ge_submit_8rx(struct mcp_kreq_ether_recv __iomem * dst,
@@ -3370,7 +3370,7 @@ 
 	return -EIO;
 
 }
-#endif				/* CONFIG_PM */
+#endif /* CONFIG_PM */
 
 static u32 myri10ge_read_reboot(struct myri10ge_priv *mgp)
 {
@@ -3732,14 +3732,14 @@ 
 }
 
 static const struct net_device_ops myri10ge_netdev_ops = {
-	.ndo_open		= myri10ge_open,
-	.ndo_stop		= myri10ge_close,
-	.ndo_start_xmit		= myri10ge_xmit,
-	.ndo_get_stats		= myri10ge_get_stats,
-	.ndo_validate_addr	= eth_validate_addr,
-	.ndo_change_mtu		= myri10ge_change_mtu,
+	.ndo_open = myri10ge_open,
+	.ndo_stop = myri10ge_close,
+	.ndo_start_xmit = myri10ge_xmit,
+	.ndo_get_stats = myri10ge_get_stats,
+	.ndo_validate_addr = eth_validate_addr,
+	.ndo_change_mtu = myri10ge_change_mtu,
 	.ndo_set_multicast_list = myri10ge_set_multicast_list,
-	.ndo_set_mac_address	= myri10ge_set_mac_address,
+	.ndo_set_mac_address = myri10ge_set_mac_address,
 };
 
 static int myri10ge_probe(struct pci_dev *pdev, const struct pci_device_id *ent)
@@ -4027,7 +4027,7 @@ 
 	.next = NULL,
 	.priority = 0,
 };
-#endif				/* CONFIG_MYRI10GE_DCA */
+#endif /* CONFIG_MYRI10GE_DCA */
 
 static __init int myri10ge_init_module(void)
 {
--- net-next-2.6/drivers/net/myri10ge/myri10ge_mcp.h	2008-10-29 10:25:24.000000000 +0100
+++ linux-tmp/drivers/net/myri10ge/myri10ge_mcp.h	2008-11-23 11:57:24.000000000 +0100
@@ -423,4 +423,4 @@ 
 #define MXGEFW_NETQ_FILTERTYPE_VLAN 2
 #define MXGEFW_NETQ_FILTERTYPE_VLANMACADDR 3
 
-#endif				/* __MYRI10GE_MCP_H__ */
+#endif /* __MYRI10GE_MCP_H__ */
diff -ur net-next-2.6/drivers/net/myri10ge/myri10ge_mcp_gen_header.h /home/bgoglin/myri10ge/myri10ge-cvs/linux/linux-tmp/drivers/net/myri10ge/myri10ge_mcp_gen_header.h
--- net-next-2.6/drivers/net/myri10ge/myri10ge_mcp_gen_header.h	2008-11-23 14:36:02.000000000 +0100
+++ linux-tmp/drivers/net/myri10ge/myri10ge_mcp_gen_header.h	2008-11-23 11:57:24.000000000 +0100
@@ -45,4 +45,4 @@ 
 	/* 8 */
 };
 
-#endif				/* __MYRI10GE_MCP_GEN_HEADER_H__ */
+#endif /* __MYRI10GE_MCP_GEN_HEADER_H__ */