From patchwork Thu Jan 24 16:58:27 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Daniel Vetter X-Patchwork-Id: 1030571 Return-Path: X-Original-To: incoming@patchwork.ozlabs.org Delivered-To: patchwork-incoming@bilbo.ozlabs.org Authentication-Results: ozlabs.org; spf=none (mailfrom) smtp.mailfrom=vger.kernel.org (client-ip=209.132.180.67; helo=vger.kernel.org; envelope-from=linux-tegra-owner@vger.kernel.org; receiver=) Authentication-Results: ozlabs.org; dmarc=none (p=none dis=none) header.from=ffwll.ch Authentication-Results: ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=ffwll.ch header.i=@ffwll.ch header.b="bp0conmV"; dkim-atps=neutral Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by ozlabs.org (Postfix) with ESMTP id 43lpKJ3dcJz9sBn for ; Fri, 25 Jan 2019 03:59:16 +1100 (AEDT) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726252AbfAXQ7P (ORCPT ); Thu, 24 Jan 2019 11:59:15 -0500 Received: from mail-ed1-f68.google.com ([209.85.208.68]:34318 "EHLO mail-ed1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727443AbfAXQ7P (ORCPT ); Thu, 24 Jan 2019 11:59:15 -0500 Received: by mail-ed1-f68.google.com with SMTP id b3so5187661ede.1 for ; Thu, 24 Jan 2019 08:59:14 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ffwll.ch; s=google; h=from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding; bh=fp1C/+4GE67gkaUF1IXPEiFlAtDyLhIZQ9A3rmhlSA0=; b=bp0conmV1H8z/2z34YvMk2ofkh03N/L+fcNfgtC3E1fECDo8UB/pNJgUAonU92WWl1 ajfte9J+srWGipfOaYAWYlPkJjqNeOYu24BN7Rt0gjqBHrXJYpHuZQUsxM+sSKkNeoD9 azDsEnpIYXO0KSoVdFhN3yPD64uIfuXHS19VQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:in-reply-to :references:mime-version:content-transfer-encoding; bh=fp1C/+4GE67gkaUF1IXPEiFlAtDyLhIZQ9A3rmhlSA0=; b=mmLSazWU9lOkZm/GmVF0vTUOvTE/db88G15KISwdaCne6m6FoD5lhMDWpucFP9CDor YpmIuePIFHckgHnDh76rpYhxnQqbc/Y/2pFZHzz7nmLlDsTZ6IidjgIYBn5IUjWWUiWW sisi7p44cbmwyONnDeUA2D8EtEkysAFDZpSrrPtl9bEpKe2RZq6a/W8wH5onSFUX+Udu Mve0GWzwNV4ioy5CyHxrT5r71vifztP2Ag46Vb+Gu/RFtF2LqRk2TNsj/2g/qQpBGxFM byi7pRDrNR2T5oRl/ZZz0rzX0a9wfg6+eW3xUxxsRL5a/uMO0py9WFvZqmW50z9WFoS4 3pDA== X-Gm-Message-State: AJcUukczWzH5KClgT3EkhLevp7U2lThq5LJaeKZWBXCzD7ST+Oc6jBzc 3uFEBljsO/KCctuB6Wl3W7wROQ== X-Google-Smtp-Source: ALg8bN5Z+0uZpaFK4VkkIY1//UZcgCgoQYRDYFMTOx+Tek7VJgnBrF27FPED8tlaj/drrzW8wYsItw== X-Received: by 2002:a50:b5a5:: with SMTP id a34mr7359577ede.52.1548349153790; Thu, 24 Jan 2019 08:59:13 -0800 (PST) Received: from phenom.ffwll.local ([2a02:168:569e:0:3106:d637:d723:e855]) by smtp.gmail.com with ESMTPSA id w31sm11219233edw.82.2019.01.24.08.59.12 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 24 Jan 2019 08:59:12 -0800 (PST) From: Daniel Vetter To: DRI Development Cc: Intel Graphics Development , Daniel Vetter , Daniel Vetter , Thierry Reding , Jonathan Hunter , linux-tegra@vger.kernel.org Subject: [PATCH 22/26] drm/qxl: Use drm_fb_helper_fill_info Date: Thu, 24 Jan 2019 17:58:27 +0100 Message-Id: <20190124165831.16427-23-daniel.vetter@ffwll.ch> X-Mailer: git-send-email 2.20.1 In-Reply-To: <20190124165831.16427-1-daniel.vetter@ffwll.ch> References: <20190124165831.16427-1-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Sender: linux-tegra-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-tegra@vger.kernel.org Another driver that didn't set fbinfo->fix.id before. Signed-off-by: Daniel Vetter Cc: Thierry Reding Cc: Jonathan Hunter Cc: linux-tegra@vger.kernel.org Acked-by: Thierry Reding --- drivers/gpu/drm/tegra/fb.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers/gpu/drm/tegra/fb.c b/drivers/gpu/drm/tegra/fb.c index 5ee48a6bb3ad..82348ddd0b83 100644 --- a/drivers/gpu/drm/tegra/fb.c +++ b/drivers/gpu/drm/tegra/fb.c @@ -255,12 +255,10 @@ static int tegra_fbdev_probe(struct drm_fb_helper *helper, helper->fb = fb; helper->fbdev = info; - info->par = helper; info->flags = FBINFO_FLAG_DEFAULT; info->fbops = &tegra_fb_ops; - drm_fb_helper_fill_fix(info, fb->pitches[0], fb->format->depth); - drm_fb_helper_fill_var(info, helper, fb->width, fb->height); + drm_fb_helper_fill_info(info, helper); offset = info->var.xoffset * bytes_per_pixel + info->var.yoffset * fb->pitches[0];