[-next] gpio: davinci: drop pointless static qualifier
diff mbox series

Message ID 20190123084912.13376-1-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] gpio: davinci: drop pointless static qualifier
Related show

Commit Message

YueHaibing Jan. 23, 2019, 8:49 a.m. UTC
There is no need to have the 'gpio_unbanked' variable static since
new value always be assigned before use it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/gpio/gpio-davinci.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

Comments

Keerthy Jan. 23, 2019, 10:32 a.m. UTC | #1
On 23/01/19 2:19 PM, YueHaibing wrote:
> There is no need to have the 'gpio_unbanked' variable static since
> new value always be assigned before use it.

Acked-by: Keerthy <j-keerthy@ti.com>

> 
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> ---
>  drivers/gpio/gpio-davinci.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> index bdb29e5..f250454 100644
> --- a/drivers/gpio/gpio-davinci.c
> +++ b/drivers/gpio/gpio-davinci.c
> @@ -465,7 +465,7 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = {
>  
>  static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
>  {
> -	static struct irq_chip_type gpio_unbanked;
> +	struct irq_chip_type gpio_unbanked;
>  
>  	gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
>  
> @@ -474,7 +474,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
>  
>  static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
>  {
> -	static struct irq_chip gpio_unbanked;
> +	struct irq_chip gpio_unbanked;
>  
>  	gpio_unbanked = *irq_get_chip(irq);
>  	return &gpio_unbanked;
>
Bartosz Golaszewski Jan. 23, 2019, 4:12 p.m. UTC | #2
śr., 23 sty 2019 o 11:32 Keerthy <j-keerthy@ti.com> napisał(a):
>
> On 23/01/19 2:19 PM, YueHaibing wrote:
> > There is no need to have the 'gpio_unbanked' variable static since
> > new value always be assigned before use it.
>
> Acked-by: Keerthy <j-keerthy@ti.com>
>
> >
> > Signed-off-by: YueHaibing <yuehaibing@huawei.com>
> > ---
> >  drivers/gpio/gpio-davinci.c | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
> > index bdb29e5..f250454 100644
> > --- a/drivers/gpio/gpio-davinci.c
> > +++ b/drivers/gpio/gpio-davinci.c
> > @@ -465,7 +465,7 @@ static const struct irq_domain_ops davinci_gpio_irq_ops = {
> >
> >  static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
> >  {
> > -     static struct irq_chip_type gpio_unbanked;
> > +     struct irq_chip_type gpio_unbanked;
> >
> >       gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
> >
> > @@ -474,7 +474,7 @@ static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
> >
> >  static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
> >  {
> > -     static struct irq_chip gpio_unbanked;
> > +     struct irq_chip gpio_unbanked;
> >
> >       gpio_unbanked = *irq_get_chip(irq);
> >       return &gpio_unbanked;
> >
>

Good catch! While it would probably never result in a race condition
as it is always called from probe(), it's still wrong so patch
applied.

Thanks,
Bart

Patch
diff mbox series

diff --git a/drivers/gpio/gpio-davinci.c b/drivers/gpio/gpio-davinci.c
index bdb29e5..f250454 100644
--- a/drivers/gpio/gpio-davinci.c
+++ b/drivers/gpio/gpio-davinci.c
@@ -465,7 +465,7 @@  static const struct irq_domain_ops davinci_gpio_irq_ops = {
 
 static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
 {
-	static struct irq_chip_type gpio_unbanked;
+	struct irq_chip_type gpio_unbanked;
 
 	gpio_unbanked = *irq_data_get_chip_type(irq_get_irq_data(irq));
 
@@ -474,7 +474,7 @@  static struct irq_chip *davinci_gpio_get_irq_chip(unsigned int irq)
 
 static struct irq_chip *keystone_gpio_get_irq_chip(unsigned int irq)
 {
-	static struct irq_chip gpio_unbanked;
+	struct irq_chip gpio_unbanked;
 
 	gpio_unbanked = *irq_get_chip(irq);
 	return &gpio_unbanked;