[-next] pinctrl: sirf: drop pointless static qualifier in sirfsoc_gpio_probe
diff mbox series

Message ID 20190123084140.16524-1-yuehaibing@huawei.com
State New
Headers show
Series
  • [-next] pinctrl: sirf: drop pointless static qualifier in sirfsoc_gpio_probe
Related show

Commit Message

YueHaibing Jan. 23, 2019, 8:41 a.m. UTC
There is no need to have the 'sgpio' variable static since new
value always be assigned before use it.

Signed-off-by: YueHaibing <yuehaibing@huawei.com>
---
 drivers/pinctrl/sirf/pinctrl-sirf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Linus Walleij Jan. 28, 2019, 1:43 p.m. UTC | #1
On Wed, Jan 23, 2019 at 9:42 AM YueHaibing <yuehaibing@huawei.com> wrote:

> There is no need to have the 'sgpio' variable static since new
> value always be assigned before use it.
>
> Signed-off-by: YueHaibing <yuehaibing@huawei.com>

Patch applied.

I haven't heard from the SirfSoC people in some time, I wonder
if they still actively maintain this file?

Yours,
Linus Walleij

Patch
diff mbox series

diff --git a/drivers/pinctrl/sirf/pinctrl-sirf.c b/drivers/pinctrl/sirf/pinctrl-sirf.c
index 2e42d73..2b3bd1a 100644
--- a/drivers/pinctrl/sirf/pinctrl-sirf.c
+++ b/drivers/pinctrl/sirf/pinctrl-sirf.c
@@ -782,7 +782,7 @@  static void sirfsoc_gpio_set_pulldown(struct sirfsoc_gpio_chip *sgpio,
 static int sirfsoc_gpio_probe(struct device_node *np)
 {
 	int i, err = 0;
-	static struct sirfsoc_gpio_chip *sgpio;
+	struct sirfsoc_gpio_chip *sgpio;
 	struct sirfsoc_gpio_bank *bank;
 	void __iomem *regs;
 	struct platform_device *pdev;