| Message ID | 20190123083758.8412-1-yuehaibing@huawei.com (mailing list archive) |
|---|---|
| State | Not Applicable |
| Headers | show |
| Series | [-next] usb: host: drop pointless static qualifier | expand |
| Context | Check | Description |
|---|---|---|
| snowpatch_ozlabs/apply_patch | success | next/apply_patch Successfully applied |
| snowpatch_ozlabs/build-ppc64le | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64be | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-ppc64e | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/build-pmac32 | success | build succeeded & removed 0 sparse warning(s) |
| snowpatch_ozlabs/checkpatch | success | total: 0 errors, 0 warnings, 0 checks, 16 lines checked |
On Wed, 23 Jan 2019, YueHaibing wrote: > There is no need to have the 'dummy_mask' variable static since new > value always be assigned before use it. > > Signed-off-by: YueHaibing <yuehaibing@huawei.com> > --- > drivers/usb/host/ehci-ps3.c | 2 +- > drivers/usb/host/ohci-ps3.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/usb/host/ehci-ps3.c b/drivers/usb/host/ehci-ps3.c > index 454d8c6..91cee02 100644 > --- a/drivers/usb/host/ehci-ps3.c > +++ b/drivers/usb/host/ehci-ps3.c > @@ -86,7 +86,7 @@ static int ps3_ehci_probe(struct ps3_system_bus_device *dev) > int result; > struct usb_hcd *hcd; > unsigned int virq; > - static u64 dummy_mask; > + u64 dummy_mask; > > if (usb_disabled()) { > result = -ENODEV; > diff --git a/drivers/usb/host/ohci-ps3.c b/drivers/usb/host/ohci-ps3.c > index 395f9d3..a1c1bdf 100644 > --- a/drivers/usb/host/ohci-ps3.c > +++ b/drivers/usb/host/ohci-ps3.c > @@ -69,7 +69,7 @@ static int ps3_ohci_probe(struct ps3_system_bus_device *dev) > int result; > struct usb_hcd *hcd; > unsigned int virq; > - static u64 dummy_mask; > + u64 dummy_mask; > > if (usb_disabled()) { > result = -ENODEV; No. You need to read the code and understand how a variable is used before you decide to modify it. In this case, a suitable approach would be to change the declaration so that it says: status u64 dummy_mask = DMA_BIT_MASK(32); and remove the line that does the assignment dynamically. Alan Stern
On 2019/1/24 0:09, Alan Stern wrote: > On Wed, 23 Jan 2019, YueHaibing wrote: > >> There is no need to have the 'dummy_mask' variable static since new >> value always be assigned before use it. >> >> Signed-off-by: YueHaibing <yuehaibing@huawei.com> >> --- >> drivers/usb/host/ehci-ps3.c | 2 +- >> drivers/usb/host/ohci-ps3.c | 2 +- >> 2 files changed, 2 insertions(+), 2 deletions(-) >> >> diff --git a/drivers/usb/host/ehci-ps3.c b/drivers/usb/host/ehci-ps3.c >> index 454d8c6..91cee02 100644 >> --- a/drivers/usb/host/ehci-ps3.c >> +++ b/drivers/usb/host/ehci-ps3.c >> @@ -86,7 +86,7 @@ static int ps3_ehci_probe(struct ps3_system_bus_device *dev) >> int result; >> struct usb_hcd *hcd; >> unsigned int virq; >> - static u64 dummy_mask; >> + u64 dummy_mask; >> >> if (usb_disabled()) { >> result = -ENODEV; >> diff --git a/drivers/usb/host/ohci-ps3.c b/drivers/usb/host/ohci-ps3.c >> index 395f9d3..a1c1bdf 100644 >> --- a/drivers/usb/host/ohci-ps3.c >> +++ b/drivers/usb/host/ohci-ps3.c >> @@ -69,7 +69,7 @@ static int ps3_ohci_probe(struct ps3_system_bus_device *dev) >> int result; >> struct usb_hcd *hcd; >> unsigned int virq; >> - static u64 dummy_mask; >> + u64 dummy_mask; >> >> if (usb_disabled()) { >> result = -ENODEV; > > No. You need to read the code and understand how a variable is used > before you decide to modify it. Sorry, I misread the code, so just leave it as is. > > In this case, a suitable approach would be to change the declaration > so that it says: > > status u64 dummy_mask = DMA_BIT_MASK(32); > > and remove the line that does the assignment dynamically. > > Alan Stern > > > . >
diff --git a/drivers/usb/host/ehci-ps3.c b/drivers/usb/host/ehci-ps3.c index 454d8c6..91cee02 100644 --- a/drivers/usb/host/ehci-ps3.c +++ b/drivers/usb/host/ehci-ps3.c @@ -86,7 +86,7 @@ static int ps3_ehci_probe(struct ps3_system_bus_device *dev) int result; struct usb_hcd *hcd; unsigned int virq; - static u64 dummy_mask; + u64 dummy_mask; if (usb_disabled()) { result = -ENODEV; diff --git a/drivers/usb/host/ohci-ps3.c b/drivers/usb/host/ohci-ps3.c index 395f9d3..a1c1bdf 100644 --- a/drivers/usb/host/ohci-ps3.c +++ b/drivers/usb/host/ohci-ps3.c @@ -69,7 +69,7 @@ static int ps3_ohci_probe(struct ps3_system_bus_device *dev) int result; struct usb_hcd *hcd; unsigned int virq; - static u64 dummy_mask; + u64 dummy_mask; if (usb_disabled()) { result = -ENODEV;
There is no need to have the 'dummy_mask' variable static since new value always be assigned before use it. Signed-off-by: YueHaibing <yuehaibing@huawei.com> --- drivers/usb/host/ehci-ps3.c | 2 +- drivers/usb/host/ohci-ps3.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-)